From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 350DD6C94 for ; Mon, 29 Feb 2016 10:01:49 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 29 Feb 2016 01:01:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,520,1449561600"; d="scan'208";a="897277105" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 29 Feb 2016 01:01:45 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 29 Feb 2016 01:01:43 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 29 Feb 2016 01:01:43 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.18]) with mapi id 14.03.0248.002; Mon, 29 Feb 2016 17:00:44 +0800 From: "Xie, Huawei" To: David Marchand Thread-Topic: [PATCH v4 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't managing the device Thread-Index: AdFyz6vFlt+I3OgASxWLKEeXUbLsZg== Date: Mon, 29 Feb 2016 09:00:43 +0000 Message-ID: References: <20151222035041.GA7532@pxdev.xzpeter.org> <1456451636-118476-1-git-send-email-huawei.xie@intel.com> <1456451636-118476-3-git-send-email-huawei.xie@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "Troitsky, Nikita" Subject: Re: [dpdk-dev] [PATCH v4 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't managing the device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Feb 2016 09:01:49 -0000 On 2/29/2016 4:47 PM, David Marchand wrote:=0A= > On Fri, Feb 26, 2016 at 2:53 AM, Huawei Xie wrote:= =0A= >> v4 changes:=0A= >> reword the commit message. When we mention kernel driver, emphasizes=0A= >> that it includes UIO/VFIO.=0A= > Annotations should not be part of the commitlog itself.=0A= =0A= Do you mean that "rewording the commit message" should not appear in the=0A= commit message itself? Those version changes will not appear in the=0A= commit log when applied, right? So i added this so that reviewers know=0A= that i have changed the commit message otherwise they don't need to=0A= waste their time reviewing the commit message again. Is it that even if=0A= i send a new patch version with only the changes to the commit message ,=0A= i needn't mention this?=0A= >=0A= >> Use RTE_KDRV_NONE to indicate that kernel driver(including UIO/VFIO)=0A= >> isn't manipulating the device.=0A= > missing space before (=0A= =0A= Thomas, could you help change this?=0A= =0A= >=0A= >> Signed-off-by: Huawei Xie =0A= >> Acked-by: Yuanhan Liu =0A= > Thought I already acked this.=0A= > Anyway,=0A= > Acked-by: David Marchand =0A= >=0A= >=0A= =0A=