From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id F0B4E5589 for ; Wed, 16 Mar 2016 09:20:46 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 16 Mar 2016 01:20:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,343,1455004800"; d="scan'208";a="934930949" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 16 Mar 2016 01:20:45 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 16 Mar 2016 01:20:45 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 16 Mar 2016 01:20:45 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.24]) with mapi id 14.03.0248.002; Wed, 16 Mar 2016 16:20:37 +0800 From: "Xie, Huawei" To: Thomas Monjalon , "yuanhan.liu@linux.intel.com" CC: "dev@dpdk.org" , "ann.zhuangyanying@huawei.com" Thread-Topic: [dpdk-dev] [PATCH] vhost: remove lockless enqueue to the virtio ring Thread-Index: AdF/XLglAYv1zYxPSVSc2hPyLN+W6Q== Date: Wed, 16 Mar 2016 08:20:37 +0000 Message-ID: References: <1451918787-85887-1-git-send-email-huawei.xie@intel.com> <13376800.Cqouxc5gkz@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost: remove lockless enqueue to the virtio ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2016 08:20:47 -0000 On 3/15/2016 7:14 AM, Thomas Monjalon wrote:=0A= > 2016-01-05 07:16, Xie, Huawei:=0A= >> On 1/5/2016 2:42 PM, Xie, Huawei wrote:=0A= >>> This patch removes the internal lockless enqueue implmentation.=0A= >>> DPDK doesn't support receiving/transmitting packets from/to the same=0A= >>> queue. Vhost PMD wraps vhost device as normal DPDK port. DPDK=0A= >>> applications normally have their own lock implmentation when enqueue=0A= >>> packets to the same queue of a port.=0A= >>>=0A= >>> The atomic cmpset is a costly operation. This patch should help=0A= >>> performance a bit.=0A= >>>=0A= >>> Signed-off-by: Huawei Xie =0A= >> This patch modifies the API's behavior, which is also a trivial ABI=0A= >> change. In my opinion, application shouldn't rely on previous behavior.= =0A= >> Anyway, i am checking how to declare the ABI change.=0A= > I guess this patch is now obsolete?=0A= =0A= How about we delay this to next release after more considerations,=0A= whether we should keep this behavior, and what is the best way for=0A= concurrency in vhost.=0A= =0A= =0A=