From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <huawei.xie@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 88D9C2E8D
 for <dev@dpdk.org>; Fri, 18 Mar 2016 11:08:45 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP; 18 Mar 2016 03:08:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,354,1455004800"; d="scan'208";a="913801285"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by orsmga001.jf.intel.com with ESMTP; 18 Mar 2016 03:08:43 -0700
Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Fri, 18 Mar 2016 03:08:43 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Fri, 18 Mar 2016 03:08:43 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.18]) with mapi id 14.03.0248.002;
 Fri, 18 Mar 2016 18:08:42 +0800
From: "Xie, Huawei" <huawei.xie@intel.com>
To: Ilya Maximets <i.maximets@samsung.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>
CC: Dyasly Sergey <s.dyasly@samsung.com>, Jerin Jacob
 <jerin.jacob@caviumnetworks.com>, Jianbo Liu <jianbo.liu@linaro.org>, Thomas
 Monjalon <thomas.monjalon@6wind.com>, Tetsuya Mukawa <mukawa@igel.co.jp>
Thread-Topic: [PATCH RFC v3 1/3] vhost: use SMP barriers instead of compiler
 ones.
Thread-Index: AdGA/iVK8b+ddm8JQy6p0FOaeGbrKA==
Date: Fri, 18 Mar 2016 10:08:41 +0000
Message-ID: <C37D651A908B024F974696C65296B57B4C677A7D@SHSMSX101.ccr.corp.intel.com>
References: <1456314438-4021-1-git-send-email-i.maximets@samsung.com>
 <1456314438-4021-2-git-send-email-i.maximets@samsung.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH RFC v3 1/3] vhost: use SMP barriers instead
 of compiler ones.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Mar 2016 10:08:46 -0000

On 2/24/2016 7:47 PM, Ilya Maximets wrote:=0A=
>  		 * Wait until it's our turn to add our buffer=0A=
> @@ -979,7 +979,7 @@ rte_vhost_dequeue_burst(struct virtio_net *dev, uint1=
6_t queue_id,=0A=
>  		entry_success++;=0A=
>  	}=0A=
>  =0A=
> -	rte_compiler_barrier();=0A=
> +	rte_smp_rmb();=0A=
=0A=
smp_rmb()?=0A=
=0A=
>  	vq->used->idx +=3D entry_success;=0A=
>  	vhost_log_used_vring(dev, vq, offsetof(struct vring_used, idx),=0A=
>  			sizeof(vq->used->idx));=0A=
> -- 2.5.0=0A=
=0A=