From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <huawei.xie@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2488B2BE2
 for <dev@dpdk.org>; Mon,  9 May 2016 07:44:07 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 08 May 2016 22:44:07 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,599,1455004800"; d="scan'208";a="975491038"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by fmsmga002.fm.intel.com with ESMTP; 08 May 2016 22:44:07 -0700
Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Sun, 8 May 2016 22:44:05 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Sun, 8 May 2016 22:44:05 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.148]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0248.002;
 Mon, 9 May 2016 13:44:03 +0800
From: "Xie, Huawei" <huawei.xie@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] virtio: split virtio rx/tx queue
Thread-Index: AdGmcQ0ysEggt5/7Q9GTakcbXYug1QC/ZOcAABGzPlA=
Date: Mon, 9 May 2016 05:44:03 +0000
Message-ID: <C37D651A908B024F974696C65296B57B4C752520@SHSMSX101.ccr.corp.intel.com>
References: <1462323027-91942-1-git-send-email-huawei.xie@intel.com>
 <20160505000327.GT5641@yliu-dev.sh.intel.com>
 <C37D651A908B024F974696C65296B57B4C74C637@SHSMSX101.ccr.corp.intel.com>
 <20160505030704.GU5641@yliu-dev.sh.intel.com>
 <C37D651A908B024F974696C65296B57B4C74C7E4@SHSMSX101.ccr.corp.intel.com>
 <20160505035000.GY5641@yliu-dev.sh.intel.com>
 <C37D651A908B024F974696C65296B57B4C74CB1F@SHSMSX101.ccr.corp.intel.com>
 <20160509051438.GZ5641@yliu-dev.sh.intel.com>
In-Reply-To: <20160509051438.GZ5641@yliu-dev.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] virtio: split virtio rx/tx queue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 May 2016 05:44:08 -0000



> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Monday, May 09, 2016 1:15 PM
> To: Xie, Huawei
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] virtio: split virtio rx/tx queue
>=20
> On Thu, May 05, 2016 at 05:29:27AM +0000, Xie, Huawei wrote:
> > What I mean is firstly we split the queue, without breaking the common
> > setup; then introduce RX/TX specific setup calling extracted common
> > setup, so we don't have a chance to introduce duplicated code.
>=20
> In such way, you have actually introduced duplicated code, haven't you?
> You may argue, "yes, but I will fix it in a later patch."  This is to
> introducing a build error and fixing it later to me.
>=20

Yuanhan, I don't see how hard it is to understand this. Duplicated code isn=
't introduced. I will send the patch later.

> 	--yliu