From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3AB042BF0; Wed, 31 May 2023 13:21:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AB9A40F18; Wed, 31 May 2023 13:21:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D079540ED7 for ; Wed, 31 May 2023 13:21:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685532112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5DLUxrT5bEgTqjkrX/Bo1umI0wc4iNEKBN5NJNlGXek=; b=QFiPkDMGbYF29HIYv4B1DKDW55PpCawdiRc6O8EgCOCyowyaVsWwttSUcqxHW3UYNWiyvO nHyCsM2GwhfPrH0YLPRcycusfEuffePD3gFMVtl12YyTB7J9YHR2sYAvd1gvOlwsC8rRTR aejugaSWR4U9xPl+zjaQMdUY9G47Dco= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-HfHJo8DZOYij-gkZru6lwQ-1; Wed, 31 May 2023 07:21:51 -0400 X-MC-Unique: HfHJo8DZOYij-gkZru6lwQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-94a34a0b75eso478644766b.1 for ; Wed, 31 May 2023 04:21:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685532110; x=1688124110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=743JKvxPvQVWDNowF9RcFQzWwIltQ8cKp52c59lFWao=; b=WOHY0ERLRRYbFTroHr2M0YfYrALmrFJ9hCnoiOEPS43uAsxxNC1+HW/+/SfJnxGXJF ZXTme3j6cl6BadyMxIvWN/0LCvObWO6retpm9LpBk+fy79PNvhW+fUFPBm+k04rwCeZq WtgKtqd8sCB9IRhU8sBO77mG+EkbPFYC43ZVFNL6+TKNN41lqFzwr/LKzl/JE8wVrAhQ 6f9t0OVgNmpqqbkYTWvxW6dk4NAqFN6us5arovvqDxPgf3XcD1dNDrBddm74YXR0EyfR jDSJKcW/hK4ZijY2Lpfi0CXlyChM/RR4GSjSwU7HDgmKj1er0KySvO8b8dKTE7kCoGdZ a5gw== X-Gm-Message-State: AC+VfDyg0xTyVbyKSYcBW3KXEX6tURheDj9PzCkuvX5a9OOxxV9TF29R DwbwyabqJz3tUCicooROKIAgB9gZcLGqCTfoECa+hcR8CfdPiaxlWenT5Ft9f+LLyhx4DrcG6zB i8eRU+UG4NAE= X-Received: by 2002:a17:907:9412:b0:973:daa0:315 with SMTP id dk18-20020a170907941200b00973daa00315mr4832361ejc.1.1685532110001; Wed, 31 May 2023 04:21:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6l5CnS3quMEHNcs1otOCTswMT8F6whKieKvEpg2yIrMjuKxL51JgudOjnD7oVUWEXjahfr7g== X-Received: by 2002:a17:907:9412:b0:973:daa0:315 with SMTP id dk18-20020a170907941200b00973daa00315mr4832346ejc.1.1685532109702; Wed, 31 May 2023 04:21:49 -0700 (PDT) Received: from [10.39.192.204] (5920ab7b.static.cust.trined.nl. [89.32.171.123]) by smtp.gmail.com with ESMTPSA id f13-20020a170906560d00b009603d34cfecsm8800478ejq.164.2023.05.31.04.21.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2023 04:21:48 -0700 (PDT) From: Eelco Chaudron To: Maxime Coquelin Cc: "Xia, Chenbo" , Thomas Monjalon , david.marchand@redhat.com, dev@dpdk.org Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick Date: Wed, 31 May 2023 13:21:45 +0200 X-Mailer: MailMate (1.14r5964) Message-ID: In-Reply-To: <11c40eca-5847-dfb4-470d-7da86fe7e51e@redhat.com> References: <168431450017.558450.16680518469610688737.stgit@ebuild.local> <168431455219.558450.14986601389394385835.stgit@ebuild.local> <49ec9930-66b8-fc95-72ad-5cb012ed8635@redhat.com> <16690234.Ash8RoxBsO@thomas> <7f1be920-0318-ae7f-4c2e-cc08b2083f7c@redhat.com> <11c40eca-5847-dfb4-470d-7da86fe7e51e@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 31 May 2023, at 11:29, Maxime Coquelin wrote: > On 5/31/23 08:19, Xia, Chenbo wrote: >>> -----Original Message----- >>> From: Maxime Coquelin >>> Sent: Tuesday, May 30, 2023 11:17 PM >>> To: Thomas Monjalon ; Eelco Chaudron >>> ; Xia, Chenbo ; >>> david.marchand@redhat.com >>> Cc: dev@dpdk.org >>> Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interru= pt >>> kick >>> >>> >>> >>> On 5/30/23 15:16, Thomas Monjalon wrote: >>>> 30/05/2023 15:02, Maxime Coquelin: >>>>> >>>>> On 5/17/23 11:09, Eelco Chaudron wrote: >>>>>> This patch adds an operation callback which gets called every time t= he >>>>>> library wants to call eventfd_write(). This eventfd_write() call cou= ld >>>>>> result in a system call, which could potentially block the PMD threa= d. >>>>>> >>>>>> The callback function can decide whether it's ok to handle the >>>>>> eventfd_write() now or have the newly introduced function, >>>>>> rte_vhost_notify_guest(), called at a later time. >>>>>> >>>>>> This can be used by 3rd party applications, like OVS, to avoid syste= m >>>>>> calls being called as part of the PMD threads. >>>>>> >>>>>> Signed-off-by: Eelco Chaudron >>>>>> --- >>>>>> lib/vhost/meson.build | 2 ++ >>>>>> lib/vhost/rte_vhost.h | 23 +++++++++++++++++- >>>>>> lib/vhost/socket.c | 63 >>> ++++++++++++++++++++++++++++++++++++++++++++++--- >>>>>> lib/vhost/version.map | 9 +++++++ >>>>>> lib/vhost/vhost.c | 38 ++++++++++++++++++++++++++++++ >>>>>> lib/vhost/vhost.h | 58 ++++++++++++++++++++++++++++++++---= --- >>> ------- >>>>>> 6 files changed, 171 insertions(+), 22 deletions(-) >>>>>> >>>>> >>>>> >>>>> The patch looks good to me, but that's the first time we use function >>>>> versioning in Vhost library, so I'd like another pair of eyes to be >>> sure >>>>> I don't miss anything. >>>>> >>>>> Reviewed-by: Maxime Coquelin >>>>> >>>>> Thomas, do we need to mention it somewhere in the release note? >>>> >>>> If compatibility is kept, I think we don't need to mention it. >>>> >>>> >>> >>> Thanks Thomas for the information. >>> >>> Maxime >> >> About release note, except the versioning, there is also one new API int= roduced >> in this patch, so we still need to mention this in release note > > Right, good catch. > Eelco, let me know what you would put, I'll add it while applying (No > need for a new revision). Thanks guys! What about the following release note addition: * **Added callback API support for interrupt handling in the vhost library.= ** A new callback, guest_notify, is introduced that can be used to handle the = interrupt kick outside of the datapath fast path. In addition, a new API, = rte_vhost_notify_guest(), is added to raise the interrupt outside of the pa= st path. Please change if you see fit. Thanks, Eelco > Thanks, > Maxime > >> Thanks, >> Chenbo