From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FE58A04E6; Wed, 9 Dec 2020 17:25:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC922C8F8; Wed, 9 Dec 2020 17:25:03 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by dpdk.org (Postfix) with ESMTP id C35F098 for ; Wed, 9 Dec 2020 17:25:00 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id g20so358337plo.2 for ; Wed, 09 Dec 2020 08:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=DsI5e7fM7Fm/XVwEJzPjhP/9pVmTUMPrDfxSeltwXe8=; b=W8MgowYJZ3VJL7gjxE0JJSpJm3ANkC3n/I0iElNBexwzKZQmKp6b3j726LG2lyqO14 odVbgJ4zWDHtOqI1aKGiXoN9EbB+jkQne/88AcQenAyrbwFbo9WzpE/Detmvf7ns4TjQ /2Kgql4CFwX62KxVRGP/RD2AbCfCuQxSEZc5P4kcFKIpGHkwSJn/ti3nvxjK6RKAw5gl +Sz0mX+bI9P2sMMPsCdaj/APYbpye4bSrN6a4x13GgTHmT2kdP/IhDkruHq7j+fMIxCW dGV7uT4t0QqpfJrXtAAg3udo5JGGIQJhKETMBlFbokTBh2SgywKPagCBfzNA5pwHSqLu 0/lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=DsI5e7fM7Fm/XVwEJzPjhP/9pVmTUMPrDfxSeltwXe8=; b=lBTBDPv4aLeceeQ3+DeTU+2qoOLIgO//+yCjH2ExMu+EypsOUWMAv3P1WIBvSRv1vk KcoDw8QauICTj44inmFYIX+ZUsKWEdJ9MaEXR6x0q1MocAAEHlyBcE68caD2ron8Q+MM 7H5DP28AoaaVVjhVSsvSwxu3sQlKbCdlU9OzQIlfZmr/JH3tezGAWM+W7sZ8oRg8p7z4 5ykDrFY0geqggtIW3STrqn7xqHJs0+BzeyF+5JAyWkaImziHYgFd33HMSyUwRQ+NZpRW AP5gMexW2DNq0oZ8e1bfrewKLMtLWvJtoWNSvVeEiP5ULVGdC/OVTm/3PJ95z70v7DC3 ry9Q== X-Gm-Message-State: AOAM533HG2UjKmrdou6xfqi8R+dyQdwsjzmrHkQSVjDEdz/QCI1FD0vz yDfy5E+0Wni/v7/+HgjsKXtVL9KXxz2IPapD X-Google-Smtp-Source: ABdhPJyfrx+LphHbwCegoPmujHrGCVpHsDTvtomy1/WVhqXusG0bYoPcn0Ryq7adOQXdx2o0ynhMQQ== X-Received: by 2002:a17:90a:d18c:: with SMTP id fu12mr3013149pjb.50.1607531099108; Wed, 09 Dec 2020 08:24:59 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:38f6:904:9f94:4f03? ([2600:1700:6b0:fde0:38f6:904:9f94:4f03]) by smtp.gmail.com with ESMTPSA id a12sm2634633pjm.44.2020.12.09.08.24.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2020 08:24:58 -0800 (PST) From: Andrew Boyer Message-Id: Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Date: Wed, 9 Dec 2020 11:24:56 -0500 In-Reply-To: <50603b0a-07a7-b413-b4c5-1fd535befd3f@intel.com> Cc: dev@dpdk.org, Alfredo Cardigliano , Thomas Monjalon , David Marchand To: Ferruh Yigit References: <20201203203418.15064-1-aboyer@pensando.io> <20201204201646.51746-4-aboyer@pensando.io> <8c32bc91-6583-cd3d-a1e6-979bda122eb3@intel.com> <50603b0a-07a7-b413-b4c5-1fd535befd3f@intel.com> X-Mailer: Apple Mail (2.3608.120.23.2.4) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 3/9] net/ionic: update documentation and MAINTAINERS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Dec 9, 2020, at 10:24 AM, Ferruh Yigit = wrote: >=20 > On 12/9/2020 2:36 PM, Andrew Boyer wrote: >> Please respond to my questions this time. I have ~70 more patches to = post by December 20. >>> On Dec 9, 2020, at 7:03 AM, Ferruh Yigit > wrote: >>>=20 >>> On 12/4/2020 8:16 PM, Andrew Boyer wrote: >>>> The UNMAINTAINED flag will be removed in a future patch. >>>> Signed-off-by: Andrew Boyer > >>>> --- >>>> MAINTAINERS | 3 ++- >>>> doc/guides/nics/features/ionic.ini | 2 ++ >>>> doc/guides/nics/ionic.rst | 13 +++++++------ >>>> 3 files changed, 11 insertions(+), 7 deletions(-) >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index eafe9f8c4..6534983c1 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -841,7 +841,8 @@ F: drivers/net/pfe/ >>>> F: doc/guides/nics/features/pfe.ini >>>> Pensando ionic - UNMAINTAINED >>>> -M: Alfredo Cardigliano > >>>> +M: Andrew Boyer > >>>> +M: Pensando Drivers > >>>=20 >>> Same comment from previous version, please don't add group as = maintainer, only actual people. >> I responded to your original comment about this back in November. Is = there an official DPDK policy against doing this? Is it your preference? = We would very much prefer to have this in the file as a fallback. As = long as there is still at least one person listed, what is the harm? >=20 > There is no official policy against it as far as I know. >=20 > The problem with the groups is we don't know who is behind it, it = blurs who is the owner/responsible of the component. Actual people makes = it clear that who is responsible. >=20 > Why do you prefer to add a group as maintainer? Because if I am on leave for some reason, one of the other handful of = maintainers might be able to help someone with a problem or a question. If I am listed specifically, doesn=E2=80=99t that make clear =E2=80=9Cwho = is the owner/responsible=E2=80=9D for ionic PMD? What harm does having = drivers@ listed do? >>>> F: drivers/net/ionic/ >>>> F: doc/guides/nics/ionic.rst >>>> F: doc/guides/nics/features/ionic.ini >>>> diff --git a/doc/guides/nics/features/ionic.ini = b/doc/guides/nics/features/ionic.ini >>>> index 083c7bd99..dd29dbed6 100644 >>>> --- a/doc/guides/nics/features/ionic.ini >>>> +++ b/doc/guides/nics/features/ionic.ini >>>> @@ -8,6 +8,7 @@ Speed capabilities =3D Y >>>> Link status =3D Y >>>> Link status event =3D Y >>>> Queue start/stop =3D Y >>>> +Lock-free Tx queue =3D Y >>>=20 >>> Are you sure this is supported? >>> Since it is not advertised as capability, I think this can't be = claimed as supported, but still even after this is added as capability, = can you please confirm your device supports multiple core enqueue to = same queue without locks? >> I misunderstood the meaning of this flag, will remove. >>>> MTU update =3D Y >>>> Jumbo frame =3D Y >>>> Scattered Rx =3D Y >>>> @@ -19,6 +20,7 @@ Unicast MAC filter =3D Y >>>> RSS hash =3D Y >>>> RSS key update =3D Y >>>> RSS reta update =3D Y >>>> +SR-IOV =3D Y >>>=20 >>> Can you please explain what is exactly supported? Like can DPDK = drive both PF & VF? >> Yes. The PMD does not distinguish between PFs and VFs. >>>=20 >>> <...> >>>=20 >>>> @@ -7,15 +7,16 @@ IONIC Driver >>>> The ionic driver provides support for Pensando server adapters. >>>> It currently supports the below models: >>>> -- `Naples DSC-25 = >= `_ >>>> -- `Naples DSC-100 = = >`_ >>>> +- DSC-25 dual-port 25G Distributed Services Card >>>> +- DSC-100 dual-port 100G Distributed Services Card >>>>=20 >>>=20 >>> Same comment from previous version, can you provide link for these = devices, it is hard to find the devices from the main site. >> And my same response from your previous comment. I do not control the = website and do not wish to put stale PDF links in this document, which = will live forever. The text includes the URL of the page containing = links to the PDFs. Why is this not acceptable? >=20 > The request is to put links to the products that you are providing the = driver for. This is to help people that are already interested your = driver and reading your driver document, to reach to the product = information easily. >=20 > The request is NOT to provide pdf etc, just a reference to the = product. Don't you advertise your product in your official web site? If = your product information is not visible/hidden, why you are providing = the open source drivers for it? Does this line in the doc not satisfy your request? +The `Documents >`_ page contains Product Briefs and = other product information. -Andrew