From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 16C79AF7F for ; Mon, 14 Apr 2014 16:39:20 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 14 Apr 2014 07:39:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,857,1389772800"; d="scan'208";a="520180038" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 14 Apr 2014 07:39:19 -0700 Received: from irsmsx154.ger.corp.intel.com (163.33.192.96) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 14 Apr 2014 15:39:15 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.224]) by IRSMSX154.ger.corp.intel.com ([163.33.192.96]) with mapi id 14.03.0123.003; Mon, 14 Apr 2014 15:39:15 +0100 From: "Burakov, Anatoly" To: David Marchand Thread-Topic: [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code Thread-Index: AQHPV+BhM3vrbSriC0ydfuq/aandUZsREsuwgAAFyQCAABFfkA== Date: Mon, 14 Apr 2014 14:39:15 +0000 Message-ID: References: <1397479912-4906-1-git-send-email-david.marchand@6wind.com> <534BEE72.4070205@6wind.com> In-Reply-To: <534BEE72.4070205@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Apr 2014 14:39:21 -0000 Hi David, > This functionality is at least used by virtio-net-pmd. > So we cannot remove this without a fix for virtio-net-pmd. It appears that virtio-net-pmd hasn't been merged in yet? At least I can't = see it in the git tree for 1.6 release. > Yet, even if we remove this from the eal, I think we should provide a pro= per > api to bind/unbind devices to kernel drivers. > This way PMDs can use this api and forget about OS dependencies > (linux/bsd). Please forgive me for repeating myself, but I'm still not convinced that bi= nding/unbinding the kernel drivers has to be the responsibility of the appl= ication in the first place. As far as I know, the reasons why the binding/u= nbinding code was there are purely historical and have no rationale behind = them other than "this is how it was first implemented". Plus, correct me if= I'm wrong, but FreeBSD has some issues with port binding/unbinding - i.e. = it can't do that at all, at least during runtime, so on BSD it's even less = of an issue. Anyway, the reason I'm bringing this subject up in the first place is I'm p= reparing a patch to support VFIO driver alongside igb_uio. Among the change= s I'm preparing to make is getting rid of the device ID list in igb_uio, so= that any driver could be bound to it (via writing to new_id) - i.e. making= it similar to how pci_stub, vfio-pci et al work. A consequence of that wi= ll be that igb_uio won't try to bind any devices unless the user explicitly= asks for it, meaning that the virtio device will not be bound to igb_uio b= y default. I think this will remedy the issues with virtio-net-pmd without = the need for force-unbind logic in the EAL. Best regards, Anatoly Burakov DPDK SW Engineer -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare =20