From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id A5503B0B8
 for <dev@dpdk.org>; Tue,  6 May 2014 14:53:12 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga102.jf.intel.com with ESMTP; 06 May 2014 05:48:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,997,1389772800"; d="scan'208";a="526823409"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by fmsmga001.fm.intel.com with ESMTP; 06 May 2014 05:53:14 -0700
Received: from irsmsx108.ger.corp.intel.com (163.33.3.3) by
 IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Tue, 6 May 2014 13:52:57 +0100
Received: from irsmsx101.ger.corp.intel.com ([169.254.1.249]) by
 IRSMSX108.ger.corp.intel.com ([169.254.11.221]) with mapi id 14.03.0123.003;
 Tue, 6 May 2014 13:52:56 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH 5/5] add FILE arguement to debug functions
Thread-Index: AQHPZmCJHmZMHVTVDUCGM3GntqL4S5szhrMQ
Date: Tue, 6 May 2014 12:52:56 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E45123697592AB70B@IRSMSX101.ger.corp.intel.com>
References: <20140502234251.707598579@vyatta.com>
 <20140502234407.841791092@vyatta.com>
In-Reply-To: <20140502234407.841791092@vyatta.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 5/5] add FILE arguement to debug functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 06 May 2014 12:53:13 -0000

Hi Stephen,

> The DPDK dump functions are useful for remote debugging of an
> applications. But when application runs as a daemon, stdout
> is typically routed to /dev/null.
>=20
> Instead change all these functions to take a stdio FILE * handle
> instead. An application can then use open_memstream() to capture
> the output.
>=20

Wouldn't it be better to leave old calls as wrappers with the FILE paramete=
r defaulting to stdout? That way you wouldn't have to change so much code, =
keep backwards compatibility with old code, and get the additional function=
ality you need.

Best regards,
Anatoly Burakov
DPDK SW Engineer