From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 5ABAC6882
 for <dev@dpdk.org>; Thu, 22 May 2014 14:38:18 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga101.fm.intel.com with ESMTP; 22 May 2014 05:38:27 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.98,887,1392192000"; d="scan'208";a="536005264"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by fmsmga001.fm.intel.com with ESMTP; 22 May 2014 05:37:51 -0700
Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by
 IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Thu, 22 May 2014 13:37:50 +0100
Received: from irsmsx101.ger.corp.intel.com ([169.254.1.249]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.28]) with mapi id 14.03.0123.003;
 Thu, 22 May 2014 13:37:50 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v2 08/16] Add support for mapping devices
 through VFIO.
Thread-Index: AQHPc3pXCHomzD8lD0mKR5G/Z8BpJ5tMcREAgAARV0D///imgIAAESvg
Date: Thu, 22 May 2014 12:37:50 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E451236976CC8519E@IRSMSX101.ger.corp.intel.com>
References: <C6ECDF3AB251BE4894318F4E45123697592AA9BE@IRSMSX101.ger.corp.intel.com>
 <6426409.afQ7rpamsg@xps13>
 <C6ECDF3AB251BE4894318F4E451236976CC85175@IRSMSX101.ger.corp.intel.com>
 <1871082.JnAAVjVYKa@xps13>
In-Reply-To: <1871082.JnAAVjVYKa@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 08/16] Add support for mapping devices
 through VFIO.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 22 May 2014 12:38:18 -0000

Hi Thomas,

> Yes, in some environments, it could be easier to be able to configure dev=
ices
> directly on application command line instead of having to call a python s=
cript.
> I think having a clear and extendable syntax to configure devices in comm=
and
> line could greatly improve usability. But it can be another step.

That's probably out of scope for this patch. We can discuss this later with=
out stalling VFIO :)

> What do you think of _mp_sync or _mp_conf?
> Usage of the socket is to synchronize VFIO config between processes, righ=
t?

More or less, yes. However, the code inside that file is the communication =
mechanism. I.e. it's not actually synchronizing or configuring anything, it=
's simply providing means to do so for primary and secondary processes, so =
I don't think _mp_sync or _mp_conf is a good name for that. IMO something l=
ike _mp_socket or similar (_mp_comm?) would be more appropriate.=20

> Oh yes. Do you think you could merge the thread spawning in the patch
> adding it?

Good point, I'll do that.

> So you should use an "extern" trick in order to have only one instance of=
 the
> variables. But I think it's not a good practice.
> You probably need to group functions using these variables in one .c file=
.
> Or do I miss something?

I'll look into this.

Best regards,
Anatoly Burakov
DPDK SW Engineer