From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 84FF6AFCD
 for <dev@dpdk.org>; Tue, 27 May 2014 18:21:35 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 27 May 2014 09:21:45 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.98,920,1392192000"; d="scan'208";a="545596210"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga002.fm.intel.com with ESMTP; 27 May 2014 09:21:07 -0700
Received: from irsmsx108.ger.corp.intel.com (163.33.3.3) by
 IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Tue, 27 May 2014 17:21:06 +0100
Received: from irsmsx101.ger.corp.intel.com ([169.254.1.245]) by
 IRSMSX108.ger.corp.intel.com ([169.254.11.179]) with mapi id 14.03.0123.003;
 Tue, 27 May 2014 17:21:06 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v2 08/16] Add support for mapping devices
 through VFIO.
Thread-Index: AQHPc3pXCHomzD8lD0mKR5G/Z8BpJ5tMcREAgAg2EVA=
Date: Tue, 27 May 2014 16:21:06 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E451236976CC9351C@IRSMSX101.ger.corp.intel.com>
References: <C6ECDF3AB251BE4894318F4E45123697592AA9BE@IRSMSX101.ger.corp.intel.com>
 <1400514709-24087-9-git-send-email-anatoly.burakov@intel.com>
 <6426409.afQ7rpamsg@xps13>
In-Reply-To: <6426409.afQ7rpamsg@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 08/16] Add support for mapping devices
 through VFIO.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 May 2014 16:21:36 -0000

Hi Thomas,

> You are defining some variables in a .h file. I think it is a problem.

I have managed to move everything to .c files, except for "struct mapped_pc=
i_res_list *pci_res_list;" - which I need in both uio and vfio .c files. I =
don't think I'll be able to move it out of the eal_pci_init header file. Sh=
ould declaring it as extern be fine as a compromise?

Best regards,
Anatoly Burakov
DPDK SW Engineer