From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 7B282AFD6
 for <dev@dpdk.org>; Wed, 28 May 2014 12:35:22 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 28 May 2014 03:30:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.98,927,1392192000"; d="scan'208";a="518960178"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by orsmga001.jf.intel.com with ESMTP; 28 May 2014 03:35:32 -0700
Received: from irsmsx101.ger.corp.intel.com ([169.254.1.245]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.58]) with mapi id 14.03.0123.003;
 Wed, 28 May 2014 11:35:31 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v2 10/16] Added support for selecting VFIO
 interrupt type from EAL command-line
Thread-Index: AQHPc3pWSBnVPJpZekO5ZwszQ5vuf5tMfKWAgAlcpfA=
Date: Wed, 28 May 2014 10:35:30 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E451236976CC958D3@IRSMSX101.ger.corp.intel.com>
References: <C6ECDF3AB251BE4894318F4E45123697592AA9BE@IRSMSX101.ger.corp.intel.com>
 <1400514709-24087-11-git-send-email-anatoly.burakov@intel.com>
 <1589072.KAuytnYNqt@xps13>
In-Reply-To: <1589072.KAuytnYNqt@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 10/16] Added support for selecting VFIO
 interrupt type from EAL command-line
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 28 May 2014 10:35:22 -0000

Hi Thomas,

> > +			}
> >  			else if (!strcmp(lgopts[option_index].name,
> OPT_CREATE_UIO_DEV))
>=20
> another code style issue reported by checkpatch.pl ;)
>=20
> But it should be fixed by removing this code as Stephen suggests.

I'm not sure this could should be removed. Igb_uio allows to pick interrupt=
 mode, so why not VFIO? I've modified my code to try all interrupt modes if=
 nothing was explicitly specified, but why should that preclude the user fr=
om selecting a specific interrupt type if he so desires?

As for the style error - the whole chunk of code uses the same style there,=
 so either we fix all of that (in a separate patch?), or leave it as it is.

Best regards,
Anatoly Burakov
DPDK SW Engineer