From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
 by dpdk.org (Postfix) with ESMTP id D0AEEAFD1
 for <dev@dpdk.org>; Thu, 19 Jun 2014 17:51:42 +0200 (CEST)
Received: from azsmga001.ch.intel.com ([10.2.17.19])
 by azsmga101.ch.intel.com with ESMTP; 19 Jun 2014 08:51:58 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,507,1400050800"; d="scan'208";a="447570632"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by azsmga001.ch.intel.com with ESMTP; 19 Jun 2014 08:51:57 -0700
Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by
 IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Thu, 19 Jun 2014 16:51:57 +0100
Received: from irsmsx101.ger.corp.intel.com ([169.254.1.245]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.14]) with mapi id 14.03.0123.003;
 Thu, 19 Jun 2014 16:51:56 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] eal: Fixed EAL option --base-virtaddr
Thread-Index: AQHPi9ROsM0c9R6A90WiT7YI+shkrZt4lQ8Q
Date: Thu, 19 Jun 2014 15:51:56 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E451236976CC9D75C@IRSMSX101.ger.corp.intel.com>
References: <1403192122-25496-1-git-send-email-pablox.de.lara.guarch@intel.com>
In-Reply-To: <1403192122-25496-1-git-send-email-pablox.de.lara.guarch@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] eal: Fixed EAL option --base-virtaddr
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jun 2014 15:51:43 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, June 19, 2014 4:35 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] eal: Fixed EAL option --base-virtaddr
>=20
> From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>=20
> When parsing EAL option --base-virtaddr
> errno was not being set to 0 before calling strtoull, therefore function =
might
> fail unnecesarily.
>=20
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  lib/librte_eal/linuxapp/eal/eal.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>=20
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/=
eal/eal.c
> index 6994303..d204387 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -562,6 +562,7 @@ eal_parse_base_virtaddr(const char *arg)
>  	char *end;
>  	uint64_t addr;
>=20
> +	errno =3D 0;
>  	addr =3D strtoull(arg, &end, 16);
>=20
>  	/* check for errors */
> --
> 1.7.0.7

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Best regards,
Anatoly Burakov
DPDK SW Engineer