From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 25EE9C336
 for <dev@dpdk.org>; Thu, 18 Feb 2016 11:19:02 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga101.jf.intel.com with ESMTP; 18 Feb 2016 02:19:01 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,464,1449561600"; d="scan'208";a="915655678"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by orsmga002.jf.intel.com with ESMTP; 18 Feb 2016 02:19:00 -0800
Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by
 IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 18 Feb 2016 10:18:57 +0000
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.100]) by
 IRSMSX156.ger.corp.intel.com ([10.108.20.68]) with mapi id 14.03.0248.002;
 Thu, 18 Feb 2016 10:18:57 +0000
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Gonzalez Monroy, Sergio"
 <sergio.gonzalez.monroy@intel.com>, "david.marchand@6wind.com"
 <david.marchand@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] eal:Change log output to DEBUG instead of INFO
Thread-Index: AQHRZb73AjpGJ5JWkUC7VuEzVHqem58xnCQA
Date: Thu, 18 Feb 2016 10:18:56 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E45123697820C85AF@IRSMSX109.ger.corp.intel.com>
References: <1441914050-43168-1-git-send-email-keith.wiles@intel.com>
 <1928276.P2Lqin6BEp@xps13>
In-Reply-To: <1928276.P2Lqin6BEp@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal:Change log output to DEBUG instead of
 INFO
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Feb 2016 10:19:02 -0000

Hi

Apologies for late reply, was away. Can't comment on other lines, but

> > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > index 0e6c48a..e0c13de 100644
> > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > @@ -904,7 +904,7 @@ pci_vfio_enable(void)
> >
> >  	/* return 0 if VFIO modules not loaded */
> >  	if (module_vfio_type1 =3D=3D 0) {
> > -		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
> > +		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
> >  			"skip VFIO support...\n");
> >  		return 0;
> >  	}
> >
>=20

Should people be forced to recompile DPDK with debug logs (and get all this
additional debug output) just to see why VFIO doesn't get initialized? I wo=
uld
argue this message is not as serious an annoyance to warrant this change, b=
ut
maybe Keith has a different opinion.

Either way, I don't feel strongly for or against the change.

Thanks,
Anatoly