From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 848C99AD5
 for <dev@dpdk.org>; Tue, 10 May 2016 13:53:25 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP; 10 May 2016 04:53:24 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,604,1455004800"; d="scan'208";a="802975419"
Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99])
 by orsmga003.jf.intel.com with ESMTP; 10 May 2016 04:53:23 -0700
Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by
 IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 10 May 2016 12:53:22 +0100
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.120]) by
 IRSMSX156.ger.corp.intel.com ([169.254.3.174]) with mapi id 14.03.0248.002;
 Tue, 10 May 2016 12:53:22 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Jan Viktorin <viktorin@rehivetech.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: David Marchand <david.marchand@6wind.com>, "Wiles, Keith"
 <keith.wiles@intel.com>, Santosh Shukla <sshukla@mvista.com>, "Stephen
 Hemminger" <stephen@networkplumber.org>
Thread-Topic: [PATCH 10/15] vfio: extract setup logic out of
 pci_vfio_map_resource
Thread-Index: AQHRoh2Y6XGyfluMNk+F26xgVf3gip+yIH/g
Date: Tue, 10 May 2016 11:53:21 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E451236978210B7EA@IRSMSX109.ger.corp.intel.com>
References: <1461937456-22943-1-git-send-email-viktorin@rehivetech.com>
 <1461937456-22943-11-git-send-email-viktorin@rehivetech.com>
In-Reply-To: <1461937456-22943-11-git-send-email-viktorin@rehivetech.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmExNzU0MjUtMjYxMS00NGI3LWIwZTAtYWViYTkzODFmZjAyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImQ0N1BtZzU0SWd1Z2FIdncwd3RiRStlVWs3Y0FEaUV5bnpkY0oyVENKRWM9In0=
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 10/15] vfio: extract setup logic out of
 pci_vfio_map_resource
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 May 2016 11:53:25 -0000

Hi Jan,


>  	/*
> -	 * at this point, we know at least one port on this device is bound to
> VFIO,
> -	 * so we can proceed to try and set this particular port up
> -	 */
> -
> -	/* check if the group is viable */
> -	ret =3D ioctl(vfio_group_fd, VFIO_GROUP_GET_STATUS,
> &group_status);
> -	if (ret) {
> -		RTE_LOG(ERR, EAL, "  %s cannot get group status, "
> -				"error %i (%s)\n", pci_addr, errno,
> strerror(errno));
> -		close(vfio_group_fd);
> -		clear_current_group();
> -		return -1;
> -	} else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) {
> -		RTE_LOG(ERR, EAL, "  %s VFIO group is not viable!\n",
> pci_addr);
> -		close(vfio_group_fd);
> -		clear_current_group();
> -		return -1;
> -	}
> -

I think you've lost this bit when moving things around. I can't find any vi=
ability checks in eal_vfio.c

Thanks,
Anatoly