From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 765C19AD6
 for <dev@dpdk.org>; Tue, 10 May 2016 13:56:40 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 10 May 2016 04:56:39 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,604,1455004800"; d="scan'208";a="976446469"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by fmsmga002.fm.intel.com with ESMTP; 10 May 2016 04:56:39 -0700
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.120]) by
 IRSMSX151.ger.corp.intel.com ([169.254.4.7]) with mapi id 14.03.0248.002;
 Tue, 10 May 2016 12:56:37 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Jan Viktorin <viktorin@rehivetech.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: David Marchand <david.marchand@6wind.com>, "Wiles, Keith"
 <keith.wiles@intel.com>, Santosh Shukla <sshukla@mvista.com>, "Stephen
 Hemminger" <stephen@networkplumber.org>
Thread-Topic: [PATCH 11/15] vfio: move global vfio_cfg to eal_vfio.c
Thread-Index: AQHRoh2ZyIpVbvzHEkuObhBlm2yAbp+yIQHg
Date: Tue, 10 May 2016 11:56:36 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E451236978210B7FA@IRSMSX109.ger.corp.intel.com>
References: <1461937456-22943-1-git-send-email-viktorin@rehivetech.com>
 <1461937456-22943-12-git-send-email-viktorin@rehivetech.com>
In-Reply-To: <1461937456-22943-12-git-send-email-viktorin@rehivetech.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjhhZWUyZjctYjEzMC00YWY0LTk4MTItZGI5MWYzNzVmZjJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlNLOGlTeVN4eDFFV29Rbk9veXpRdFBUS1ZFZlRjbVF4aE56eDRQc0lHZGs9In0=
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 11/15] vfio: move global vfio_cfg to
	eal_vfio.c
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 May 2016 11:56:40 -0000

Hi Jan,

> --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c
> @@ -39,10 +39,282 @@
>  #include <rte_log.h>
>  #include <rte_memory.h>
>  #include <rte_eal_memconfig.h>
> +#include <eal_private.h>
>=20
>  #include "eal_filesystem.h"
>  #include "eal_vfio.h"

I believe the eal_private.h should be local include (in quotes), like in ot=
her places.

> +/**
> + * Setup vfio_cfg for the device indentified by its address. It
> +discovers
> + * the configured I/O MMU groups or sets a new one for the device. If a
> +new
> + * groups is assigned, the DMA mapping is performed.
> + * Returns 0 on success, a negative value on failure and a positive
> +value in
> + * case the given device cannot be managed this way.
> + */

I think it would've been good to fix the typo in the comment ("indentified"=
) :)

Thanks,
Anatoly