From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id B76CD3977
 for <dev@dpdk.org>; Thu, 14 Jul 2016 16:50:55 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 14 Jul 2016 07:50:54 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,363,1464678000"; d="scan'208";a="995251309"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by orsmga001.jf.intel.com with ESMTP; 14 Jul 2016 07:50:53 -0700
Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by
 IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 14 Jul 2016 15:50:52 +0100
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.193]) by
 irsmsx111.ger.corp.intel.com ([169.254.2.182]) with mapi id 14.03.0248.002;
 Thu, 14 Jul 2016 15:50:52 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: Yong Wang <yongwang@vmware.com>, Ronghua Zhang <rzhang@vmware.com>,
 "dan@kernelim.com" <dan@kernelim.com>
Thread-Topic: [dpdk-dev] [PATCH 1/2] vfio: fix pci_vfio_map_resource
Thread-Index: AQHR2KDxDOCHhdBqm0Ou9PyCTTA9dqAX5GSAgAAjAUA=
Date: Thu, 14 Jul 2016 14:50:51 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E45123697821322ED@IRSMSX109.ger.corp.intel.com>
References: <1467930397-39777-1-git-send-email-yongwang@vmware.com>
 <3677701.6a7nRcOOV2@xps13>
In-Reply-To: <3677701.6a7nRcOOV2@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjVkY2ZkZTctMzhiOS00Y2Q1LThkNmEtNzFmOGQyYmQ1Y2Y1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik1CM3gwWlwvRUpJVFVjNWNYQ3VHYnVPdjkzS0ZOdlJnK1dzUElwRCtabGZrPSJ9
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/2] vfio: fix pci_vfio_map_resource
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2016 14:50:56 -0000

> Someone to review this patch please?
> It can be integrated in RC3 if we are sure it doesn't break anything.
>=20
> 2016-07-07 15:26, Yong Wang:
> > The offset of the 2nd mmap when mapping the region after msix_bar
> > needs to take region address into consideration.  This is exposed when
> > using vfio-pci to manage vmxnet3 pmd.
> >
> > Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables")
> >
> > Signed-off-by: Yong Wang <yongwang@vmware.com>
> > Signed-off-by: Ronghua Zhang <rzhang@vmware.com>

Hi Thomas,

The patch makes sense to me, but I don't have any devices that trigger that=
 particular codepath in my immediate vicinity. The original patch was menti=
oning an NVMe adapter, so that probably should be tested with this change. =
I'm CC'ing the original author of that patch just in case. Do we know of an=
y other NICs/devices that might be affected by this? Aside from the obvious=
 example of vmxnet3...=20

Thanks,
Anatoly