DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: Re: [dpdk-dev] vfio: failed to select IOMMU type
Date: Tue, 4 Apr 2017 16:20:09 +0000	[thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E451236978220D823@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <f022afca-f12c-a00a-af09-99cda11320e7@solarflare.com>

Hi Andrew,

> Please, take a look at http://dpdk.org/dev/patchwork/patch/23202/

I took a quick look. It should fix the problem (closing the group will cause container detachment, so we can always assume that if there's no container associated with the group, there are no devices within that group). The issue of vfio_release_device() still remains. I think the fix for that would closely follow what you did here: close the dev_fd, check if the group still has a container associated with it, and if not, close the group_fd and clear the group.

I cannot thoroughly test it right this moment, however I'll have time later during the week.

Thanks,
Anatoly

  reply	other threads:[~2017-04-04 16:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01 10:46 Andrew Rybchenko
2017-04-03 16:11 ` Burakov, Anatoly
2017-04-04 15:29   ` Andrew Rybchenko
2017-04-04 15:52     ` Burakov, Anatoly
2017-04-04 16:10       ` Andrew Rybchenko
2017-04-04 16:20         ` Burakov, Anatoly [this message]
2017-04-05  7:15           ` Alejandro Lucero
2017-04-05  7:12       ` Alejandro Lucero
2017-04-06  9:10         ` Burakov, Anatoly
2017-04-18 11:22           ` Alejandro Lucero
2017-04-24  9:09             ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C6ECDF3AB251BE4894318F4E451236978220D823@IRSMSX109.ger.corp.intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).