* [dpdk-dev] [PATCH] doc: add mlx5 limitation of RSS hash result
@ 2018-08-14 16:57 Yongseok Koh
2018-08-16 20:46 ` Yongseok Koh
0 siblings, 1 reply; 2+ messages in thread
From: Yongseok Koh @ 2018-08-14 16:57 UTC (permalink / raw)
To: shahafs; +Cc: dev, Yongseok Koh
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
doc/guides/nics/mlx5.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 52e1213cf5..cbcc233d03 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -136,6 +136,12 @@ Limitations
enabled (``rxq_cqe_comp_en``) at the same time, RSS hash result is not fully
supported. Some Rx packets may not have PKT_RX_RSS_HASH.
+- In general, PKT_RX_RSS_HASH shall be set in a received mbuf if RSS is enabled
+ and the packet is subject to hash cacalculation. However, in case of
+ vectorized Rx (``rx_vec_en``), PKT_RX_RSS_HASH will always be set as long as
+ RSS is enabled. Zero hash result (mbuf->hash.rss) means the packet isn't
+ subject to the configured RSS hash type and the flag should be disregarded.
+
Statistics
----------
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add mlx5 limitation of RSS hash result
2018-08-14 16:57 [dpdk-dev] [PATCH] doc: add mlx5 limitation of RSS hash result Yongseok Koh
@ 2018-08-16 20:46 ` Yongseok Koh
0 siblings, 0 replies; 2+ messages in thread
From: Yongseok Koh @ 2018-08-16 20:46 UTC (permalink / raw)
To: dev; +Cc: Shahaf Shuler
> On Aug 14, 2018, at 9:57 AM, Yongseok Koh <yskoh@mellanox.com> wrote:
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> doc/guides/nics/mlx5.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index 52e1213cf5..cbcc233d03 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -136,6 +136,12 @@ Limitations
> enabled (``rxq_cqe_comp_en``) at the same time, RSS hash result is not fully
> supported. Some Rx packets may not have PKT_RX_RSS_HASH.
>
> +- In general, PKT_RX_RSS_HASH shall be set in a received mbuf if RSS is enabled
> + and the packet is subject to hash cacalculation. However, in case of
> + vectorized Rx (``rx_vec_en``), PKT_RX_RSS_HASH will always be set as long as
> + RSS is enabled. Zero hash result (mbuf->hash.rss) means the packet isn't
> + subject to the configured RSS hash type and the flag should be disregarded.
> +
> Statistics
> ----------
I have to take it back.
We concluded there's a bug in the implementation and decided to fix this issue.
Thanks,
Yongseok
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-16 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-14 16:57 [dpdk-dev] [PATCH] doc: add mlx5 limitation of RSS hash result Yongseok Koh
2018-08-16 20:46 ` Yongseok Koh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).