Re: [PATCH] net/gve: Update TX queue state

[Tathagat Priyadarshi <tathagat.dpdk@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1830 bytes --]

Thanks Ferruh.

On Mon, Jul 22, 2024 at 7:41 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 7/22/2024 12:10 PM, Tathagat Priyadarshi wrote:
> > Fixing Typo in updating the TX queue state
> >
> > Signed-off-by: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
> >
>
> Good catch, thanks Tathagat.
>
> I think impact is more than just typo, so let me update the patch title as:
>
> net/gve: fix Tx queue state on queue start
>
> Also needs fixes tag:
>  Fixes: b044845bb015 ("net/gve: support queue start/stop")
>  Cc: stable@dpdk.org
>
> With above changes,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> Applied to dpdk-next-net/main, thanks.
>
> > ---
> >  drivers/net/gve/gve_tx.c     | 2 +-
> >  drivers/net/gve/gve_tx_dqo.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/gve/gve_tx.c b/drivers/net/gve/gve_tx.c
> > index 70d3ef0..500ae31 100644
> > --- a/drivers/net/gve/gve_tx.c
> > +++ b/drivers/net/gve/gve_tx.c
> > @@ -688,7 +688,7 @@
> >
> >       rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr);
> >
> > -     dev->data->rx_queue_state[tx_queue_id] =
> RTE_ETH_QUEUE_STATE_STARTED;
> > +     dev->data->tx_queue_state[tx_queue_id] =
> RTE_ETH_QUEUE_STATE_STARTED;
> >
> >       return 0;
> >  }
> > diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c
> > index a65e6aa..1b85557 100644
> > --- a/drivers/net/gve/gve_tx_dqo.c
> > +++ b/drivers/net/gve/gve_tx_dqo.c
> > @@ -392,7 +392,7 @@
> >
> >       rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr);
> >
> > -     dev->data->rx_queue_state[tx_queue_id] =
> RTE_ETH_QUEUE_STATE_STARTED;
> > +     dev->data->tx_queue_state[tx_queue_id] =
> RTE_ETH_QUEUE_STATE_STARTED;
> >
> >       return 0;
> >  }
>
>

[-- Attachment #2: Type: text/html, Size: 2593 bytes --]