From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8C3445681; Mon, 22 Jul 2024 16:19:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AB96402B1; Mon, 22 Jul 2024 16:19:20 +0200 (CEST) Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by mails.dpdk.org (Postfix) with ESMTP id 010AB402A8 for ; Mon, 22 Jul 2024 16:19:19 +0200 (CEST) Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6b7b28442f9so40888826d6.3 for ; Mon, 22 Jul 2024 07:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721657959; x=1722262759; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cV//dhQJf9KkGo6MZOBIq8DLXQKWlJ5S3t6/53ecrZ0=; b=P29EkkzV9T/Z3Tuxi6SDiX1DWL1mvqte8lmameWz1Jny0dNHZzh3jznKjZ1pMsJBl5 uP987PFN6WNZ52K8UeokosTeZoAyeF91JZRQ8z4rCIWz/GjNu0Qo4Frust5+bdZikimQ xhTfykN/kvg6ee+IiJf5VBqstR0edIpDxQBTAIK+BRAKbTMOrqYUd2vZaGnZtt1BLHdH 1pKEQJBvTnxCabAuOiqokg3WLplXl7kljEuhM6QgMMVkxAcEAtZiEfD+yD47HcowOVOE RMcnn3WVWVvBH6k50g9oOLcIQj7UAMbX8M4ns4gpQUiWHhtWMvwWoUhIICZwxMgU3Fau qa7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721657959; x=1722262759; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cV//dhQJf9KkGo6MZOBIq8DLXQKWlJ5S3t6/53ecrZ0=; b=mNFTMOWRnRdnjQRV3gDh+MD1laMLisktNWqaArtz2bUQMqn/s/3cULmzmTxo5kPHQ/ HsZYglatdC6PyzeBKqY+Qyk7iTR4il7Yk2s8meM2LHCDPrN75shY+FPUuP4MJ7YW4KD+ bn1J0Fko8R1a8CL99ow2kSS7u552rO18SGbBtm2nHOVJihIOGR3jnoDHWON8kBNXDSFa OcOSdyvVNmHi+PAk121tAHjjVeww5FiHpoRZoS4+ymk8YRHdX1KbpGMtxvhGajnLmODB gd18YbfupkM+QClrBi2pTlT9tjpoJ/mluh9Wjc2EkSofHHr7Ded61mFk0Nxq+LnKhSgW 9PHg== X-Forwarded-Encrypted: i=1; AJvYcCWy3fMRRdoDhwK8bFPKylRlkqpQuHLXPm6Rp7+cfhuPRO06mDwfqL8pfuGGqomKrqr7Wfstz9pgvhqnpsA= X-Gm-Message-State: AOJu0YxBLb0yJRwnBjTOZD6pN7ZvSHXT68T16RxN/V6ssPsq32TsK+Fc YoqGdzk1XFWJYj6J/YrcwR7KFSO3dm1zuau6bIRnJ1iJWxrDLily6OBjfrRHIbiCpb61qQmAxOG aazdeVYzN2D+8WOh9nNf6gIQ9ijY= X-Google-Smtp-Source: AGHT+IEH9iNUyEgdd723ubUCT+kkCWmvXlzBotYGFmtmKkDaMXfidt1ithcOucxeHO0u6BBidjwTvgUoS+46lDORVEQ= X-Received: by 2002:a05:6214:1bc5:b0:6b2:cf9e:866 with SMTP id 6a1803df08f44-6b9610403d6mr126581306d6.4.1721657959162; Mon, 22 Jul 2024 07:19:19 -0700 (PDT) MIME-Version: 1.0 References: <1721646611-2391283-1-git-send-email-tathagat.dpdk@gmail.com> In-Reply-To: From: Tathagat Priyadarshi Date: Mon, 22 Jul 2024 19:49:08 +0530 Message-ID: Subject: Re: [PATCH] net/gve: Update TX queue state To: Ferruh Yigit Cc: rushilg@google.com, joshwash@google.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000014aab4061dd6bb12" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000014aab4061dd6bb12 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks Ferruh. On Mon, Jul 22, 2024 at 7:41=E2=80=AFPM Ferruh Yigit = wrote: > On 7/22/2024 12:10 PM, Tathagat Priyadarshi wrote: > > Fixing Typo in updating the TX queue state > > > > Signed-off-by: Tathagat Priyadarshi > > > > Good catch, thanks Tathagat. > > I think impact is more than just typo, so let me update the patch title a= s: > > net/gve: fix Tx queue state on queue start > > Also needs fixes tag: > Fixes: b044845bb015 ("net/gve: support queue start/stop") > Cc: stable@dpdk.org > > With above changes, > Reviewed-by: Ferruh Yigit > > Applied to dpdk-next-net/main, thanks. > > > --- > > drivers/net/gve/gve_tx.c | 2 +- > > drivers/net/gve/gve_tx_dqo.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/gve/gve_tx.c b/drivers/net/gve/gve_tx.c > > index 70d3ef0..500ae31 100644 > > --- a/drivers/net/gve/gve_tx.c > > +++ b/drivers/net/gve/gve_tx.c > > @@ -688,7 +688,7 @@ > > > > rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr); > > > > - dev->data->rx_queue_state[tx_queue_id] =3D > RTE_ETH_QUEUE_STATE_STARTED; > > + dev->data->tx_queue_state[tx_queue_id] =3D > RTE_ETH_QUEUE_STATE_STARTED; > > > > return 0; > > } > > diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.= c > > index a65e6aa..1b85557 100644 > > --- a/drivers/net/gve/gve_tx_dqo.c > > +++ b/drivers/net/gve/gve_tx_dqo.c > > @@ -392,7 +392,7 @@ > > > > rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr); > > > > - dev->data->rx_queue_state[tx_queue_id] =3D > RTE_ETH_QUEUE_STATE_STARTED; > > + dev->data->tx_queue_state[tx_queue_id] =3D > RTE_ETH_QUEUE_STATE_STARTED; > > > > return 0; > > } > > --00000000000014aab4061dd6bb12 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks=C2=A0Ferruh.

On Mon, Jul 22, 2024 at 7:41=E2=80=AFPM= Ferruh Yigit <ferruh.yigit@amd.= com> wrote:
On 7/22/2024 12:10 PM, Tathagat Priyadarshi wrote:
> Fixing Typo in updating the TX queue state
>
> Signed-off-by: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
>

Good catch, thanks Tathagat.

I think impact is more than just typo, so let me update the patch title as:=

net/gve: fix Tx queue state on queue start

Also needs fixes tag:
=C2=A0Fixes: b044845bb015 ("net/gve: support queue start/stop") =C2=A0Cc: stable@dpdk.= org

With above changes,
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>

Applied to dpdk-next-net/main, thanks.

> ---
>=C2=A0 drivers/net/gve/gve_tx.c=C2=A0 =C2=A0 =C2=A0| 2 +-
>=C2=A0 drivers/net/gve/gve_tx_dqo.c | 2 +-
>=C2=A0 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/gve/gve_tx.c b/drivers/net/gve/gve_tx.c
> index 70d3ef0..500ae31 100644
> --- a/drivers/net/gve/gve_tx.c
> +++ b/drivers/net/gve/gve_tx.c
> @@ -688,7 +688,7 @@
>=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), = txq->ntfy_addr);
>=C2=A0
> -=C2=A0 =C2=A0 =C2=A0dev->data->rx_queue_state[tx_queue_id] =3D = RTE_ETH_QUEUE_STATE_STARTED;
> +=C2=A0 =C2=A0 =C2=A0dev->data->tx_queue_state[tx_queue_id] =3D = RTE_ETH_QUEUE_STATE_STARTED;
>=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0return 0;
>=C2=A0 }
> diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo= .c
> index a65e6aa..1b85557 100644
> --- a/drivers/net/gve/gve_tx_dqo.c
> +++ b/drivers/net/gve/gve_tx_dqo.c
> @@ -392,7 +392,7 @@
>=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), = txq->ntfy_addr);
>=C2=A0
> -=C2=A0 =C2=A0 =C2=A0dev->data->rx_queue_state[tx_queue_id] =3D = RTE_ETH_QUEUE_STATE_STARTED;
> +=C2=A0 =C2=A0 =C2=A0dev->data->tx_queue_state[tx_queue_id] =3D = RTE_ETH_QUEUE_STATE_STARTED;
>=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0return 0;
>=C2=A0 }

--00000000000014aab4061dd6bb12--