Hi @Ferruh Yigit I have updated v2 https://patches.dpdk.org/project/dpdk/patch/1721914264-2394611-1-git-send-email-tathagat.dpdk@gmail.com/ and sent it in reply to the previous message id ( https://patches.dpdk.org/project/dpdk/patch/1721828129-2393364-1-git-send-email-tathagat.dpdk@gmail.com/) , let me know if this is fine. On Thu, Jul 25, 2024 at 6:59 PM Tathagat Priyadarshi < tathagat.dpdk@gmail.com> wrote: > The PR aims to update the TX/RQ queue setup/stop routines that are > unique to DQO, so that they may be called for instances that use the > DQO RDA format during dev start/stop > > Signed-off-by: Tathagat Priyadarshi > --- > drivers/net/gve/gve_ethdev.c | 29 +++++++++++++++++++++++------ > 1 file changed, 23 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c > index ca92277..a20092e 100644 > --- a/drivers/net/gve/gve_ethdev.c > +++ b/drivers/net/gve/gve_ethdev.c > @@ -288,11 +288,16 @@ struct gve_queue_page_list * > PMD_DRV_LOG(ERR, "Failed to create %u tx queues.", > num_queues); > return ret; > } > - for (i = 0; i < num_queues; i++) > - if (gve_tx_queue_start(dev, i) != 0) { > + for (i = 0; i < num_queues; i++) { > + if (gve_is_gqi(priv)) > + ret = gve_tx_queue_start(dev, i); > + else > + ret = gve_tx_queue_start_dqo(dev, i); > + if (ret != 0) { > PMD_DRV_LOG(ERR, "Fail to start Tx queue %d", i); > goto err_tx; > } > + } > > num_queues = dev->data->nb_rx_queues; > priv->rxqs = (struct gve_rx_queue **)dev->data->rx_queues; > @@ -315,9 +320,15 @@ struct gve_queue_page_list * > return 0; > > err_rx: > - gve_stop_rx_queues(dev); > + if (gve_is_gqi(priv)) > + gve_stop_rx_queues(dev); > + else > + gve_stop_rx_queues_dqo(dev); > err_tx: > - gve_stop_tx_queues(dev); > + if (gve_is_gqi(priv)) > + gve_stop_tx_queues(dev); > + else > + gve_stop_tx_queues_dqo(dev); > return ret; > } > > @@ -362,10 +373,16 @@ struct gve_queue_page_list * > static int > gve_dev_stop(struct rte_eth_dev *dev) > { > + struct gve_priv *priv = dev->data->dev_private; > dev->data->dev_link.link_status = RTE_ETH_LINK_DOWN; > > - gve_stop_tx_queues(dev); > - gve_stop_rx_queues(dev); > + if (gve_is_gqi(priv)) { > + gve_stop_tx_queues(dev); > + gve_stop_rx_queues(dev); > + } else { > + gve_stop_tx_queues_dqo(dev); > + gve_stop_rx_queues_dqo(dev); > + } > > dev->data->dev_started = 0; > > -- > 1.8.3.1 > >