DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
To: stephen@networkplumber.org
Cc: Varun Lakkur Ambaji Rao <varun.la@gmail.com>,
	dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v3] net/gve : Update EOP & csum bit in txd rte_mbuf chain
Date: Fri, 2 Aug 2024 00:28:28 +0530	[thread overview]
Message-ID: <CA++LmPUjdfN1Rn4JRsj5F5dFWuZPD5m8xQJ+GsjU47Yz+2evKw@mail.gmail.com> (raw)
In-Reply-To: <20240801115449.407d1d7f@hermes.local>

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Thanks for your suggestion Stephen, I have already updated the patch with
v4 & fixed the typo. Will consider your suggestion in the next version of
the patch.


On Fri, 2 Aug 2024 at 00:24, Stephen Hemminger <stephen@networkplumber.org>
wrote:

> On Thu,  1 Aug 2024 17:27:53 +0000
> Tathagat Priyadarshi <tathagat.dpdk@gmail.com> wrote:
>
> > +             if (ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO)
> > +                     csum = 1;
> > +             else
> > +                     cusm = 0;
> > +
>
> Obvious typo, did you do a final test build?
>
> Could also use logical inverse operator instead of if() which will
> generate better code sometimes.
>
>                 csum = !!(ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO);
>
>

[-- Attachment #2: Type: text/html, Size: 1291 bytes --]

  reply	other threads:[~2024-08-01 18:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 16:38 [PATCH] net/gve : Update EOP " Tathagat Priyadarshi
2024-07-31 20:30 ` Joshua Washington
2024-08-01 10:23   ` Tathagat Priyadarshi
2024-08-01 11:16 ` Ferruh Yigit
2024-08-01 16:24   ` Joshua Washington
2024-08-01 17:50     ` Tathagat Priyadarshi
2024-08-01 11:31 ` [PATCH v2] " Tathagat Priyadarshi
2024-08-01 17:27 ` [PATCH v3] net/gve : Update EOP & csum " Tathagat Priyadarshi
2024-08-01 18:54   ` Stephen Hemminger
2024-08-01 18:58     ` Tathagat Priyadarshi [this message]
2024-08-01 17:48 ` [PATCH v4] " Tathagat Priyadarshi
2024-08-02  5:08 ` [PATCH v5] " Tathagat Priyadarshi
2024-08-02  5:10   ` Tathagat Priyadarshi
2024-08-06 14:44     ` Tathagat Priyadarshi
2024-08-07  7:36       ` Ferruh Yigit
2024-08-07  9:39   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA++LmPUjdfN1Rn4JRsj5F5dFWuZPD5m8xQJ+GsjU47Yz+2evKw@mail.gmail.com \
    --to=tathagat.dpdk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=varun.la@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).