From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83B804574E; Tue, 6 Aug 2024 16:45:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74E6540614; Tue, 6 Aug 2024 16:45:12 +0200 (CEST) Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) by mails.dpdk.org (Postfix) with ESMTP id 07E61402F2 for ; Tue, 6 Aug 2024 16:45:11 +0200 (CEST) Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5d5b1e33fa8so407936eaf.3 for ; Tue, 06 Aug 2024 07:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722955510; x=1723560310; darn=dpdk.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XJPvfsa9/WvC8J/Md+slFuVc8/pArhj168sN8jgYt5A=; b=l2A/uRKW/rnS4mkgRg8y+dCC+XQspev6UYY3aWenb410g18dSct6/OOHZ2wOuSvWuo MwyAKqzdwNGOQGtBGOYPZvY5ePLxYCOMPeB2DY6J6gf8EdzKjqup85u2uXJtCRc0DVB6 hFgwPdFtF3BgMMkqrr3H4qt8OoITRrI2FxZ3zZmsw+qgfDElzuICVJJS4G8HOM7ZLWYe D0v1s6lAFgEhiDlvxZNmRgL5IdkbISmdvFXY8tqjHF8scAly4k0fLf5W5HHUag5NV9aD 3xcCfPlNKsHhXivbUiEmDrpO8Il0pAcYyjt0B3BFoP02KdNS6Z51Pl+rFh9LdNIhqV/J PTOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722955510; x=1723560310; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XJPvfsa9/WvC8J/Md+slFuVc8/pArhj168sN8jgYt5A=; b=KcL6JzlBJ+K3STubmrQ2N552C4k9ZL1trqFAqTXFcb6fs09MX4S/00GrjuBvZDGesr 5laO7LyvdgOxTUrZZ5UagUjq+fwmQ/BXQcYXbhp+cdnCjkW3gcxLG8H26fsEU6yf0FEE Pq1adVdVrkuetXJn8prvr34MVktMZnqkjFp1V1rEn54WvDzPxL/NYZBGSOo/cRGMoF56 5W8d6b26WshGkebqQfJLqudqm7YyyCE5Z/lRheYKgky6PZT8XcTh6oQJ894fUNiQbDFs DeNysRiPf63fw4TeRxkFFE510IamAFBxiY3ulCH8csXgcyvpR9nOwJexcsecS7fctGHm 1Dzw== X-Gm-Message-State: AOJu0Yy8VIwzplOTGIgr4HK6Ughrl7GCOMgjcSACcYuiqZW5NB6fU+rU Yh8wb6TViEGIZCseVsCipPT+ZAVXuZ3u3hKqcSyafkFKD3EZo9KcIwDwBksvyCMCvheS5fgUzV6 nXwmvQYR/qMOpB7urcdlsdYqTl4LGwrwc X-Google-Smtp-Source: AGHT+IHAMcIMeRCeOVUZoyHNNQmigmW26lEB6U221OCploPfLzcnZ4vKKg7pPLMxrZJFcwjKJvn7taoXwGKdOp7acZU= X-Received: by 2002:a05:6358:5911:b0:1ab:e07d:c945 with SMTP id e5c5f4694b2df-1af3b9fed15mr1761832755d.1.1722955509928; Tue, 06 Aug 2024 07:45:09 -0700 (PDT) MIME-Version: 1.0 References: <1722443901-2400194-1-git-send-email-tathagat.dpdk@gmail.com> <1722575288-2408630-1-git-send-email-tathagat.dpdk@gmail.com> In-Reply-To: From: Tathagat Priyadarshi Date: Tue, 6 Aug 2024 20:14:58 +0530 Message-ID: Subject: Re: [PATCH v5] net/gve : Update EOP & csum bit in txd rte_mbuf chain To: dev@dpdk.org, Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org hi Ferruh, Could you please accept the updated patch?! let us know what's pending. https://patches.dpdk.org/project/dpdk/patch/1722575288-2408630-1-git-send-e= mail-tathagat.dpdk@gmail.com/ TIA On Fri, Aug 2, 2024 at 10:40=E2=80=AFAM Tathagat Priyadarshi wrote: > > Updated the if-else block with an optimised inverse operator. Thanks > for your suggestion Stephen. > > On Fri, Aug 2, 2024 at 10:36=E2=80=AFAM Tathagat Priyadarshi > wrote: > > > > The EOP and csum bit was not set for all the packets in mbuf chain > > causing packet transmission stalls for packets split across > > mbuf in chain. > > > > Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO") > > Cc: stable@dpdk.org > > > > Signed-off-by: Tathagat Priyadarshi > > Signed-off-by: Varun Lakkur Ambaji Rao > > > > Acked-by: Joshua Washington > > --- > > drivers/net/gve/gve_tx_dqo.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.= c > > index a65e6aa..bbaf46d 100644 > > --- a/drivers/net/gve/gve_tx_dqo.c > > +++ b/drivers/net/gve/gve_tx_dqo.c > > @@ -89,6 +89,7 @@ > > uint16_t sw_id; > > uint64_t bytes; > > uint16_t first_sw_id; > > + uint8_t csum; > > > > sw_ring =3D txq->sw_ring; > > txr =3D txq->tx_ring; > > @@ -114,6 +115,9 @@ > > ol_flags =3D tx_pkt->ol_flags; > > nb_used =3D tx_pkt->nb_segs; > > first_sw_id =3D sw_id; > > + > > + csum =3D !!(ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO); > > + > > do { > > if (sw_ring[sw_id] !=3D NULL) > > PMD_DRV_LOG(DEBUG, "Overwriting an entr= y in sw_ring"); > > @@ -126,6 +130,8 @@ > > txd->pkt.dtype =3D GVE_TX_PKT_DESC_DTYPE_DQO; > > txd->pkt.compl_tag =3D rte_cpu_to_le_16(first_s= w_id); > > txd->pkt.buf_size =3D RTE_MIN(tx_pkt->data_len,= GVE_TX_MAX_BUF_SIZE_DQO); > > + txd->pkt.end_of_packet =3D 0; > > + txd->pkt.checksum_offload_enable =3D csum; > > > > /* size of desc_ring and sw_ring could be diffe= rent */ > > tx_id =3D (tx_id + 1) & mask; > > @@ -138,9 +144,6 @@ > > /* fill the last descriptor with End of Packet (EOP) bi= t */ > > txd->pkt.end_of_packet =3D 1; > > > > - if (ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO) > > - txd->pkt.checksum_offload_enable =3D 1; > > - > > txq->nb_free -=3D nb_used; > > txq->nb_used +=3D nb_used; > > } > > -- > > 1.8.3.1 > >