From: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
To: Joshua Washington <joshwash@google.com>
Cc: jeroendb@google.com, rushilg@google.com, dev@dpdk.org
Subject: Re: [PATCH] net/gve: Update Rx/Tx functions for RTE_PROC_SECONDARY
Date: Fri, 19 Jul 2024 09:45:32 +0530 [thread overview]
Message-ID: <CA++LmPXdJqwx=F-zLisjay0GjXjLxg-FuGM0FFyjsXtrDO8bJQ@mail.gmail.com> (raw)
In-Reply-To: <CALuQH+UYbrf6QLoqZUg=LU5Qy1=woou-jcBsh1nJRwswz2OwUA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
Thanks Joshua, I will fix all the nits in my next email.
On Fri, Jul 19, 2024 at 8:53 AM Joshua Washington <joshwash@google.com>
wrote:
> My ack might have been a bit premature. This patch seems to have a
> number of style errors, and does not seem to apply to HEAD of
> dpdk-next-net. See http://dpdk.org/patch/142498 for more detail.
>
> The code supplied in the patch does not seem to have any indentation.
> Please note that DPDK uses tabs (assumed to take up 8 spaces for the
> purposes of wrapping long lines) instead of spaces. The style guide
> can be found at
> https://doc.dpdk.org/guides/contributing/coding_style.html.
>
> The dpdk-next-net repository can be found at
> http://git.dpdk.org/next/dpdk-next-net.
>
[-- Attachment #2: Type: text/html, Size: 1313 bytes --]
next prev parent reply other threads:[~2024-07-19 4:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 5:34 Tathagat Priyadarshi
2024-07-18 17:59 ` Joshua Washington
2024-07-19 3:23 ` Joshua Washington
2024-07-19 4:15 ` Tathagat Priyadarshi [this message]
2024-07-19 4:36 ` priyadarshitathagat
2024-07-19 4:52 ` [PATCH v2] " priyadarshitathagat
2024-07-19 19:59 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA++LmPXdJqwx=F-zLisjay0GjXjLxg-FuGM0FFyjsXtrDO8bJQ@mail.gmail.com' \
--to=tathagat.dpdk@gmail.com \
--cc=dev@dpdk.org \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=rushilg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).