From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F044145651; Fri, 19 Jul 2024 06:15:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D35D402BE; Fri, 19 Jul 2024 06:15:46 +0200 (CEST) Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by mails.dpdk.org (Postfix) with ESMTP id 2790D40267 for ; Fri, 19 Jul 2024 06:15:45 +0200 (CEST) Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6b796667348so12600396d6.0 for ; Thu, 18 Jul 2024 21:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721362544; x=1721967344; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tU3FCtBJ3EYrpOLBr6C03ZBiQGW4kDXtXhq/KLIE4Yk=; b=gCK/rMkYXiFoakicWd9P6tnpAKZEiPMtH9wM8Q5q6mLh5iwCInxFdA+MD65ZemMLac g4g7FDW4r8OsEbbBM0P4yHktfu58gkV8/Inz5PqBe2xwwr9NJAQpxR5tYv7KrPIpX+sy 7WB6F5aeMXqHFsOUiiQnIm7otFVy/ToQVXCcfR1nzOfYXoATgUeBdLagLrzRqufZHBBS RIHBexHMRfs5CRd9A1ZoVR+p1G7Wyhl7hK3pbU1NNi/iBlBtlFtam/G8kBkS0ngAHK85 11TPgW/SE0JdiPkjfQqn4+PoNJ4STP/YjGSBCvkFIQYRsaXRlg+T2sNTAYfnsIJ1SWbr EQGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721362544; x=1721967344; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tU3FCtBJ3EYrpOLBr6C03ZBiQGW4kDXtXhq/KLIE4Yk=; b=ovDdVegzndtBtrNjASM2pyjujVSGiwuVRmuebx2CZ2SC9qJB3v7NI4BVhj93O41ILu T13gD433IJjeF8D8WAsa9P3Tp26joQhs3+V8cfd1WucX15JzFGbamPPSOsefL4hQCPqv lhBavV66skiA+qjVJfr590BCJd53nfFzDdyb3EVip7tDX58VacdmGKEv8K48hijeraVP rr/oO5jlsJTlrP7ahDPgO4cz6LI8QoPxRZjvKbmI7Tvwi1b8GJHU4/egnRjX92AqdH/G lXN+q4zGuMK14nrvn+21AJpQKu7RnA2H13ytHxbWEk9nsEeW27qb0smhLsrC2FtmRmT2 w4XQ== X-Forwarded-Encrypted: i=1; AJvYcCUMV5VMeHNOJYcVxhfT/gdyZBAWB9dUXyUu3EUohxiO8P2cR8tOkxrnW3OmbaZ8e83eP6o/z1Euqhy92zI= X-Gm-Message-State: AOJu0Yyrpf+hrfpw4n3SmUaWKX1WN1fMRaaIzhoBJytMcZRwVDCYhzjf oqSuR2HZJiSv68gw9Dps+sVi73ZdADsl9YzUUBpZxNB079Ch5Zh4hjdiT186Q0Pb1KX+lhPUfWc cmwzwQynv+qss7UDgE8gp9Bfwy+8= X-Google-Smtp-Source: AGHT+IESziP3/VHZuI/v3SszVhqSZiBaPDopyKkok/hdiAypo70OY0ZwenoTVfJgH4/rxOYOLoc/PRVwBAX3PqCNnwQ= X-Received: by 2002:a0c:eac7:0:b0:6b5:25b6:dd04 with SMTP id 6a1803df08f44-6b79cbe77b2mr86362136d6.1.1721362544198; Thu, 18 Jul 2024 21:15:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tathagat Priyadarshi Date: Fri, 19 Jul 2024 09:45:32 +0530 Message-ID: Subject: Re: [PATCH] net/gve: Update Rx/Tx functions for RTE_PROC_SECONDARY To: Joshua Washington Cc: jeroendb@google.com, rushilg@google.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000fa1018061d91f2b8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000fa1018061d91f2b8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks Joshua, I will fix all the nits in my next email. On Fri, Jul 19, 2024 at 8:53=E2=80=AFAM Joshua Washington wrote: > My ack might have been a bit premature. This patch seems to have a > number of style errors, and does not seem to apply to HEAD of > dpdk-next-net. See http://dpdk.org/patch/142498 for more detail. > > The code supplied in the patch does not seem to have any indentation. > Please note that DPDK uses tabs (assumed to take up 8 spaces for the > purposes of wrapping long lines) instead of spaces. The style guide > can be found at > https://doc.dpdk.org/guides/contributing/coding_style.html. > > The dpdk-next-net repository can be found at > http://git.dpdk.org/next/dpdk-next-net. > --000000000000fa1018061d91f2b8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks=C2=A0Joshua, I will fix all the nits in my next=C2= =A0email.

On Fri, Jul 19, 2024 at 8:53=E2=80=AFAM Joshua Washington <joshwash@google.com> wrote:
My ack might have bee= n a bit premature. This patch seems to have a
number of style errors, and does not seem to apply to HEAD of
dpdk-next-net. See http://dpdk.org/patch/142498 for more detail.

The code supplied in the patch does not seem to have any indentation.
Please note that DPDK uses tabs (assumed to take up 8 spaces for the
purposes of wrapping long lines) instead of spaces. The style guide
can be found at
https://doc.dpdk.org/guides/contributing/= coding_style.html.

The dpdk-next-net repository can be found at
http://git.dpdk.org/next/dpdk-next-net.
--000000000000fa1018061d91f2b8--