From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E45F45710; Thu, 1 Aug 2024 12:24:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D571C40E0A; Thu, 1 Aug 2024 12:24:00 +0200 (CEST) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by mails.dpdk.org (Postfix) with ESMTP id 7D0F940270 for ; Thu, 1 Aug 2024 12:23:59 +0200 (CEST) Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7093705c708so6906101a34.1 for ; Thu, 01 Aug 2024 03:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722507838; x=1723112638; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9S4kXNBg/z86fRVdA0xapG61Y1EtDwXs07RMrCBrQuQ=; b=F27LsvKYMH91MiGs7Kjl9K3TAG2Y4abZn3FihH8OYd7GwwjN5eZo5LN0HgLZ+pIou4 1WXtLuyKSPNs/lvofO0pEvZ3pAL3EnyWLqiovcwq/HW3JOacscVpCCizT+BLk1KLDisO KanY7ilnMrTgbh1MeOW40XXq1xnemat0PLITiEvvUn8nvc2311hodBnxiw6va5qRmmey LsP21skGnnvZzT2VRGF1UGeSewzuS7n25FPqZaOLYLxIn1i2WILdp3GByva8ber3Dwly RtVR8F6rWGmYmmkNNA/6vN3WiCgPo+uJOa6q6sBp+5C5kmKDh7p9JZO/784gCJ6HXVAr ty+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722507838; x=1723112638; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9S4kXNBg/z86fRVdA0xapG61Y1EtDwXs07RMrCBrQuQ=; b=l3FYceibyn3Al2YdEI7T+n2Z3GFosxFKK5ajeiWleNQ9ZDKPlehUTpd3KGK57AzY32 A60PR8zcPblrHa0BDvrbrupP54AckRYcrrRLpGWxNZ/jVpI+g5gsS4pp8FGG5dYJgLxY qhbdF+JuMUKY16IePhX0S9v01tkFYXU5UqSptS+D0tKNyBxZYLeyGvmfXOAvqcYPi6F+ 6Gfnw12UjiDiAqkwwekH4HBxqQ+GKD5Ysvni3Rm8Z4wYSp4/TU+oZR/I7SVu5zZT/C8S 6EHqfzC7a12wp0vnRt1eBwO9CGei+96t9QEH7LiMamG9PE2SHQ/ghuMyehmiX03fQEgV b7Lw== X-Forwarded-Encrypted: i=1; AJvYcCUdVF3akoPUbmbF8QtqKO4KTusZqpLJPJ/WLmBQI8UrSoDF8sDtEf+rfJzSTh33+5S0tsshtf94WI0K6ig= X-Gm-Message-State: AOJu0YzwJ9AigZVBiXG8j8rYTnwJJXmoagBLRHXJB3snNJe8iZYmYibX DfT56ELqbD4zLgQTO3woDXg0leGeAjeVG54esSwL9Z+jBkygHw/OaJ1b9DoAx5nEGcSIkTTZ7F1 eUPCug77veSbhMprHoFdLclCXmLw= X-Google-Smtp-Source: AGHT+IFEyRzAnqKUKzTN2tAKpNWg0qVZYDXWMNWHyNU3eWwNGY6i3LtLgY53TfsswMUzA6ZiuiaIamQaRX0mf5wbdss= X-Received: by 2002:a05:6358:3423:b0:1aa:cdba:4fa8 with SMTP id e5c5f4694b2df-1af2ed7f125mr234730355d.13.1722507838267; Thu, 01 Aug 2024 03:23:58 -0700 (PDT) MIME-Version: 1.0 References: <1722443901-2400194-1-git-send-email-tathagat.dpdk@gmail.com> In-Reply-To: From: Tathagat Priyadarshi Date: Thu, 1 Aug 2024 15:53:47 +0530 Message-ID: Subject: Re: [PATCH] net/gve : Update EOP bit in txd rte_mbuf chain To: Joshua Washington Cc: Rushil Gupta , dev@dpdk.org, Varun Lakkur Ambaji Rao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Joshua, We have addressed the checksum offload update for each mbuf in the following patch (net/gve: Add support for TSO in DQO RDA). https://patches.dpdk.org/project/dpdk/patch/1722507548-2401507-1-git-send-e= mail-tathagat.dpdk@gmail.com/ Thanks a lot! On Thu, Aug 1, 2024 at 2:00=E2=80=AFAM Joshua Washington wrote: > > On Wed, Jul 31, 2024, 09:37 Tathagat Priyadarshi > wrote: > > > > The EOP bit was not set for all the packets in mbuf chain > > causing packet transmission stalls for packets split across > > mbuf in chain. > > > > Signed-off-by: Tathagat Priyadarshi > > Signed-off-by: Varun Lakkur Ambaji Rao > > > > Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO") > > --- > > drivers/net/gve/gve_tx_dqo.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.= c > > index a65e6aa..579b8d6 100644 > > --- a/drivers/net/gve/gve_tx_dqo.c > > +++ b/drivers/net/gve/gve_tx_dqo.c > > @@ -126,6 +126,7 @@ > > txd->pkt.dtype =3D GVE_TX_PKT_DESC_DTYPE_DQO; > > txd->pkt.compl_tag =3D rte_cpu_to_le_16(first_s= w_id); > > txd->pkt.buf_size =3D RTE_MIN(tx_pkt->data_len,= GVE_TX_MAX_BUF_SIZE_DQO); > > + txd->pkt.end_of_packet =3D 0; > > Please also update checksum offload for each mbuf. > > > > > > /* size of desc_ring and sw_ring could be diffe= rent */ > > tx_id =3D (tx_id + 1) & mask; > > -- > > 1.8.3.1 > > > > Thanks for all of the contributions! Let's try to get this applied to > stable release as well.