From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <marcdevel@gmail.com>
Received: from mail-ig0-f180.google.com (mail-ig0-f180.google.com
 [209.85.213.180]) by dpdk.org (Postfix) with ESMTP id B8A3C5A68
 for <dev@dpdk.org>; Wed, 18 Nov 2015 23:59:56 +0100 (CET)
Received: by igvg19 with SMTP id g19so128417722igv.1
 for <dev@dpdk.org>; Wed, 18 Nov 2015 14:59:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=jUevBOKP4fbwAeRlvyFrJH0qdrlq2waWnzACN7PqF0s=;
 b=AEPSwqnOyNnhSmNvi9SnTR8mDjFx2V8OdclwcUty5FEBZODXto53VRO3Y/uEs/O/+S
 zR22SMwSJsvQ9Bv9GEFCX1w51OlaME0c2WHSeR0+fIINhWUUU3F9rx2lh+AMPaTtVsUh
 0qnFUb0LrSS9LUno6QfPeycsjs1FiYdpw5ZK+/5BRL9Sf5/3W3z+JGwPNH6HIaq07V22
 01fXvqVT6kI/TgkyKSaWME6XxY48rYuqmM2QN4hZYIlyhc7quqB0qEPmtkuejtdHGQWq
 Ut2Gj+wxtr+vqHrgvxpEbwsk0AWLv5e5quDlws126ka5z0Tuea4za5dO84flje8xahiQ
 2mfg==
MIME-Version: 1.0
X-Received: by 10.50.225.102 with SMTP id rj6mr10566435igc.95.1447887596224;
 Wed, 18 Nov 2015 14:59:56 -0800 (PST)
Received: by 10.79.109.130 with HTTP; Wed, 18 Nov 2015 14:59:56 -0800 (PST)
In-Reply-To: <5329031.lkkhyj5zos@xps13>
References: <1443993003-1059-1-git-send-email-marcdevel@gmail.com>
 <1445810400-8978-1-git-send-email-marcdevel@gmail.com>
 <1445810400-8978-4-git-send-email-marcdevel@gmail.com>
 <5329031.lkkhyj5zos@xps13>
Date: Wed, 18 Nov 2015 23:59:56 +0100
Message-ID: <CA+3n-Tq-qXh_hOA2uWy8rwthOVO_9fZRZTFHS_WH6BD_hZyA3A@mail.gmail.com>
From: Marc Sune <marcdevel@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 3/5] ethdev: redesign link speed config API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Nov 2015 22:59:57 -0000

Hi Thomas,

2015-11-01 23:16 GMT+01:00 Thomas Monjalon <thomas.monjalon@6wind.com>:

> 2015-10-25 22:59, Marc Sune:
> > This patch redesigns the API to set the link speed/s configure
> > for an ethernet port. Specifically:
> >
> > - it allows to define a set of advertised speeds for
> >   auto-negociation.
> > - it allows to disable link auto-negociation (single fixed speed).
> > - default: auto-negociate all supported speeds.
> >
> > Other changes:
> >
> > * Added utility MACROs ETH_SPEED_NUM_XXX with the numeric
> >   values of all supported link speeds, in Mbps.
> > * Converted link_speed to uint32_t to accomodate 100G speeds
> >   (bug).
> > * Added autoneg flag in struct rte_eth_link to indicate if
> >   link speed was a result of auto-negociation or was fixed
> >   by configuration.
> > * Added utility function to convert numeric speeds to bitmap
> >   fields.
>
> Having it split in several commits may help to understand the changes.
>

Apologies for the late response... crazy days.

At least first and last point in the enumeration do not make sense alone. I
can split the link_speed bug for 100G in another patch if you consider is
necessary for the series to be merged in.


> And it must be explained in the release notes in the "API changes".
>

Patch 4/5 in the series attempts to cover this:

http://dpdk.org/dev/patchwork/patch/7996/

Isn't it enough?

Marc