From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f172.google.com (mail-io0-f172.google.com [209.85.223.172]) by dpdk.org (Postfix) with ESMTP id 10CB3374E for ; Thu, 19 Nov 2015 00:08:06 +0100 (CET) Received: by iofh3 with SMTP id h3so71093603iof.3 for ; Wed, 18 Nov 2015 15:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=im69oBttcR/2zWYgumuHW2K1NQoz1iEA3V87BHvrx9M=; b=Tyn+d7BAnWVFflyoaNojsJZjjOddc0ZwZz0V+nhmCXTWhVsafVT7lIF9OhnX02kY5o 2VvHCtp4JF5SAzYQGLP5tibVQKaWS1hvU+XNU+Yr7OK/k5OyS+0tGmlZokS02+GC3dvq Nh0CVIXLdteVEUR3QnXK2D+83lxEhqX9jwPGmPWCtVivmBSouF4DFj0IAqupKDNcYwSb mZkza2DkJGshc/etz2jaL9VWh9UHVvGibo+M0W2u+0RCAB/vf0UbTgpuSpPdrDZphmsM p7Nx//VMpX0OiSn2jyONFWolS14CVSBAVgcszUChGW2l7/QAL7O5hcXv7Re+PzW7n3EJ G7FA== MIME-Version: 1.0 X-Received: by 10.107.15.148 with SMTP id 20mr5420481iop.66.1447888085518; Wed, 18 Nov 2015 15:08:05 -0800 (PST) Received: by 10.79.109.130 with HTTP; Wed, 18 Nov 2015 15:08:05 -0800 (PST) In-Reply-To: <18320386.mavPrt1dXu@xps13> References: <1443993003-1059-1-git-send-email-marcdevel@gmail.com> <1445810400-8978-1-git-send-email-marcdevel@gmail.com> <1445810400-8978-2-git-send-email-marcdevel@gmail.com> <18320386.mavPrt1dXu@xps13> Date: Thu, 19 Nov 2015 00:08:05 +0100 Message-ID: From: Marc Sune To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/5] ethdev: Added ETH_SPEED_CAP bitmap for ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2015 23:08:06 -0000 Hi Thomas, 2015-11-01 23:11 GMT+01:00 Thomas Monjalon : > 2015-10-25 22:59, Marc Sune: > > +#define ETH_SPEED_CAP_NOT_PHY (0) /*< No phy media > */ > > +#define ETH_SPEED_CAP_10M_HD (1 << 0) /*< 10 Mbps half-duplex> */ > > +#define ETH_SPEED_CAP_10M_FD (1 << 1) /*< 10 Mbps full-duplex> */ > > +#define ETH_SPEED_CAP_100M_HD (1 << 2) /*< 100 Mbps > half-duplex> */ > > +#define ETH_SPEED_CAP_100M_FD (1 << 3) /*< 100 Mbps > full-duplex> */ > > +#define ETH_SPEED_CAP_1G (1 << 4) /*< 1 Gbps > */ > > +#define ETH_SPEED_CAP_2_5G (1 << 5) /*< 2.5 Gbps > */ > > +#define ETH_SPEED_CAP_5G (1 << 6) /*< 5 Gbps > */ > > +#define ETH_SPEED_CAP_10G (1 << 7) /*< 10 Mbps > */ > > +#define ETH_SPEED_CAP_20G (1 << 8) /*< 20 Gbps > */ > > +#define ETH_SPEED_CAP_25G (1 << 9) /*< 25 Gbps > */ > > +#define ETH_SPEED_CAP_40G (1 << 10) /*< 40 Gbps > */ > > +#define ETH_SPEED_CAP_50G (1 << 11) /*< 50 Gbps > */ > > +#define ETH_SPEED_CAP_56G (1 << 12) /*< 56 Gbps > */ > > +#define ETH_SPEED_CAP_100G (1 << 13) /*< 100 Gbps > */ > > In the patch 3, you rename this flags. It would be easier to understand if > the right names were used in the first patch. > > > @@ -837,6 +860,7 @@ struct rte_eth_dev_info { > > uint16_t vmdq_queue_base; /**< First queue ID for VMDQ pools. */ > > uint16_t vmdq_queue_num; /**< Queue number for VMDQ pools. */ > > uint16_t vmdq_pool_base; /**< First ID of VMDQ pools. */ > > + uint32_t speed_capa; /**< Supported speeds bitmap > (ETH_SPEED_CAP_). */ > > When renaming ETH_SPEED_CAP, this line is not changed later. > This is made in purpose. In patch 3/5 the bitmap speeds are renamed to ETH_LINK_SPEED_XXX and numeric values are moved ETH_SPEED_NUM_XXX, to make clear the difference. I cannot, in this commit, rename them directly to ETH_LINK_SPEED_XXX since they would collide with the current numeric speeds. Thanks Marc