From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f51.google.com (mail-vk0-f51.google.com [209.85.213.51]) by dpdk.org (Postfix) with ESMTP id 37C14CF80 for ; Fri, 17 Mar 2017 18:47:22 +0100 (CET) Received: by mail-vk0-f51.google.com with SMTP id j64so30074631vkg.3 for ; Fri, 17 Mar 2017 10:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=C1LLlGwFXDonSnJPDaNQPQ28CQW/4GhNYWoV7N7tLRI=; b=tr8QgRRnGKfghDtmr0nvUy8e87dYVTZfosvSDViuRwQzCoXO6p4rv4lxiiW5JTwTu4 x30o3e7BNfMGCT1PBuTbj19nRv2yA/12MvOPEVvps9ZxtUWDI3rR9eTnVon9OuSFWwbU bgfgnZjSY2mpg7w8GZonV3qJPGzWzjTtpl8/ZW8L/26szhbjiRGha7neWei0kVWVbYPs lOaltNa5abNeGJVpX5HB4Cpg/Rwiawe/2LnmaQIh/o7g4r58hAAYLrC0ZIOVoujtwvYy Sg4X8C4sY/tjscqE3+cnUPFKtLZkJ3Nu/WNSszyqz12IjKaiNSrvb7KvMb4UpONvyf20 r4lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=C1LLlGwFXDonSnJPDaNQPQ28CQW/4GhNYWoV7N7tLRI=; b=NBiXBarAnNRlywmmvAy2wmalrrYbQlbjga50Bmt7R94VLaeeWr04wcRWoQpZzs/nNV LidcFlRQpqj6PVCGIgb0cz99DD/v5NHxHamAk9afm3Fyp1PUuEFMjw2LIWL/mk+BN8F6 hIxSC5sjErOr/cSs+VoMjLpxtnL3KdU0gwEwyQZ9Su6lr1tdVAQfefI8yLTIaIDI+AE7 umQX8Qx9E3hYlp2blPaET69f15wVfZ4b7XfLYc/gkRcNUkMBqHUzLLE5v70hn/CDebvY Lg7fr43hGhbLNEf7hk9UO3WwPux+xVQbXOP4LLFPhi95X7+S97YDu6zsV8YacjD0qTAy yYKg== X-Gm-Message-State: AFeK/H37FV2IWatQkaVDl1gvPYmtrM8uxNGT0rTA13YvItNrCOpJwotnS2tZTmak1SUOCYd6065N+G7QyWYjbff0 X-Received: by 10.31.125.204 with SMTP id y195mr6098828vkc.59.1489772841592; Fri, 17 Mar 2017 10:47:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.144.199 with HTTP; Fri, 17 Mar 2017 10:47:20 -0700 (PDT) Received: by 10.103.144.199 with HTTP; Fri, 17 Mar 2017 10:47:20 -0700 (PDT) In-Reply-To: <1489770822-27539-1-git-send-email-olivier.matz@6wind.com> References: <1485191953-2613-1-git-send-email-olivier.matz@6wind.com> <1489770822-27539-1-git-send-email-olivier.matz@6wind.com> From: Robin Jarry Date: Fri, 17 Mar 2017 18:47:20 +0100 Message-ID: To: Olivier MATZ Cc: Ferruh Yigit , Thomas Monjalon , dev@dpdk.org, keith.wiles@intel.com, jerin.jacob@caviumnetworks.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Mar 2017 17:47:22 -0000 Hi Olivier, Thanks again for this. I only have minor cosmetic remarks: Le 17 mars 2017 18:13, "Olivier Matz" a =C3=A9crit= : > diff --git a/app/pdump/Makefile b/app/pdump/Makefile > index 536198f..8ec6bd6 100644 > --- a/app/pdump/Makefile > +++ b/app/pdump/Makefile > @@ -42,7 +42,6 @@ CFLAGS +=3D $(WERROR_FLAGS) > SRCS-y :=3D main.c > > # this application needs libraries first > -DEPDIRS-y +=3D lib > > include $(RTE_SDK)/mk/rte.app.mk Maybe remove the comment line too? > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile > index eec1ed0..3be1ae8 100644 > --- a/app/test-pmd/Makefile > +++ b/app/test-pmd/Makefile > @@ -82,7 +82,6 @@ endif > CFLAGS_cmdline.o :=3D -D_GNU_SOURCE > > # this application needs libraries first > -DEPDIRS-y +=3D lib drivers > > include $(RTE_SDK)/mk/rte.app.mk Same here. There may be others. > --- a/mk/rte.subdir.mk > +++ b/mk/rte.subdir.mk > @@ -59,8 +61,9 @@ build: _postbuild > .PHONY: $(DIRS-y) > $(DIRS-y): > @[ -d $(CURDIR)/$@ ] || mkdir -p $(CURDIR)/$@ > - @echo "=3D=3D Build $S/$@" > + @echo "=3D=3D Build $S/$@ " Why change this line ? Robin