From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29D00A04DB; Tue, 17 Nov 2020 08:42:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A6CF37B1; Tue, 17 Nov 2020 08:42:19 +0100 (CET) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id 3998B37B0 for ; Tue, 17 Nov 2020 08:42:16 +0100 (CET) Received: by mail-lf1-f65.google.com with SMTP id a9so27777932lfh.2 for ; Mon, 16 Nov 2020 23:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wkTE3jP5qhI3YN0KxgnIo/o/Cf6WbKyxjRlu4oQvZlM=; b=hY537LN5udrMC/VtaA4oQMbt7pYtqLos8m9YGd0DdjwfR2XTT3zEkI0+ilVWA8t/gg BRrBO3r4bSIuNZy9Lja6Hwlu2+e5admdkYHndUdZjwJl5PsddNZ846blC958FwXvnrar eGV4boAqs9g+/rFUrWSTtYD4AOBSGVVUgGEGLhvbHyIe6LQc6+rBGsJhuYkhaoJEAHrY y+ZIbzs93aqt8DTEzYf5lxgD6cWKOo6epwRQ0AdTkcna29BxngQV6N0q1M84ZUhnmHB7 WU2ZQme4pIYUls0pLcI19F/E3kZPWnqaNXC0qCg41Bp1Bho8xaIv8m4vaLrfJ49On0Tp Oxnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wkTE3jP5qhI3YN0KxgnIo/o/Cf6WbKyxjRlu4oQvZlM=; b=FWwNXGXKAYV5KEwcVI5C8MB1SXuIzFkm/mrWuuMkwQDP+7oOCUOUjcGwqa8ELHpHRp 4yc6f0glCS3cj5RQVfkJV3sSKSI8l0UBz/1KVc4EJp7darKp5f0I3WgwFIQX4ZMlc9v2 VE66t+So1ta8wqyQrCYEzzvJyEWyQNsVFWFFgkSXqVv9oYup/cuNxY4w9gynjIqExALa aUEEbCDlI1p2geNLVeGjLB1rO8Tc23NTkFOPZuc9FLWNryviTIoWQW1yvIZ+0WgeticJ rv31RX8fRpesqWt7N84NGpzU1UZaF7hHeSMm5fZ2Qfgrp3OXPmL3i58K15rZ+BlUW4ui C0Ow== X-Gm-Message-State: AOAM532DNIFTW3rKuKEjb41tIsZfirEBJDKJx0O9H86Z+6PxH7dva8e8 WBzxDjE6pH2potJqr86bOXF1+/rZug1m8YdtfXVPuQ== X-Google-Smtp-Source: ABdhPJykhfAgvlbID/xZTd/GaHroepxXJe3WC8QBEz0tNJnLHP8ABc3l/JuskZq5yHDws21+yn4LwOSypVF84OCZKHw= X-Received: by 2002:ac2:52b3:: with SMTP id r19mr1206409lfm.140.1605598935777; Mon, 16 Nov 2020 23:42:15 -0800 (PST) MIME-Version: 1.0 References: <20201111081507.19913-1-ibtisam.tariq@emumba.com> <20201111081507.19913-5-ibtisam.tariq@emumba.com> In-Reply-To: From: Ibtisam Tariq Date: Tue, 17 Nov 2020 12:42:04 +0500 Message-ID: To: David Marchand Cc: Maxime Coquelin , "Xia, Chenbo" , Cristian Dumitrescu , "Singh, Jasvinder" , "Mcnamara, John" , "Pattan, Reshma" , "Ananyev, Konstantin" , "Kovacevic, Marko" , dev , Stephen Hemminger Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 5/7] examples/qos_sched: enhance getopt_long usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Yes, I will remove str_is function and submit the v3 of this patch soon. On Sat, Nov 14, 2020 at 4:13 PM David Marchand wrote: > On Wed, Nov 11, 2020 at 9:17 AM Ibtisam Tariq > wrote: > > > > Instead of using getopt_long return value, strcmp was used to > > compare the input parameters with the struct option array. This > > patch get rid of all those strcmp by directly binding each longopt > > with an int enum. This is to improve readability and consistency in > > all examples. > > > > Bugzilla ID: 238 > > Cc: stephen@networkplumber.org > > > > Reported-by: David Marchand > > Signed-off-by: Ibtisam Tariq > > This patch breaks compilation with clang: > https://travis-ci.com/github/ovsrobot/dpdk/jobs/433053506#L1019 > > You can remove this str_is helper. > > > -- > David Marchand > > -- - Ibtisam