From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f173.google.com (mail-io0-f173.google.com [209.85.223.173]) by dpdk.org (Postfix) with ESMTP id 9BE3B9AC0 for ; Mon, 16 May 2016 14:59:34 +0200 (CEST) Received: by mail-io0-f173.google.com with SMTP id i75so202869716ioa.3 for ; Mon, 16 May 2016 05:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=TxXe/OQ6ueDWyjcQuYVijA6vF344H2X6lP4fy2ARaXY=; b=pV/Mz3mtMdT3410WXdypkybNlapPG7Fr4OrcPua+JCWyZHEv6vymMEmGqsSxxLYCBL 1i+mK5fLwQPwvmRiBzrkm901rBON1dWhhXTyjBWDS7ImqbFqCbw19rb3h545PkzcgPO8 rySCddFDqVGzMAClt0SGEAJqra3umnLpEfdK1zSQtQw+M5Qg+m7mg8XBws6/cN0MIF5c LiCg3F3d/QXL8TRBfspR4fGbWCFiiA0TZmyjihmukFxL+71kZTfCXFw9C5f6mBisGUCy qtvhDgzA7sZV4JsgBbcIIuAIsIiVczPioq6zPGR6slgjyPYZXBl5M83WhIbXMxAX0fe4 4UdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=TxXe/OQ6ueDWyjcQuYVijA6vF344H2X6lP4fy2ARaXY=; b=Q0N1qtm4g0yfRvnQAFL9XHa68FujbM1Lh0anGaKjNaCRCTg1M7ZqkN3JUKMBpGdJB4 oTvvFezeUJnjomT0JpDpgaA1VYZ3hqC+FS3FzbA/J09rkI6Zbf7eCS6QlFaQxl3Va6Pu 6ra52UmXX6lF+idu6t6E66EEZ8f0JZvFh+QJ4g18lGqOOT4VbC7MHum5GEzq5Fm5HVkJ IxVHPd6hgJQ3dYrbgYJOmhlnPtiVLWwn1gLHgjVzQq/iFHWkjkuOzFY1qyB6gCaJSiMx 6Mqowb5hAPjvhczlRZegdIRGLT7O/ZNP1kRxhFMfU4aHTaTuOG1XWv47FvNkWyCU77zV vi+Q== X-Gm-Message-State: AOPr4FWJAZTvWmWRTI/RE6s5TAkBHC2wP8YFbSmFwpdmhTJMPfi5U0oRrfPtK+Yvg6hgoDcH8wOafaxiI6e+4fU/ MIME-Version: 1.0 X-Received: by 10.107.52.12 with SMTP id b12mr20642632ioa.6.1463403574123; Mon, 16 May 2016 05:59:34 -0700 (PDT) Received: by 10.36.144.196 with HTTP; Mon, 16 May 2016 05:59:34 -0700 (PDT) In-Reply-To: References: <1461163170-237505-1-git-send-email-danielx.t.mrzyglod@intel.com> <1965626.9JUMUNfzfm@xps13> Date: Mon, 16 May 2016 14:59:34 +0200 Message-ID: From: Thomas Monjalon To: "Mcnamara, John" Cc: "Mrzyglod, DanielX T" , "dev@dpdk.org" , "Carew, Alan" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] power: fix argument cannot be negative X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 12:59:35 -0000 2016-05-16 14:39 GMT+02:00 Mcnamara, John : > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon >> The next statement is probably a useless copy paste of the coverity >> report. >> >> > In send_msg: Negative value used as argument to a function expecting a >> > positive value (for example, size of buffer or allocation) > > A question on this point. Is it just that the Coverity message is useless > in this case or in general? For other error/warning fixes we include the > message in the commit. Sometimes, the coverity message is accurate, sometimes it s better to reword it. Anyway, having 2 sentences saying the same thing is disturbing.