From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f170.google.com (mail-qk0-f170.google.com [209.85.220.170]) by dpdk.org (Postfix) with ESMTP id 2348F1BB18 for ; Fri, 27 Oct 2017 17:00:06 +0200 (CEST) Received: by mail-qk0-f170.google.com with SMTP id w134so8686373qkb.0 for ; Fri, 27 Oct 2017 08:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bigswitch-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fw5waab8lw+Z6cEdoDl1b05tgCPoiB6YQNrcEACDVJE=; b=GtV+DRNH1HmZKi8lFYjfY9TlobcYQaWbBkh1fUZkBCVLpxZCYv64bf4AgYORYgdp1B 3p1ASS0MxMXpyR7U2ZE+CP84B0/tbd1S7g6kjDGibpbu5HxNGdXQxNTKOE/PyAr5+WYx d10BUnjFxkH1rrYpYx28g1MxtAy2vbOM0SvUlCmtMuiEzykHztP7KDO03fdknqfcyHIH lvqO0ybSWZOgpQ1i63gZiN0Ml947zVHZ7JsaXgrDlRfqGFXePaEJi62DYFzUX6UKyGkO lvr5V/rXm6Nr0cm+l7rblY+3Ry2bWF8Rn/4kB1CRsDD3jrT+cmth8Fp8gKuyCK2q2ZWo CbLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fw5waab8lw+Z6cEdoDl1b05tgCPoiB6YQNrcEACDVJE=; b=BMAif7OvDkjLvl8DgUQviy9Fm2QpqPFWNbfgn2MH8eHo7SDUVNwkcXFOuetIJlL9k8 PQECDetARS39ZnGcmd34g1m4XlBg7YPdtm2DFC3OrxNRomVUxvbxgmEMu9VSjLloou+H 4zNonYHIRwNuOeSxA3I6W6dFqTMTyXDkcDFmhtzRN9ajRUPllm/0mkoMOxZULKq29lOB 4uki/AHYX3vPhbudhsDHLzqrkC1M0kvGj1q+N+wVkg38TB/w7p6SuzHW7XibjPdjI/eZ 8lfmaRQVaiDtrQ+C+lpG1e5Hw6XDsQ6ZAIJgX5s6ZJaDbNSuUDl1W2EbEjEMCPZA8SyS +ZXw== X-Gm-Message-State: AMCzsaVLtkGmzHtCnWFJ2vSpbXQJscFVwB5ss1lW/FIrH+WmmeRXl2GS EfZwTq2cj6pdUxKZ6gPsFxEjli0yWZiq92tPTV5bYYW3 X-Google-Smtp-Source: ABhQp+SmYvMLRyq2v/De0FHzQITPnUVScXlP6V9XsLpoz5Wx3Re8OCqOhxsamE/QujLH5EEIsGOr9CdgOpAd/eiT6oQ= X-Received: by 10.55.212.70 with SMTP id l67mr1229343qki.140.1509116405404; Fri, 27 Oct 2017 08:00:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.134.183 with HTTP; Fri, 27 Oct 2017 08:00:04 -0700 (PDT) In-Reply-To: References: <1503086972-32649-1-git-send-email-mike.stolarchuk@bigswitch.com> <4317181.EN77ZZiejQ@xps> From: Mike Stolarchuk Date: Fri, 27 Oct 2017 11:00:04 -0400 Message-ID: To: "De Lara Guarch, Pablo" Cc: Thomas Monjalon , "Richardson, Bruce" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 15:00:06 -0000 Pablo, Also, what about the other patch? the use of a static variable in a recursive call? obviously incorrect for a threaded environment ... has that been accepted? regards, mts. On Thu, Oct 19, 2017 at 4:10 AM, De Lara Guarch, Pablo < pablo.de.lara.guarch@intel.com> wrote: > > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Tuesday, October 17, 2017 2:59 PM > > To: Richardson, Bruce ; De Lara Guarch, > > Pablo > > Cc: dev@dpdk.org; mstolarchuk > > Subject: Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key > > > > 18/08/2017 22:09, mstolarchuk: > > > Improves consistency, allows identifcation of use-sites > > > > > > Signed-off-by: mstolarchuk > > > > Any comment on this patch and others from the same author? > > Hi, > > Two of the patches submitted are actually the same, although they have a > different enumeration. > The patches look like they were part of two different patchsets, so it > doesn't look right. > Also, patch 6/6 is not applicable anymore, as a similar fix was sent > previously. > > Mike, could you send another patchset, that is rebased on top of the > latest code? > > Thanks, > Pablo >