From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com [209.85.217.178]) by dpdk.org (Postfix) with ESMTP id 5D063DE0 for ; Fri, 10 Jan 2014 02:01:25 +0100 (CET) Received: by mail-lb0-f178.google.com with SMTP id c11so2868633lbj.37 for ; Thu, 09 Jan 2014 17:02:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=3xiY09zeGutTLvKknl2xFR14mYDJ7AAEISrzzRhWHJg=; b=ajuEQnRFTbR3ujHanWCFmBOe/aFfskDeW+z5A7xyiRzCAX6N4KVbkLfPFHqWZw47F3 9U77dYv+zDOrmxMCmaMjUdP+zZvOoSsGNXuz6m1oE39qOqVFU+bdNuFDrS+cf04sR6bW 36qFuDdhNf5dLZOQ4NfsE6g0yWTd5U5uKVSZ2zb2u92TCmzss36yJZZFXQK2u7YkEmXB M7AQWQfQPeIaR/4eS/fiCCRR/kjaqkeThbxfeSnWP1w4ltRgBcGFTiSbDeNieoOcAAvA 8NmAznjz2PkLXGry9VgJxrJ4CN31lWzDCaUE+VcKhPubIeo7agEFBrEhKd/8jQSSCtCe 6+Wg== X-Gm-Message-State: ALoCoQkrmD86Toz+JKTBlVuMyEQCCGyNBxn9OUogOAl32sfD3/nvmXy/4W06nhe/U++JmHZi/KU5 MIME-Version: 1.0 X-Received: by 10.152.20.6 with SMTP id j6mr2520015lae.8.1389315754650; Thu, 09 Jan 2014 17:02:34 -0800 (PST) Received: by 10.112.137.34 with HTTP; Thu, 9 Jan 2014 17:02:34 -0800 (PST) In-Reply-To: <1570706.IYEFmS7tHv@x220> References: <6B1399EF-19FC-4493-B9CA-DD872CD728B4@nyansa.com> <1570706.IYEFmS7tHv@x220> Date: Thu, 9 Jan 2014 17:02:34 -0800 Message-ID: From: Dan Kan To: Thomas Monjalon Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] Unable to get RSS to work in testpmd and load balancing question X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jan 2014 01:01:25 -0000 I think the following change might be sufficient. DCB seems to use its own init_port_dcb_config(), which would reset mq_mode. If this is good, I can submit the patch. Thanks. index b11eb2e..355db0f 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1546,6 +1546,9 @@ init_port_config(void) if (nb_rxq > 0) { port->dev_conf.rx_adv_conf.rss_conf.rss_key =3D NUL= L; port->dev_conf.rx_adv_conf.rss_conf.rss_hf =3D rss_= hf; + if (nb_rxq > 1 && rss_hf !=3D 0) { + port->dev_conf.rxmode.mq_mode =3D ETH_MQ_RX_RSS; + } } else { port->dev_conf.rx_adv_conf.rss_conf.rss_key =3D NUL= L; port->dev_conf.rx_adv_conf.rss_conf.rss_hf =3D 0; On Thu, Jan 9, 2014 at 3:11 PM, Thomas Monjalon wrote: > Hello, > > 09/01/2014 10:49, Daniel Kan : > > The problem appears to be that rxmode.mq_mode was never set to > ETH_MQ_RX_RSS > > in testpmd.c; it=92s initialized to 0. > > You're right. Its broken since the commit "ETH_MQ_RX_NONE should > disable RSS": > > http://dpdk.org/browse/dpdk/commit/?id=3D243db2ddee3094a2cb39fdd4b17e26df= 4e7735e1 > > > There should probably be a configuration for that, or should be set whe= n > > rxq > 1. > > RSS can be configured or disabled with testpmd options or commands. > So it must be fixed in 2 places: > - in app/test-pmd/parameters.c for options > - in app/test-pmd/cmdline.c for commands > When setting rss_hf, mq_mode must be set accordingly. > > Note that DCB feature can use mq_mode. > > Thanks for the report. Patch is welcome :) > -- > Thomas >