From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rsanford2@gmail.com>
Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com
 [209.85.217.170]) by dpdk.org (Postfix) with ESMTP id 7F5C8AFD1
 for <dev@dpdk.org>; Tue, 17 Jun 2014 18:28:50 +0200 (CEST)
Received: by mail-lb0-f170.google.com with SMTP id 10so3086176lbg.29
 for <dev@dpdk.org>; Tue, 17 Jun 2014 09:29:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=/BOYwOQvuuU/cc7hV2a9itfPFybAWM3fdWnvdEKh7nU=;
 b=JU/U6U887lLjZ6adt6Zovp/sgrg1aimmIXuZsw4LlxN1SFaAr/HORig4alA/9EE35S
 2gCOU35GFmDsIsyK3p7iJHVf9RlK/6WXbk5a1g4mY83YHg6Sgg9laPfE+r9RbRYFp35V
 D3jp74DSDajRJHtlH3XxdYEtzaYmtCpVIEKF2+vq/ghu+4ajB+nQcrsQJsRk/XCfjcQx
 HqIECMm4yeBcD6xNdMI4w9XEc8vs3vWFZJs6jesG89KBOv3UUzhFcWZBZ+xWCzfhhC8d
 ve+kBf6+75kJGTe7M6SQ9M5PrGaFPlKZbTs6Ffzx/x7SOt1XJ3oyhM/1u5JSv2cAwLzW
 WWlA==
MIME-Version: 1.0
X-Received: by 10.152.23.233 with SMTP id p9mr19564572laf.31.1403022546347;
 Tue, 17 Jun 2014 09:29:06 -0700 (PDT)
Received: by 10.152.112.134 with HTTP; Tue, 17 Jun 2014 09:29:06 -0700 (PDT)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D897082CBA0C@IRSMSX103.ger.corp.intel.com>
References: <1400245141-10938-1-git-send-email-rsanford2@gmail.com>
 <E115CCD9D858EF4F90C690B0DCB4D897082CBA0C@IRSMSX103.ger.corp.intel.com>
Date: Tue, 17 Jun 2014 12:29:06 -0400
Message-ID: <CA+cr1coP3a6KRBiZwVY20vP_GBsHc=pSqy+NiPsN9y525rTcPQ@mail.gmail.com>
From: Robert Sanford <rsanford2@gmail.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] malloc: fix malloc and free linear
	complexity
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jun 2014 16:28:50 -0000

Hi Pablo,

> Overall patch looks OK, but malloc unit tests fail on the last test
(test_multi_alloc_statistics).
> Apparently, the biggest free chunk size changes as it allocates some
memory, whereas in
> the previous implementation, this size did not change. I wonder if unit
test is wrong or if there
> is actually an issue here. Could you look at this as well?

Thanks for your comments. Yes, I will investigate problems with the malloc
unit tests.

BTW, I intend to make one other adjustment to the previous (v2) set of
changes:

--- a/lib/librte_malloc/malloc_elem.c
+++ b/lib/librte_malloc/malloc_elem.c
@@ -143,7 +143,7 @@ split_elem(struct malloc_elem *elem, struct malloc_elem
*split_pt)
 size_t
 malloc_elem_free_list_index(size_t size)
 {
-#define MALLOC_MINSIZE_LOG2   7
+#define MALLOC_MINSIZE_LOG2   8
 #define MALLOC_LOG2_INCREMENT 2

--
Robert