[PATCH] lib/hash: setting the maximum reclamation size

[PATCH] lib/hash: setting the maximum reclamation size

[Abdullah Ömer Yamaç]

In the previous implementation, the maximum reclamation size was set
to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
uses the configuration argument to set the maximum reclamation size.

Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
Cc: dharmik.thakkar@arm.com
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: Yipeng Wang <yipeng1.wang@intel.com>
Cc: Sameh Gobriel <sameh.gobriel@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
---
 lib/hash/rte_cuckoo_hash.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 4a44aadd9a..6d80793164 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg)
 		if (params.size == 0)
 			params.size = total_entries;
 		params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
+		params.max_reclaim_size = cfg->max_reclaim_size;
 		if (params.max_reclaim_size == 0)
 			params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX;
 		params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
-- 
2.34.1

Re: [PATCH] lib/hash: setting the maximum reclamation size

[Abdullah Ömer Yamaç]

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

Hello,
Any comment on this patch?

On Wed, Apr 17, 2024 at 4:39 PM Abdullah Ömer Yamaç <aomeryamac@gmail.com>
wrote:

> In the previous implementation, the maximum reclamation size was set
> to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
> uses the configuration argument to set the maximum reclamation size.
>
> Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
> Cc: dharmik.thakkar@arm.com
> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Cc: Yipeng Wang <yipeng1.wang@intel.com>
> Cc: Sameh Gobriel <sameh.gobriel@intel.com>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>
> Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
> ---
>  lib/hash/rte_cuckoo_hash.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> index 4a44aadd9a..6d80793164 100644
> --- a/lib/hash/rte_cuckoo_hash.c
> +++ b/lib/hash/rte_cuckoo_hash.c
> @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct
> rte_hash_rcu_config *cfg)
>                 if (params.size == 0)
>                         params.size = total_entries;
>                 params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
> +               params.max_reclaim_size = cfg->max_reclaim_size;
>                 if (params.max_reclaim_size == 0)
>                         params.max_reclaim_size =
> RTE_HASH_RCU_DQ_RECLAIM_MAX;
>                 params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
> --
> 2.34.1
>
>

[-- Attachment #2: Type: text/html, Size: 2511 bytes --]

Re: [PATCH] lib/hash: setting the maximum reclamation size

[Abdullah Ömer Yamaç]

[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]

Hello,
Is there any comment on this patch?

On Tue, Apr 23, 2024 at 4:51 PM Abdullah Ömer Yamaç <aomeryamac@gmail.com>
wrote:

> Hello,
> Any comment on this patch?
>
> On Wed, Apr 17, 2024 at 4:39 PM Abdullah Ömer Yamaç <aomeryamac@gmail.com>
> wrote:
>
>> In the previous implementation, the maximum reclamation size was set
>> to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
>> uses the configuration argument to set the maximum reclamation size.
>>
>> Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
>> Cc: dharmik.thakkar@arm.com
>> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Cc: Yipeng Wang <yipeng1.wang@intel.com>
>> Cc: Sameh Gobriel <sameh.gobriel@intel.com>
>> Cc: Bruce Richardson <bruce.richardson@intel.com>
>> Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>>
>> Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
>> ---
>>  lib/hash/rte_cuckoo_hash.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
>> index 4a44aadd9a..6d80793164 100644
>> --- a/lib/hash/rte_cuckoo_hash.c
>> +++ b/lib/hash/rte_cuckoo_hash.c
>> @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct
>> rte_hash_rcu_config *cfg)
>>                 if (params.size == 0)
>>                         params.size = total_entries;
>>                 params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
>> +               params.max_reclaim_size = cfg->max_reclaim_size;
>>                 if (params.max_reclaim_size == 0)
>>                         params.max_reclaim_size =
>> RTE_HASH_RCU_DQ_RECLAIM_MAX;
>>                 params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
>> --
>> 2.34.1
>>
>>

[-- Attachment #2: Type: text/html, Size: 2941 bytes --]

Re: [PATCH] lib/hash: setting the maximum reclamation size

[Honnappa Nagarahalli]

Hi Abdullah,
	Few comments inline

> On Apr 17, 2024, at 8:39 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote:
> 
> In the previous implementation, the maximum reclamation size was set
> to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
> uses the configuration argument to set the maximum reclamation size.
Nit. This can be as follows:
“Set the maximum reclamation size to user provided value”

> 
> Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
> Cc: dharmik.thakkar@arm.com
> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Cc: Yipeng Wang <yipeng1.wang@intel.com>
> Cc: Sameh Gobriel <sameh.gobriel@intel.com>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Please add:
stable@dpdk.org to the Cc list

> 
> Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
> ---
> lib/hash/rte_cuckoo_hash.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> index 4a44aadd9a..6d80793164 100644
> --- a/lib/hash/rte_cuckoo_hash.c
> +++ b/lib/hash/rte_cuckoo_hash.c
> @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg)
> if (params.size == 0)
> params.size = total_entries;
> params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
> + params.max_reclaim_size = cfg->max_reclaim_size;
> if (params.max_reclaim_size == 0)
> params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX;
> params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
> -- 
> 2.34.1
> 

[PATCH v2] lib/hash: Set the maximum reclamation size to user provided value

[Abdullah Ömer Yamaç]

In the previous implementation, the maximum reclamation size was set
to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
uses the configuration argument to set the maximum reclamation size.

Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
Cc: dharmik.thakkar@arm.com
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: Yipeng Wang <yipeng1.wang@intel.com>
Cc: Sameh Gobriel <sameh.gobriel@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
---
 lib/hash/rte_cuckoo_hash.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 9cf94645f6..f7f0fdfd21 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg)
 		if (params.size == 0)
 			params.size = total_entries;
 		params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
+		params.max_reclaim_size = cfg->max_reclaim_size;
 		if (params.max_reclaim_size == 0)
 			params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX;
 		params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
-- 
2.34.1

Re: [PATCH v2] lib/hash: Set the maximum reclamation size to user provided value

[Honnappa Nagarahalli]

Hi Abdullah,
	I do not see the changes I suggested in this version.

> On May 13, 2024, at 5:00 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote:
> 
> In the previous implementation, the maximum reclamation size was set
> to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
> uses the configuration argument to set the maximum reclamation size.
> 
> Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
> Cc: dharmik.thakkar@arm.com
> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Cc: Yipeng Wang <yipeng1.wang@intel.com>
> Cc: Sameh Gobriel <sameh.gobriel@intel.com>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> 
> Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
> ---
> lib/hash/rte_cuckoo_hash.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> index 9cf94645f6..f7f0fdfd21 100644
> --- a/lib/hash/rte_cuckoo_hash.c
> +++ b/lib/hash/rte_cuckoo_hash.c
> @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg)
> if (params.size == 0)
> params.size = total_entries;
> params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
> + params.max_reclaim_size = cfg->max_reclaim_size;
> if (params.max_reclaim_size == 0)
> params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX;
> params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
> -- 
> 2.34.1
> 

Re: [PATCH v2] lib/hash: Set the maximum reclamation size to user provided value

[Abdullah Ömer Yamaç]

[-- Attachment #1: Type: text/plain, Size: 2137 bytes --]

Hello,
I saw two comments, and the first one
" Please add:
stable@dpdk.org to the Cc list" then I added stable@dpdk.org to Cc. Would
you like me to add it to the commit?

Second one :
“Set the maximum reclamation size to user provided value”  I set this
comment to the header. I thought it was more meaningful in the header. If
you want also, I can insert it in the description part.

Do I miss something else?


On Mon, May 13, 2024 at 5:34 PM Honnappa Nagarahalli <
Honnappa.Nagarahalli@arm.com> wrote:

> Hi Abdullah,
>         I do not see the changes I suggested in this version.
>
> > On May 13, 2024, at 5:00 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com>
> wrote:
> >
> > In the previous implementation, the maximum reclamation size was set
> > to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
> > uses the configuration argument to set the maximum reclamation size.
> >
> > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
> > Cc: dharmik.thakkar@arm.com
> > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Cc: Yipeng Wang <yipeng1.wang@intel.com>
> > Cc: Sameh Gobriel <sameh.gobriel@intel.com>
> > Cc: Bruce Richardson <bruce.richardson@intel.com>
> > Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> >
> > Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
> > ---
> > lib/hash/rte_cuckoo_hash.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> > index 9cf94645f6..f7f0fdfd21 100644
> > --- a/lib/hash/rte_cuckoo_hash.c
> > +++ b/lib/hash/rte_cuckoo_hash.c
> > @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct
> rte_hash_rcu_config *cfg)
> > if (params.size == 0)
> > params.size = total_entries;
> > params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
> > + params.max_reclaim_size = cfg->max_reclaim_size;
> > if (params.max_reclaim_size == 0)
> > params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX;
> > params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
> > --
> > 2.34.1
> >
>
>

[-- Attachment #2: Type: text/html, Size: 3404 bytes --]

Re: [PATCH v2] lib/hash: Set the maximum reclamation size to user provided value

[Honnappa Nagarahalli]

> On May 13, 2024, at 10:22 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote:
> 
> Hello,
> I saw two comments, and the first one 
> " Please add:
> stable@dpdk.org to the Cc list" then I added stable@dpdk.org to Cc. Would you like me to add it to the commit?
I thought it needs to be added to the commit message as per contributing guidelines [1].

[1] https://doc.dpdk.org/guides/contributing/patches.html#patch-for-stable-releases
> 
> Second one :
> “Set the maximum reclamation size to user provided value”  I set this comment to the header. I thought it was more meaningful in the header. If you want also, I can insert it in the description part.
I meant that we should simplify the long commit message.

> 
> Do I miss something else?
> 
> 
> On Mon, May 13, 2024 at 5:34 PM Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
> Hi Abdullah,
>         I do not see the changes I suggested in this version.
> 
> > On May 13, 2024, at 5:00 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote:
> > 
> > In the previous implementation, the maximum reclamation size was set
> > to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
> > uses the configuration argument to set the maximum reclamation size.
> > 
> > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
> > Cc: dharmik.thakkar@arm.com
> > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Cc: Yipeng Wang <yipeng1.wang@intel.com>
> > Cc: Sameh Gobriel <sameh.gobriel@intel.com>
> > Cc: Bruce Richardson <bruce.richardson@intel.com>
> > Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> > 
> > Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
> > ---
> > lib/hash/rte_cuckoo_hash.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> > index 9cf94645f6..f7f0fdfd21 100644
> > --- a/lib/hash/rte_cuckoo_hash.c
> > +++ b/lib/hash/rte_cuckoo_hash.c
> > @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg)
> > if (params.size == 0)
> > params.size = total_entries;
> > params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
> > + params.max_reclaim_size = cfg->max_reclaim_size;
> > if (params.max_reclaim_size == 0)
> > params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX;
> > params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
> > -- 
> > 2.34.1
> > 
> 

[PATCH v3] lib/hash: setting the maximum reclamation size

[Abdullah Ömer Yamaç]

Set the maximum reclamation size to user provided value

Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
Cc: stable@dpdk.org
Cc: dharmik.thakkar@arm.com
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: Yipeng Wang <yipeng1.wang@intel.com>
Cc: Sameh Gobriel <sameh.gobriel@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
---
 lib/hash/rte_cuckoo_hash.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 9cf94645f6..f7f0fdfd21 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg)
 		if (params.size == 0)
 			params.size = total_entries;
 		params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
+		params.max_reclaim_size = cfg->max_reclaim_size;
 		if (params.max_reclaim_size == 0)
 			params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX;
 		params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
-- 
2.34.1

Re: [PATCH v3] lib/hash: setting the maximum reclamation size

[Honnappa Nagarahalli]

> On May 13, 2024, at 11:35 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote:
> 
> Set the maximum reclamation size to user provided value
> 
> Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
> Cc: stable@dpdk.org
> Cc: dharmik.thakkar@arm.com
> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Cc: Yipeng Wang <yipeng1.wang@intel.com>
> Cc: Sameh Gobriel <sameh.gobriel@intel.com>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> 
> Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> ---
> lib/hash/rte_cuckoo_hash.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> index 9cf94645f6..f7f0fdfd21 100644
> --- a/lib/hash/rte_cuckoo_hash.c
> +++ b/lib/hash/rte_cuckoo_hash.c
> @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg)
> if (params.size == 0)
> params.size = total_entries;
> params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
> + params.max_reclaim_size = cfg->max_reclaim_size;
> if (params.max_reclaim_size == 0)
> params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX;
> params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
> -- 
> 2.34.1
> 

Re: [PATCH v3] lib/hash: setting the maximum reclamation size

[David Marchand]

On Tue, May 14, 2024 at 10:52 PM Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com> wrote:
> > On May 13, 2024, at 11:35 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote:
> >
> > Set the maximum reclamation size to user provided value
> >
> > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Applied, thanks.


-- 
David Marchand