From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D7E24401B; Mon, 13 May 2024 17:22:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89894402F2; Mon, 13 May 2024 17:22:45 +0200 (CEST) Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by mails.dpdk.org (Postfix) with ESMTP id 62C4F402CD; Mon, 13 May 2024 17:22:44 +0200 (CEST) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-22ed075a629so2677199fac.3; Mon, 13 May 2024 08:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715613763; x=1716218563; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kJJ7V/0IJUhc5F/vChmbtoYJkGG9y2Zcqi8JWb1ewMk=; b=F0Zx9JNKcfDRsd+VxulSWuN+tW80hRKSi6BWhROJMgPZGYISEfIIEzodwHKsCqn4nj MpcMPSxuZe1R/euT7jtavQ2GNwrhpOOEoyUk+vWcQD73UVZuOJjW9MOdcD/fknErWoz/ 6fGV5HJdXuuz3fJYKQTCT1H5vGi17BfKmWZwIB+BxW9J3YI+FvwYmZQ1q0dXjYvqDXrk 9ichQg+SczRrwFag7jfoPLtNzWbPyoBfEwW+jEA5UmGJrJjYVwTQ7qUSLfSp+gqUKoAH pxWRaPIuYzHyax83i5MYbHKHWNX8+4WlPHjIsnECsoKQ1SqeREPvkiHyAZrzFFEalq66 OsjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715613763; x=1716218563; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kJJ7V/0IJUhc5F/vChmbtoYJkGG9y2Zcqi8JWb1ewMk=; b=IEAWTCYemuF68jHdnoccmC5BwR3fy3u2fNqdRjBgIaZTunX6Ok2M5gx6OrWqwUPs9F +wqcNcOCVXH4GdZDh4b/PT+paohlvQbXOJjNQCRNIFvnPGI0TK4B2Ns/7T3WrCwbvket SSi7FOMuNoyxLD98POKO6g7OmBiX8StOvnXcpaywqql4zehCLH0TJVGhPeMSKNXZIWeX ShSWkGP9FCyUKNh6Ji3luU22o09WrYiq0mBzXwXbda7l7TPIZVgCgAJXor45tM/6fpes YWPrrRdBG8PbJlT+MMU3aWJBgQAafR2aegi4YnBDKWg9jD6Q3WV8ikshLqU2wrLKbEPy kA0Q== X-Forwarded-Encrypted: i=1; AJvYcCUniQ9+XQe+uNA/24nuPiFdPb74BlAlhXE5v+dWMpveJbQehzmw1gFYTKkOmkx94f+m7ti5hLNgn4q2pCVxSUg= X-Gm-Message-State: AOJu0YyPNjIxieKodBFxS6y8AvYc4X8HjyblZqNP78P7y8TGNc5VdK/L Gv/RWXdqBzUk+8tltjevHgDL7kqJYuKCOtiWVMZ7Xqj8WlVXkgdoNu4n+EEBiTJe5nXiVSlaekQ a1qTbKOKRCgDM3mdH6iUkrsskqNk= X-Google-Smtp-Source: AGHT+IGsveNL7o7JAn7r65Wl7D6ALXibtQ0xbpGyXKoPF9tEruMnYuNT45fc8AG6U2VXAGV+W8OuNng84r18hFF7toI= X-Received: by 2002:a05:6871:8a9:b0:239:792d:c6b8 with SMTP id 586e51a60fabf-241721db58fmr12517077fac.0.1715613763430; Mon, 13 May 2024 08:22:43 -0700 (PDT) MIME-Version: 1.0 References: <396BD6B3-B936-42F3-9FA9-B07578786FE5@arm.com> <20240513100031.1156529-1-aomeryamac@gmail.com> In-Reply-To: From: =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= Date: Mon, 13 May 2024 18:22:33 +0300 Message-ID: Subject: Re: [PATCH v2] lib/hash: Set the maximum reclamation size to user provided value To: Honnappa Nagarahalli Cc: "dev@dpdk.org" , "stable@dpdk.org" , Dharmik Jayesh Thakkar , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , nd Content-Type: multipart/alternative; boundary="000000000000f0ef2b0618577404" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000f0ef2b0618577404 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I saw two comments, and the first one " Please add: stable@dpdk.org to the Cc list" then I added stable@dpdk.org to Cc. Would you like me to add it to the commit? Second one : =E2=80=9CSet the maximum reclamation size to user provided value=E2=80=9D = I set this comment to the header. I thought it was more meaningful in the header. If you want also, I can insert it in the description part. Do I miss something else? On Mon, May 13, 2024 at 5:34=E2=80=AFPM Honnappa Nagarahalli < Honnappa.Nagarahalli@arm.com> wrote: > Hi Abdullah, > I do not see the changes I suggested in this version. > > > On May 13, 2024, at 5:00=E2=80=AFAM, Abdullah =C3=96mer Yama=C3=A7 > wrote: > > > > In the previous implementation, the maximum reclamation size was set > > to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch > > uses the configuration argument to set the maximum reclamation size. > > > > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > > Cc: dharmik.thakkar@arm.com > > Cc: Honnappa Nagarahalli > > Cc: Yipeng Wang > > Cc: Sameh Gobriel > > Cc: Bruce Richardson > > Cc: Vladimir Medvedkin > > > > Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 > > --- > > lib/hash/rte_cuckoo_hash.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c > > index 9cf94645f6..f7f0fdfd21 100644 > > --- a/lib/hash/rte_cuckoo_hash.c > > +++ b/lib/hash/rte_cuckoo_hash.c > > @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct > rte_hash_rcu_config *cfg) > > if (params.size =3D=3D 0) > > params.size =3D total_entries; > > params.trigger_reclaim_limit =3D cfg->trigger_reclaim_limit; > > + params.max_reclaim_size =3D cfg->max_reclaim_size; > > if (params.max_reclaim_size =3D=3D 0) > > params.max_reclaim_size =3D RTE_HASH_RCU_DQ_RECLAIM_MAX; > > params.esize =3D sizeof(struct __rte_hash_rcu_dq_entry); > > -- > > 2.34.1 > > > > --000000000000f0ef2b0618577404 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,
I saw two comments,=C2=A0and the first one
&= quot; Please add:
stable@= dpdk.org=C2=A0to the Cc list" then I added stable@dpdk.org to Cc. Would you like me to add it to the c= ommit?

Second one :
= =E2=80=9CSet the maximum reclamation size to user provided value=E2=80=9D= =C2=A0=C2=A0I set this comment to the header. I thought it was more = meaningful in the header. If you want also, I can insert it in the descript= ion part.

Do I miss=C2=A0something else?


On Mon, May 13, 2024= at 5:34=E2=80=AFPM Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
Hi Abdullah,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 I do not see the changes I suggested in this ve= rsion.

> On May 13, 2024, at 5:00=E2=80=AFAM, Abdullah =C3=96mer Yama=C3=A7 <= ;aomeryamac@gmail= .com> wrote:
>
> In the previous implementation, the maximum reclamation size was set > to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch=
> uses the configuration argument to set the maximum reclamation size. >
> Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation&q= uot;)
> Cc: dharm= ik.thakkar@arm.com
> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Cc: Yipeng Wang <yipeng1.wang@intel.com>
> Cc: Sameh Gobriel <sameh.gobriel@intel.com>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>
> Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 <aomeryamac@gmail.com>
> ---
> lib/hash/rte_cuckoo_hash.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c > index 9cf94645f6..f7f0fdfd21 100644
> --- a/lib/hash/rte_cuckoo_hash.c
> +++ b/lib/hash/rte_cuckoo_hash.c
> @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct= rte_hash_rcu_config *cfg)
> if (params.size =3D=3D 0)
> params.size =3D total_entries;
> params.trigger_reclaim_limit =3D cfg->trigger_reclaim_limit;
> + params.max_reclaim_size =3D cfg->max_reclaim_size;
> if (params.max_reclaim_size =3D=3D 0)
> params.max_reclaim_size =3D RTE_HASH_RCU_DQ_RECLAIM_MAX;
> params.esize =3D sizeof(struct __rte_hash_rcu_dq_entry);
> --
> 2.34.1
>

--000000000000f0ef2b0618577404--