Re: [PATCH] lib/hash: setting the maximum reclamation size

["Abdullah Ömer Yamaç" <aomeryamac@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]

Hello,
Is there any comment on this patch?

On Tue, Apr 23, 2024 at 4:51 PM Abdullah Ömer Yamaç <aomeryamac@gmail.com>
wrote:

> Hello,
> Any comment on this patch?
>
> On Wed, Apr 17, 2024 at 4:39 PM Abdullah Ömer Yamaç <aomeryamac@gmail.com>
> wrote:
>
>> In the previous implementation, the maximum reclamation size was set
>> to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
>> uses the configuration argument to set the maximum reclamation size.
>>
>> Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
>> Cc: dharmik.thakkar@arm.com
>> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Cc: Yipeng Wang <yipeng1.wang@intel.com>
>> Cc: Sameh Gobriel <sameh.gobriel@intel.com>
>> Cc: Bruce Richardson <bruce.richardson@intel.com>
>> Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>>
>> Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
>> ---
>>  lib/hash/rte_cuckoo_hash.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
>> index 4a44aadd9a..6d80793164 100644
>> --- a/lib/hash/rte_cuckoo_hash.c
>> +++ b/lib/hash/rte_cuckoo_hash.c
>> @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct
>> rte_hash_rcu_config *cfg)
>>                 if (params.size == 0)
>>                         params.size = total_entries;
>>                 params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
>> +               params.max_reclaim_size = cfg->max_reclaim_size;
>>                 if (params.max_reclaim_size == 0)
>>                         params.max_reclaim_size =
>> RTE_HASH_RCU_DQ_RECLAIM_MAX;
>>                 params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
>> --
>> 2.34.1
>>
>>

[-- Attachment #2: Type: text/html, Size: 2941 bytes --]