From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E78843EEA; Tue, 23 Apr 2024 15:52:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5DDFD42EE8; Tue, 23 Apr 2024 15:52:12 +0200 (CEST) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by mails.dpdk.org (Postfix) with ESMTP id C34E8402D5 for ; Tue, 23 Apr 2024 15:52:10 +0200 (CEST) Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6eb77e56b20so3542747a34.3 for ; Tue, 23 Apr 2024 06:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713880330; x=1714485130; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nXxYlwM5QoLjsU8ku08m4dp7KgSQ6+CTkA08I+BbX4k=; b=nqhJnUSRMcgDIMK1Cc2JkML8yi2G5rSLBB5+psWVvZ8G+OGXILJ3HFOInZ8FwVwe0Q 4C2O8DlM8HxlelEDbpSq7x3Jw1wo/GOxZCVuFPSwCmdBBbJbgukV3HUF9a9M49zumByU /LHKmu2BhBYwI8WJsBw2loT7hAK9RYbJ+PGEfzPsm8LMLMsmzmUFHq8I8gmhtxCReZRw 2xSBwrJTEjShLyN7sZmFFAWGMRlVlALkrrlwRWHARA8Y3Gc8BetC3mn2yRfKKmUzB9YR NnLvpIXw0vZTre/NzOafNZLv34J2ABDUdOAtJ/zkvSonpcK6eKc7o+vIK1pQ5OVzkWKo ABAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713880330; x=1714485130; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nXxYlwM5QoLjsU8ku08m4dp7KgSQ6+CTkA08I+BbX4k=; b=TvcHe+ZZ46Ycx/Lcs+uajhBzDPRzeeCibUN1akQyKSo31yKUqV678gAlP38hljvjNy 1NfMT4a3EeJwHSYCztkrKrE3lXyR+kVeUrWFVjd1qDrN1G31RhL/OrYbKlvJ26QCcVPv ygY+c0rhtrcijy8WVKv0vE2BmJ50OUTtCUc9mlodSnxOCsUfAiG9Ke1kCyffsP15q9rN qpQDjZN7Ayg6PjCii4kGcgjAJV5cg7g9+f+RfFDKD9PZcdzDCSointflMBVwCfaS72n7 HT4zcYLXIh+GlVjW9xHQmXGd383wKf5Kx0JQ/DHPPysQzbuCLvnqEMLcAZT3IyzR4/GJ PdTw== X-Gm-Message-State: AOJu0Yzj36Fo3txwgq4kUg7lnTpApUkDLj04wO5FcuIpTDBCNoXeR5yS 80AvlSyz7PREQQwmuJoJ1mqjWIE5lWuS7w7Q7dNeY7k3K3Us+tJjz3MQKKSsa9r/wbedg/ssOwt ar4RHznxjR2zIjLIriQuaoEcEPDy6Mvn/t54= X-Google-Smtp-Source: AGHT+IHQFHzN42jyvsu+fBe/rscPfGpRT5l4HPhIuUbzUGZnotcZGPZeoX3PxN0/15RRqLqt5LWcfQtqmrvZ3GFrSU8= X-Received: by 2002:a05:6870:c184:b0:22a:bdd7:7b3b with SMTP id h4-20020a056870c18400b0022abdd77b3bmr16370497oad.11.1713880329723; Tue, 23 Apr 2024 06:52:09 -0700 (PDT) MIME-Version: 1.0 References: <20240417133929.711268-1-aomeryamac@gmail.com> In-Reply-To: <20240417133929.711268-1-aomeryamac@gmail.com> From: =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= Date: Tue, 23 Apr 2024 16:51:58 +0300 Message-ID: Subject: Re: [PATCH] lib/hash: setting the maximum reclamation size To: dev@dpdk.org Cc: dharmik.thakkar@arm.com, Honnappa Nagarahalli , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Thomas Monjalon Content-Type: multipart/alternative; boundary="0000000000003da57b0616c3dc6a" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000003da57b0616c3dc6a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, Any comment on this patch? On Wed, Apr 17, 2024 at 4:39=E2=80=AFPM Abdullah =C3=96mer Yama=C3=A7 wrote: > In the previous implementation, the maximum reclamation size was set > to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch > uses the configuration argument to set the maximum reclamation size. > > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > Cc: dharmik.thakkar@arm.com > Cc: Honnappa Nagarahalli > Cc: Yipeng Wang > Cc: Sameh Gobriel > Cc: Bruce Richardson > Cc: Vladimir Medvedkin > > Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 > --- > lib/hash/rte_cuckoo_hash.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c > index 4a44aadd9a..6d80793164 100644 > --- a/lib/hash/rte_cuckoo_hash.c > +++ b/lib/hash/rte_cuckoo_hash.c > @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct > rte_hash_rcu_config *cfg) > if (params.size =3D=3D 0) > params.size =3D total_entries; > params.trigger_reclaim_limit =3D cfg->trigger_reclaim_lim= it; > + params.max_reclaim_size =3D cfg->max_reclaim_size; > if (params.max_reclaim_size =3D=3D 0) > params.max_reclaim_size =3D > RTE_HASH_RCU_DQ_RECLAIM_MAX; > params.esize =3D sizeof(struct __rte_hash_rcu_dq_entry); > -- > 2.34.1 > > --0000000000003da57b0616c3dc6a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,
Any comment on this patch?

On Wed, Apr 17, 2024= at 4:39=E2=80=AFPM Abdullah =C3=96mer Yama=C3=A7 <aomeryamac@gmail.com> wrote:
In the previous implementation, the = maximum reclamation size was set
to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
uses the configuration argument to set the maximum reclamation size.

Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")=
Cc: dharmik.th= akkar@arm.com
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: Yipeng Wang <yipeng1.wang@intel.com>
Cc: Sameh Gobriel <sameh.gobriel@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 <aomeryamac@gmail.com>
---
=C2=A0lib/hash/rte_cuckoo_hash.c | 1 +
=C2=A01 file changed, 1 insertion(+)

diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 4a44aadd9a..6d80793164 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_= hash_rcu_config *cfg)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (params.size =3D= =3D 0)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 params.size =3D total_entries;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 params.trigger_recl= aim_limit =3D cfg->trigger_reclaim_limit;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0params.max_reclaim_= size =3D cfg->max_reclaim_size;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (params.max_recl= aim_size =3D=3D 0)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 params.max_reclaim_size =3D RTE_HASH_RCU_DQ_RECLAIM_MAX;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 params.esize =3D si= zeof(struct __rte_hash_rcu_dq_entry);
--
2.34.1

--0000000000003da57b0616c3dc6a--