From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D2A327CB0 for ; Thu, 1 Nov 2018 22:16:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2018 14:16:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,453,1534834800"; d="scan'208";a="100762701" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 01 Nov 2018 14:16:19 -0700 Received: from hasmsx112.ger.corp.intel.com (10.184.198.40) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 1 Nov 2018 14:16:19 -0700 Received: from hasmsx111.ger.corp.intel.com ([169.254.5.134]) by HASMSX112.ger.corp.intel.com ([169.254.11.97]) with mapi id 14.03.0415.000; Thu, 1 Nov 2018 23:16:16 +0200 From: "Jozwiak, TomaszX" To: "Trahe, Fiona" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "akhil.goyal@nxp.com" , "jerin.jacob@caviumnetworks.com" Thread-Topic: [PATCH] compress/qat: fix out-of-bounds error Thread-Index: AQHUcLJFFR9eMXr1ak+ZTAyr+XeO5qU7bqpA Date: Thu, 1 Nov 2018 21:16:16 +0000 Message-ID: References: <20181027164739.13110-1-jerin.jacob@caviumnetworks.com> <1540946394-22196-1-git-send-email-fiona.trahe@intel.com> In-Reply-To: <1540946394-22196-1-git-send-email-fiona.trahe@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.104.12.169] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] compress/qat: fix out-of-bounds error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 21:16:22 -0000 > -----Original Message----- > From: Trahe, Fiona > Sent: Wednesday, October 31, 2018 1:40 AM > To: dev@dpdk.org > Cc: thomas@monjalon.net; akhil.goyal@nxp.com; Jozwiak, TomaszX > ; jerin.jacob@caviumnetworks.com; Trahe, > Fiona > Subject: [PATCH] compress/qat: fix out-of-bounds error >=20 > QAT array for sgls in intermediate buffer structure was #defined to 1, bu= t > setup code hardcoded as if 2 buffers so causing out of bounds write. > Reworked to loop correctly using #define. >=20 > Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") >=20 > Reported-by: Jerin Jacob > Signed-off-by: Fiona Trahe > --- Acked-by: Tomasz Jozwiak