From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomaszx.jozwiak@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id A32B21BB78
 for <dev@dpdk.org>; Fri, 19 Apr 2019 13:36:35 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 19 Apr 2019 04:36:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,369,1549958400"; d="scan'208";a="163276951"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by fmsmga004.fm.intel.com with ESMTP; 19 Apr 2019 04:36:34 -0700
Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Fri, 19 Apr 2019 04:36:34 -0700
Received: from lcsmsx154.ger.corp.intel.com (10.186.165.229) by
 fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Fri, 19 Apr 2019 04:36:34 -0700
Received: from lcsmsx155.ger.corp.intel.com ([169.254.12.133]) by
 LCSMSX154.ger.corp.intel.com ([169.254.7.104]) with mapi id 14.03.0415.000;
 Fri, 19 Apr 2019 14:36:31 +0300
From: "Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, "david.marchand@redhat.com"
 <david.marchand@redhat.com>, "Trahe, Fiona" <fiona.trahe@intel.com>,
 "yskoh@mellanox.com" <yskoh@mellanox.com>, "Cel, TomaszX"
 <tomaszx.cel@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
Thread-Index: AQHU9pZEG/ACPPULwUOU2+C9yH5iRqZDErQAgAA5veD//9lnAIAANP8w
Date: Fri, 19 Apr 2019 11:36:30 +0000
Message-ID: <CA70B6012E3ADB4184D44E025E5FF01B6A20B909@LCSMSX155.ger.corp.intel.com>
References: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com>
 <4602312.zkvPNgCjdN@xps>
 <CA70B6012E3ADB4184D44E025E5FF01B6A20A888@LCSMSX155.ger.corp.intel.com>
 <3955282.IgHOaonqCx@xps>
In-Reply-To: <3955282.IgHOaonqCx@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTI1NTRjMTktYTZmOS00MmM2LThlOGItZjEwZjU3YTNmYTQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOWtEOThPZmNJTnRGTUt4V0dVbmdQVzdUVDJwUkl6bVkzU2VEVm1xQzYzdGNPY0FBMklzY1AzUmF5SnlCbEdqUSJ9
x-originating-ip: [10.103.104.44]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Apr 2019 11:36:36 -0000

test_deflate_comp_decomp function is common for all test cases.
The options for this function are inside struct interim_data_params,
which is passed to test_deflate_comp_decomp function as a pointer.

The field buf_idx should be initialized  because is used inside test_deflat=
e_comp_decomp
That's the reason of:
	int_data.buf_idx =3D &i;

I'm not an author of this solution - sorry.=20

We can review this and try to add new solution.

Thx, Tomek

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, April 19, 2019 1:26 PM
> To: Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>;
> david.marchand@redhat.com; Trahe, Fiona <fiona.trahe@intel.com>;
> yskoh@mellanox.com; Cel, TomaszX <tomaszx.cel@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test cas=
e
>=20
> 19/04/2019 12:57, Jozwiak, TomaszX:
> > > What is supposed to be "i"?
> > > It is initialized at 0 and never touched.
> > >
> > It's touched inside test_deflate_comp_decomp function.
>=20
> What do you mean?
> It's a local variable and its address is referenced:
> 	int_data.buf_idx =3D &i;
> It looks really wrong.
>=20
> Another error is seen in FreeBSD.
>=20
> Should I totally revert this patch?
>=20
>=20

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id BD784A00E6
	for <public@inbox.dpdk.org>; Fri, 19 Apr 2019 13:36:37 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 580721BBE3;
	Fri, 19 Apr 2019 13:36:37 +0200 (CEST)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id A32B21BB78
 for <dev@dpdk.org>; Fri, 19 Apr 2019 13:36:35 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 19 Apr 2019 04:36:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,369,1549958400"; d="scan'208";a="163276951"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by fmsmga004.fm.intel.com with ESMTP; 19 Apr 2019 04:36:34 -0700
Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Fri, 19 Apr 2019 04:36:34 -0700
Received: from lcsmsx154.ger.corp.intel.com (10.186.165.229) by
 fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Fri, 19 Apr 2019 04:36:34 -0700
Received: from lcsmsx155.ger.corp.intel.com ([169.254.12.133]) by
 LCSMSX154.ger.corp.intel.com ([169.254.7.104]) with mapi id 14.03.0415.000;
 Fri, 19 Apr 2019 14:36:31 +0300
From: "Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, "david.marchand@redhat.com"
 <david.marchand@redhat.com>, "Trahe, Fiona" <fiona.trahe@intel.com>,
 "yskoh@mellanox.com" <yskoh@mellanox.com>, "Cel, TomaszX"
 <tomaszx.cel@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
Thread-Index: AQHU9pZEG/ACPPULwUOU2+C9yH5iRqZDErQAgAA5veD//9lnAIAANP8w
Date: Fri, 19 Apr 2019 11:36:30 +0000
Message-ID:
 <CA70B6012E3ADB4184D44E025E5FF01B6A20B909@LCSMSX155.ger.corp.intel.com>
References: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com>
 <4602312.zkvPNgCjdN@xps>
 <CA70B6012E3ADB4184D44E025E5FF01B6A20A888@LCSMSX155.ger.corp.intel.com>
 <3955282.IgHOaonqCx@xps>
In-Reply-To: <3955282.IgHOaonqCx@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTI1NTRjMTktYTZmOS00MmM2LThlOGItZjEwZjU3YTNmYTQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOWtEOThPZmNJTnRGTUt4V0dVbmdQVzdUVDJwUkl6bVkzU2VEVm1xQzYzdGNPY0FBMklzY1AzUmF5SnlCbEdqUSJ9
x-originating-ip: [10.103.104.44]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190419113630.xwTVXcjeR1cyJ87BiSxRyTbjjhA7PV4IhM4zgepurCc@z>

test_deflate_comp_decomp function is common for all test cases.
The options for this function are inside struct interim_data_params,
which is passed to test_deflate_comp_decomp function as a pointer.

The field buf_idx should be initialized  because is used inside test_deflat=
e_comp_decomp
That's the reason of:
	int_data.buf_idx =3D &i;

I'm not an author of this solution - sorry.=20

We can review this and try to add new solution.

Thx, Tomek

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, April 19, 2019 1:26 PM
> To: Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>;
> david.marchand@redhat.com; Trahe, Fiona <fiona.trahe@intel.com>;
> yskoh@mellanox.com; Cel, TomaszX <tomaszx.cel@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test cas=
e
>=20
> 19/04/2019 12:57, Jozwiak, TomaszX:
> > > What is supposed to be "i"?
> > > It is initialized at 0 and never touched.
> > >
> > It's touched inside test_deflate_comp_decomp function.
>=20
> What do you mean?
> It's a local variable and its address is referenced:
> 	int_data.buf_idx =3D &i;
> It looks really wrong.
>=20
> Another error is seen in FreeBSD.
>=20
> Should I totally revert this patch?
>=20
>=20