From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id E0F781B5B2 for ; Fri, 19 Apr 2019 14:14:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2019 05:14:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,369,1549958400"; d="scan'208";a="224909230" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 19 Apr 2019 05:14:19 -0700 Received: from lcsmsx153.ger.corp.intel.com (10.186.165.228) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 19 Apr 2019 05:14:19 -0700 Received: from lcsmsx155.ger.corp.intel.com ([169.254.12.133]) by LCSMSX153.ger.corp.intel.com ([169.254.8.148]) with mapi id 14.03.0415.000; Fri, 19 Apr 2019 15:14:17 +0300 From: "Jozwiak, TomaszX" To: Thomas Monjalon CC: "dev@dpdk.org" , "Richardson, Bruce" , "david.marchand@redhat.com" , "Trahe, Fiona" , "yskoh@mellanox.com" , "Cel, TomaszX" Thread-Topic: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case Thread-Index: AQHU9pZEG/ACPPULwUOU2+C9yH5iRqZDErQAgAA5veD//9lnAIAANP8w///R1oCAADYT8A== Date: Fri, 19 Apr 2019 12:14:16 +0000 Message-ID: References: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com> <3955282.IgHOaonqCx@xps> <1749599.B640tvC1p7@xps> In-Reply-To: <1749599.B640tvC1p7@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmE3MDI5OGYtMThjMi00N2RmLTllZDAtNTM4ODg5Y2ZkZTU2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY1liRHozU2Z2OUZ2N2tUNmNcL1NoazNRZmk2ZlFGOU40SmZFUFdwQytQV1JJbjVubVhTWE5iK1ErcnBOSWVDTjcifQ== x-originating-ip: [10.103.104.44] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 12:14:21 -0000 > Moreover I don't know how the pointer of a local variable can be used. That usage is in all test cases in this file - so probably should be fixed = first. May be I'm not an expert but what's wrong with usage of a pointer of local = variable inside the function? > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, April 19, 2019 1:50 PM > To: Jozwiak, TomaszX > Cc: dev@dpdk.org; Richardson, Bruce ; > david.marchand@redhat.com; Trahe, Fiona ; > yskoh@mellanox.com; Cel, TomaszX > Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test cas= e >=20 > Please stop top-posting, and read again below: >=20 > 19/04/2019 13:36, Jozwiak, TomaszX: > > test_deflate_comp_decomp function is common for all test cases. > > The options for this function are inside struct interim_data_params, > > which is passed to test_deflate_comp_decomp function as a pointer. > > > > The field buf_idx should be initialized because is used inside > > test_deflate_comp_decomp That's the reason of: > > int_data.buf_idx =3D &i; > > > > I'm not an author of this solution - sorry. > > > > We can review this and try to add new solution. >=20 > I am not talking about int_data but the use of "i". > Please look again your patch, you are using "j" instead of "i" > and "i" is kept alone. > Moreover I don't know how the pointer of a local variable can be used. >=20 >=20 > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 19/04/2019 12:57, Jozwiak, TomaszX: > > > > > What is supposed to be "i"? > > > > > It is initialized at 0 and never touched. > > > > > > > > > It's touched inside test_deflate_comp_decomp function. > > > > > > What do you mean? > > > It's a local variable and its address is referenced: > > > int_data.buf_idx =3D &i; > > > It looks really wrong. > > > > > > Another error is seen in FreeBSD. > > > > > > Should I totally revert this patch? >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 81664A00E6 for ; Fri, 19 Apr 2019 14:14:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C6151BBF5; Fri, 19 Apr 2019 14:14:23 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id E0F781B5B2 for ; Fri, 19 Apr 2019 14:14:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2019 05:14:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,369,1549958400"; d="scan'208";a="224909230" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 19 Apr 2019 05:14:19 -0700 Received: from lcsmsx153.ger.corp.intel.com (10.186.165.228) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 19 Apr 2019 05:14:19 -0700 Received: from lcsmsx155.ger.corp.intel.com ([169.254.12.133]) by LCSMSX153.ger.corp.intel.com ([169.254.8.148]) with mapi id 14.03.0415.000; Fri, 19 Apr 2019 15:14:17 +0300 From: "Jozwiak, TomaszX" To: Thomas Monjalon CC: "dev@dpdk.org" , "Richardson, Bruce" , "david.marchand@redhat.com" , "Trahe, Fiona" , "yskoh@mellanox.com" , "Cel, TomaszX" Thread-Topic: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case Thread-Index: AQHU9pZEG/ACPPULwUOU2+C9yH5iRqZDErQAgAA5veD//9lnAIAANP8w///R1oCAADYT8A== Date: Fri, 19 Apr 2019 12:14:16 +0000 Message-ID: References: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com> <3955282.IgHOaonqCx@xps> <1749599.B640tvC1p7@xps> In-Reply-To: <1749599.B640tvC1p7@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmE3MDI5OGYtMThjMi00N2RmLTllZDAtNTM4ODg5Y2ZkZTU2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY1liRHozU2Z2OUZ2N2tUNmNcL1NoazNRZmk2ZlFGOU40SmZFUFdwQytQV1JJbjVubVhTWE5iK1ErcnBOSWVDTjcifQ== x-originating-ip: [10.103.104.44] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419121416.dNEFNV_R_5SYp6160r2WH01k4P1HUXbqX3fLAeuHIKw@z> > Moreover I don't know how the pointer of a local variable can be used. That usage is in all test cases in this file - so probably should be fixed = first. May be I'm not an expert but what's wrong with usage of a pointer of local = variable inside the function? > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, April 19, 2019 1:50 PM > To: Jozwiak, TomaszX > Cc: dev@dpdk.org; Richardson, Bruce ; > david.marchand@redhat.com; Trahe, Fiona ; > yskoh@mellanox.com; Cel, TomaszX > Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test cas= e >=20 > Please stop top-posting, and read again below: >=20 > 19/04/2019 13:36, Jozwiak, TomaszX: > > test_deflate_comp_decomp function is common for all test cases. > > The options for this function are inside struct interim_data_params, > > which is passed to test_deflate_comp_decomp function as a pointer. > > > > The field buf_idx should be initialized because is used inside > > test_deflate_comp_decomp That's the reason of: > > int_data.buf_idx =3D &i; > > > > I'm not an author of this solution - sorry. > > > > We can review this and try to add new solution. >=20 > I am not talking about int_data but the use of "i". > Please look again your patch, you are using "j" instead of "i" > and "i" is kept alone. > Moreover I don't know how the pointer of a local variable can be used. >=20 >=20 > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 19/04/2019 12:57, Jozwiak, TomaszX: > > > > > What is supposed to be "i"? > > > > > It is initialized at 0 and never touched. > > > > > > > > > It's touched inside test_deflate_comp_decomp function. > > > > > > What do you mean? > > > It's a local variable and its address is referenced: > > > int_data.buf_idx =3D &i; > > > It looks really wrong. > > > > > > Another error is seen in FreeBSD. > > > > > > Should I totally revert this patch? >=20 >=20