From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A8CEFA05D3 for ; Mon, 20 May 2019 16:25:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E62BD568A; Mon, 20 May 2019 16:25:33 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D9E0C37B7; Mon, 20 May 2019 16:25:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 May 2019 07:25:30 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 20 May 2019 07:25:30 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 20 May 2019 07:25:29 -0700 Received: from hasmsx106.ger.corp.intel.com (10.184.198.20) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 20 May 2019 07:25:29 -0700 Received: from hasmsx114.ger.corp.intel.com ([169.254.14.203]) by HASMSX106.ger.corp.intel.com ([169.254.10.221]) with mapi id 14.03.0415.000; Mon, 20 May 2019 17:25:27 +0300 From: "Jozwiak, TomaszX" To: "Trahe, Fiona" , "dev@dpdk.org" , "shallyv@marvell.com" , "stable@dpdk.org" CC: "Trybula, ArturX" Thread-Topic: [PATCH] app/test-compress-perf: fix reliance on integer endianness Thread-Index: AQHVDw+aaMHaQh/V2k+hP4D+ghNizqZz2d0AgAA1fbA= Date: Mon, 20 May 2019 14:25:26 +0000 Message-ID: References: <1558358764-32053-1-git-send-email-tomaszx.jozwiak@intel.com> <1558358764-32053-2-git-send-email-tomaszx.jozwiak@intel.com> <348A99DA5F5B7549AA880327E580B4358976C60C@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B4358976C60C@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDFkZmFjN2ItZGVkYi00YmIzLTlhM2EtNjZhYTUzOGZlZDhmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiamx1M2h1MUhVemdHbTFlVVwvamFkZ0lRVWNuc0huV040NDFhemlLdVpMTEZPYXNZOURNZnZCSDFVRWN6SXBTbU0ifQ== x-originating-ip: [10.184.70.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fiona, > -----Original Message----- > From: Trahe, Fiona > Sent: Monday, May 20, 2019 4:06 PM > To: Jozwiak, TomaszX ; dev@dpdk.org; > shallyv@marvell.com; stable@dpdk.org > Cc: Trahe, Fiona ; Trybula, ArturX > > Subject: RE: [PATCH] app/test-compress-perf: fix reliance on integer > endianness >=20 > HI Tomasz, >=20 > > -----Original Message----- > > From: Jozwiak, TomaszX > > Sent: Monday, May 20, 2019 2:26 PM > > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, > > TomaszX ; shallyv@marvell.com; > > stable@dpdk.org > > Subject: [PATCH] app/test-compress-perf: fix reliance on integer > > endianness > > > > This patch fixes coverity issue: > > Reliance on integer endianness (INCOMPATIBLE_CAST) in > parse_window_sz > > function. > > > > Coverity issue: 328524 > > Fixes: e0b6287c035d ("app/compress-perf: add parser") > > Cc: stable@dpdk.org > > > > Signed-off-by: Tomasz Jozwiak > > --- > > app/test-compress-perf/comp_perf_options_parse.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-compress-perf/comp_perf_options_parse.c > > b/app/test-compress- perf/comp_perf_options_parse.c index > > 2fb6fb4..56ca580 100644 > > --- a/app/test-compress-perf/comp_perf_options_parse.c > > +++ b/app/test-compress-perf/comp_perf_options_parse.c > > @@ -364,13 +364,15 @@ parse_max_num_sgl_segs(struct > comp_test_data > > *test_data, const char *arg) static int parse_window_sz(struct > > comp_test_data *test_data, const char *arg) { > > - int ret =3D parse_uint16_t((uint16_t *)&test_data->window_sz, arg); > > + uint16_t tmp; > > + int ret =3D parse_uint16_t(&tmp, arg); > > > > if (ret) { > > RTE_LOG(ERR, USER1, "Failed to parse window size\n"); > > return -1; > > } > > > > + test_data->window_sz =3D (int)tmp; > > return 0; > > } > [Fiona] I expect this fixes this coverity issue - but will it result in a= nother one? > window_sz on the xform is uint8_t - so this int will get truncated later,= and > there's no cast done at that point. > Would it be better to add a new parse_uint8_t fn and change test-data- > >window_sz to a unit8_t? > Or add that cast? > [Tomek] I measn it's ok. There's a check inside comp_perf_check_capabilit= ies function. If the value from test_data->window_sz > cap->window_size we = have a fail. Also during parsing there's a check is value from command line= is between 0 and UINT16_MAX, so in my opinion all cases are tested. The po= int is there's only one place where we're parsing uint8_t value. parse_uin= t8_t function will be especially for that.