DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luke Gorrie <luke@snabb.co>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] Possible bug in mlx5_tx_burst_mpw?
Date: Wed, 14 Sep 2016 15:24:07 +0200	[thread overview]
Message-ID: <CAA2XHbd+c2vuFKu7CivDkAG+1KEhq28yKd+-GsJjMVukS-2CxA@mail.gmail.com> (raw)

Howdy,

Just noticed a line of code that struck me as odd and so I am writing just
in case it is a bug:

http://dpdk.org/browse/dpdk/tree/drivers/net/mlx5/mlx5_rxtx.c#n1014

Specifically the check "(mpw.length != length)" in mlx_tx_burst_mpw() looks
like a descriptor-format optimization for the special case where
consecutive packets on the wire are exactly the same size. This would
strike me as peculiar.

Just wanted to check, is that interpretation correct and if so then is this
intentional?

Cheers,
-Luke

             reply	other threads:[~2016-09-14 13:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14 13:24 Luke Gorrie [this message]
2016-09-14 14:30 ` Adrien Mazarguil
2016-09-14 19:33   ` Luke Gorrie
2016-09-16  7:14     ` Adrien Mazarguil
2016-09-16  7:57       ` Luke Gorrie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA2XHbd+c2vuFKu7CivDkAG+1KEhq28yKd+-GsJjMVukS-2CxA@mail.gmail.com \
    --to=luke@snabb.co \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).