From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21C6F45656; Fri, 19 Jul 2024 17:38:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C5C54270A; Fri, 19 Jul 2024 17:38:15 +0200 (CEST) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id AF1CC40EA5 for ; Fri, 19 Jul 2024 17:38:13 +0200 (CEST) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-767506e1136so1524465a12.0 for ; Fri, 19 Jul 2024 08:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1721403493; x=1722008293; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hOQQwVHSXRDvpJN+BxTlxB467RBGMn26TkHAxK1hTqE=; b=MdpenGxlpwP7SUwrzMEeMzzjzJGIW3qH7ubduJX1smUR0bnguSrARVKD24i73VyrXZ yazjmIoK2bT0CQHAzbATZHLSZKp29wnJb37CnX8jj+PHQZ7OnNF+Png6mnkhODfaB+8a d8B6O29dTMSP6/0Wb0+atX4TmS2/zimqYs+rM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721403493; x=1722008293; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hOQQwVHSXRDvpJN+BxTlxB467RBGMn26TkHAxK1hTqE=; b=VpdkNqmqFZxUksnufFdO2CceW/ZQnsyintWJftt0PtKfwg2h7cW612Tf2Bv9u5qXPh Lg/30z2HABLJVvDsGUAR583iD2nvamSmzbzuBtlDYPuJyC2TPSj/U5SRXZAO2yKo0MLD inxEJWEbb0jkUeq1XVCcAjI70YUbNrlK4i0aD6zzaE+/CmClmBWZYakRd4S4/bjP5Zx2 jsEN+0VI3DL5MyUnMDIWz62UBOOuqFGSQbwvAjvrYCb1rKhoV+Oa+lhvvjpJTcNh3PAO b4qZlyyNABTvNcy3ajDk4cTMWqnB6g/HMmE0KGMO7cDRFev452BQaaeRM6E1EcZxL7ly fJVg== X-Forwarded-Encrypted: i=1; AJvYcCWBtApwTXLYVH3AdBFTDYs0snz0cs+D5wT80mk4wJcrnRr3Va0K7hjwAlMXAIUj2EXlbpVVoklgFARFjBA= X-Gm-Message-State: AOJu0YyaXxch/ZN89ZhzYrZko1wsfiHXLGpfd37KFfa/EeCAXObPSY+E 0LEFwUnHFi5H59La9t/S13be/txPeDqc35ANwExlIR1qZrqEpHmTryhWWyI/rwAL4QG3sOg8/HB UjsozY7qdjfZ6gGNDPol5d0kVYd3V0bAiloMrhw== X-Google-Smtp-Source: AGHT+IGfCdjzQyfMSYPSevi5l++Jhfwk69Xs3uKgZv0UuZQoyHA38t2u3Lr+uzxOabKfCZfs2dsourU241f9dvlBbRI= X-Received: by 2002:a17:90a:a903:b0:2cb:4b31:1c48 with SMTP id 98e67ed59e1d1-2cb7755bf88mr6671846a91.22.1721403492676; Fri, 19 Jul 2024 08:38:12 -0700 (PDT) MIME-Version: 1.0 References: <20240718190509.4203-1-npratte@iol.unh.edu> <20240718194028.2849-1-npratte@iol.unh.edu> In-Reply-To: <20240718194028.2849-1-npratte@iol.unh.edu> From: Jeremy Spewock Date: Fri, 19 Jul 2024 11:38:00 -0400 Message-ID: Subject: Re: [PATCH v3 3/3] dts: mac filter test suite refactored for new dts To: Nicholas Pratte Cc: probb@iol.unh.edu, paul.szczepanek@arm.com, luca.vizzarro@arm.com, Honnappa.Nagarahalli@arm.com, dmarx@iol.unh.edu, yoan.picchi@foss.arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I just noticed one mistake in a doc-comment. Otherwise however, good work. Reviewed-by: Jeremy Spewock On Thu, Jul 18, 2024 at 3:40=E2=80=AFPM Nicholas Pratte wrote: > > The mac address filter test suite, whose test cases are based on old > DTS's test cases, has been refactored to interface with the new DTS > framework. > > In porting over this test suite into the new framework, some > adjustments were made, namely in the EAL and TestPMD parameter provided > before executing the application. While the original test plan was > referenced, by and large, only for the individual test cases, I'll leave > the parameters the original test plan was asking for below for the sake > of discussion: > > --burst=3D1 --rxpt=3D0 --rxht=3D0 --rxwt=3D0 --txpt=3D36 --txht=3D0 --txw= t=3D0 > --txfreet=3D32 --rxfreet=3D64 --mbcache=3D250 --portmask=3D0x3 > > Bugzilla ID: 1454 > Signed-off-by: Nicholas Pratte > > --- > + def send_packet_and_verify( > + self, > + mac_address: str, > + add_vlan: bool =3D False, > + should_receive: bool =3D True, > + ) -> None: > + """Generate, send, and verify a packet based on specified parame= ters. > + > + Test cases within this suite utilize this method to create, send= , and verify > + packets based on criteria relating to the packet's destination m= ac address, > + vlan tag, and whether or not the packet should be received or no= t. Packets > + are verified using an inserted payload. Assuming the test case e= xpects to > + receive a specified packet, if the list of received packets cont= ains this > + payload within any of its packets, the test case passes. Alterna= tively, if > + the designed packet should not be received, and the packet paylo= ad is not, I like this addition, but I just noticed that an additional comma snuck in after the "not" at the end of the line here. > + received, then the test case fails. Each call with this method s= ends exactly > + one packet. > + > + Args: > + mac_address: The destination mac address of the packet being= sent. > + add_vlan: If :data:'True', add a vlan tag to the packet bein= g sent. The > + vlan tag will be :data:'2' if the packet should be recei= ved and > + :data:'1' if the packet should not be received but requi= res a vlan tag. > + should_receive: If :data:'True', assert whether or not the s= ent packet > + has been received. If :data:'False', assert that the sen= d packet was not > + received. :data:'True' by default > + """ >