From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AD6B42D16; Wed, 21 Jun 2023 19:59:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCDD54068E; Wed, 21 Jun 2023 19:59:40 +0200 (CEST) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 64D1D4003C for ; Wed, 21 Jun 2023 19:59:39 +0200 (CEST) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-54290603887so3220792a12.1 for ; Wed, 21 Jun 2023 10:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1687370378; x=1689962378; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=itXr/HgZ/yEN2XH0bX1Nb7PReXBfRpG8UgoRbh+/mQI=; b=Phc7Vtef+UtFkGq9WkygUl9/4Qfa3rHmbDV5GoeTNB38cE53snRGKIdFUzDfO6Gj2N +4LHQOqFgsxU+6I9mT+yxPUWoY7uVvX7YRW//kgP7/AxTo/gzs+8mo8X7dX2cBKgQMC3 A293e1gHDY0JJuzKxZFu7WSXE85mJXW95Fnoo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687370378; x=1689962378; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=itXr/HgZ/yEN2XH0bX1Nb7PReXBfRpG8UgoRbh+/mQI=; b=FRV79Klu5kqMQwZdFfzFAZ0iSFf39eKFab3f69E751FTPPXbZtuoVGUowK1xMNqGA+ p394iDYuOn/BCJLQLYEnb4/prH+lf57Gtij4NLdVucX4PpPIb3ltSQtODj2AmiLF560Z GMtOvvyiBmDPrVQRD6kcjW2nsZHvDNYHHO3eSnL6UId50QTKu8tfWFehumLk/XI/yju0 GZ0c/7/Lvf0PqA4lZHbLOM7hSZGKg8MAvi3e8LYs4rGPy7AvNr4ErOxHWpuoKoT7WlhJ vlYA22GWqVvAbOzNpuzjLNGWzp4CU2r/cOPEOSUXwEjY3v30lWIGIWH5WT9D7ZAgF/JR kgNw== X-Gm-Message-State: AC+VfDxx2Aam2L8rba1myo76pc73luV+H3gpuylyNjK9C2x9wrvnDIIZ NaCBpCho/iDM+8hHXLmfEmdCD8Pc/2p+a6ufnZLc2w== X-Google-Smtp-Source: ACHHUZ6TRd5CgaDhv0GKwtCg39tE9SZHQY29In2HRFyqtJXGa9JAu/sdI97Aq8yMCGbtm6/FSYgQR6jtxwZpDOdx170= X-Received: by 2002:a17:90a:134b:b0:25b:a9f1:9dee with SMTP id y11-20020a17090a134b00b0025ba9f19deemr5825782pjf.0.1687370378431; Wed, 21 Jun 2023 10:59:38 -0700 (PDT) MIME-Version: 1.0 References: <20230331091355.1224059-1-juraj.linkes@pantheon.tech> <20230516101623.92252-1-juraj.linkes@pantheon.tech> In-Reply-To: From: Jeremy Spewock Date: Wed, 21 Jun 2023 13:59:27 -0400 Message-ID: Subject: Re: [PATCH v2] dts: update dependencies and mypy execution To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, probb@iol.unh.edu, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000002eace05fea78898" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000002eace05fea78898 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Acked-by: Jeremy Spweock On Tue, May 16, 2023 at 6:32=E2=80=AFAM Juraj Linke=C5=A1 wrote: > On Tue, May 16, 2023 at 12:16=E2=80=AFPM Juraj Linke=C5=A1 > wrote: > > > > Poetry changed the syntax of dev dependencies section in version > > 1.2.0. Remove the scripts section that did nothing. > > Update Pylama linters: > > * pep8 is the same as pycodestyle > > * pylint is missing dependencies and thus not executed. It reports a > > number of warnings and may be introduced in a future patch. > > * mypy doesn't work properly with Pylama. Pylama executes linting > > file-by-file and mypy works on all files at once. > > > > Mypy has thus been moved outside Pylama and is executed separately. > > Added Mypy configuration that allows fine-grained specification of > > ignored issues. > > > > Signed-off-by: Juraj Linke=C5=A1 > > --- > > devtools/dts-check-format.sh | 21 ++- > > doc/guides/tools/dts.rst | 1 + > > dts/poetry.lock | 304 +++++++++++++++++++++++++++-------- > > dts/pyproject.toml | 26 ++- > > 4 files changed, 276 insertions(+), 76 deletions(-) > > > > > > diff --git a/dts/poetry.lock b/dts/poetry.lock > > index 0b2a007d4d..64d6c18f35 100644 > > --- a/dts/poetry.lock > > +++ b/dts/poetry.lock > > @@ -1,24 +1,45 @@ > > +# This file is automatically @generated by Poetry and should not be > changed by hand. > > + > > Let's continue the discussion about the generated file we started > here: > http://patches.dpdk.org/project/dpdk/patch/20230403114608.1423020-1-juraj= .linkes@pantheon.tech/ > > > > > [[package]] > > name =3D "mypy" > > @@ -116,6 +165,31 @@ description =3D "Optional static typing for Python= " > > category =3D "dev" > > optional =3D false > > python-versions =3D ">=3D3.6" > > +files =3D [ > > + {file =3D "mypy-0.961-cp310-cp310-macosx_10_9_universal2.whl", has= h =3D > "sha256:697540876638ce349b01b6786bc6094ccdaba88af446a9abb967293ce6eaa2b0"= }, > > + {file =3D "mypy-0.961-cp310-cp310-macosx_10_9_x86_64.whl", hash = =3D > "sha256:b117650592e1782819829605a193360a08aa99f1fc23d1d71e1a75a142dc7e15"= }, > > + {file =3D "mypy-0.961-cp310-cp310-macosx_11_0_arm64.whl", hash =3D > "sha256:bdd5ca340beffb8c44cb9dc26697628d1b88c6bddf5c2f6eb308c46f269bb6f3"= }, > > + {file =3D > "mypy-0.961-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_= 2_12_x86_64.manylinux2010_x86_64.whl", > hash =3D > "sha256:3e09f1f983a71d0672bbc97ae33ee3709d10c779beb613febc36805a6e28bb4e"= }, > > + {file =3D "mypy-0.961-cp310-cp310-win_amd64.whl", hash =3D > "sha256:e999229b9f3198c0c880d5e269f9f8129c8862451ce53a011326cad38b9ccd24"= }, > > + {file =3D "mypy-0.961-cp36-cp36m-macosx_10_9_x86_64.whl", hash =3D > "sha256:b24be97351084b11582fef18d79004b3e4db572219deee0212078f7cf6352723"= }, > > + {file =3D > "mypy-0.961-cp36-cp36m-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2= _12_x86_64.manylinux2010_x86_64.whl", > hash =3D > "sha256:f4a21d01fc0ba4e31d82f0fff195682e29f9401a8bdb7173891070eb260aeb3b"= }, > > + {file =3D "mypy-0.961-cp36-cp36m-win_amd64.whl", hash =3D > "sha256:439c726a3b3da7ca84a0199a8ab444cd8896d95012c4a6c4a0d808e3147abf5d"= }, > > + {file =3D "mypy-0.961-cp37-cp37m-macosx_10_9_x86_64.whl", hash =3D > "sha256:5a0b53747f713f490affdceef835d8f0cb7285187a6a44c33821b6d1f46ed813"= }, > > + {file =3D > "mypy-0.961-cp37-cp37m-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2= _12_x86_64.manylinux2010_x86_64.whl", > hash =3D > "sha256:0e9f70df36405c25cc530a86eeda1e0867863d9471fe76d1273c783df3d35c2e"= }, > > + {file =3D "mypy-0.961-cp37-cp37m-win_amd64.whl", hash =3D > "sha256:b88f784e9e35dcaa075519096dc947a388319cb86811b6af621e3523980f1c8a"= }, > > + {file =3D "mypy-0.961-cp38-cp38-macosx_10_9_universal2.whl", hash = =3D > "sha256:d5aaf1edaa7692490f72bdb9fbd941fbf2e201713523bdb3f4038be0af8846c6"= }, > > + {file =3D "mypy-0.961-cp38-cp38-macosx_10_9_x86_64.whl", hash =3D > "sha256:9f5f5a74085d9a81a1f9c78081d60a0040c3efb3f28e5c9912b900adf59a16e6"= }, > > + {file =3D "mypy-0.961-cp38-cp38-macosx_11_0_arm64.whl", hash =3D > "sha256:f4b794db44168a4fc886e3450201365c9526a522c46ba089b55e1f11c163750d"= }, > > + {file =3D > "mypy-0.961-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_= 12_x86_64.manylinux2010_x86_64.whl", > hash =3D > "sha256:64759a273d590040a592e0f4186539858c948302c653c2eac840c7a3cd29e51b"= }, > > + {file =3D "mypy-0.961-cp38-cp38-win_amd64.whl", hash =3D > "sha256:63e85a03770ebf403291ec50097954cc5caf2a9205c888ce3a61bd3f82e17569"= }, > > + {file =3D "mypy-0.961-cp39-cp39-macosx_10_9_universal2.whl", hash = =3D > "sha256:5f1332964963d4832a94bebc10f13d3279be3ce8f6c64da563d6ee6e2eeda932"= }, > > + {file =3D "mypy-0.961-cp39-cp39-macosx_10_9_x86_64.whl", hash =3D > "sha256:006be38474216b833eca29ff6b73e143386f352e10e9c2fbe76aa8549e5554f5"= }, > > + {file =3D "mypy-0.961-cp39-cp39-macosx_11_0_arm64.whl", hash =3D > "sha256:9940e6916ed9371809b35b2154baf1f684acba935cd09928952310fbddaba648"= }, > > + {file =3D > "mypy-0.961-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_= 12_x86_64.manylinux2010_x86_64.whl", > hash =3D > "sha256:a5ea0875a049de1b63b972456542f04643daf320d27dc592d7c3d9cd5d9bf950"= }, > > + {file =3D "mypy-0.961-cp39-cp39-win_amd64.whl", hash =3D > "sha256:1ece702f29270ec6af25db8cf6185c04c02311c6bb21a69f423d40e527b75c56"= }, > > + {file =3D "mypy-0.961-py3-none-any.whl", hash =3D > "sha256:03c6cc893e7563e7b2949b969e63f02c000b32502a1b4d1314cabe391aa87d66"= }, > > + {file =3D "mypy-0.961.tar.gz", hash =3D > "sha256:f730d56cb924d371c26b8eaddeea3cc07d78ff51c521c6d04899ac6904b75492"= }, > > +] > > The contentious point was the non-linux files among the lists of files > in some packages. > I think leaving these in doesn't result in any extra work in terms of > review or maintenance. There's no reason to review this file, as it's > effectively automatically managed by Poetry and the only maintenance > needed is to update it when updating/adding dependencies. In addition, > no one will (or should) ever look into this file, it's not meant to be > consumed by users. > Also, DTS is designed to allow support for different OS's (if anyone > wishes to implement it), so leaving it in makes sense in this way. > --00000000000002eace05fea78898 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Acked-by: Jeremy Spweock <jspweock@iol.unh.edu>

On Tue, May 16, 202= 3 at 6:32=E2=80=AFAM Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> w= rote:
On Tue, Ma= y 16, 2023 at 12:16=E2=80=AFPM Juraj Linke=C5=A1
<juraj.linkes@pantheon.tech> wrote:
>
> Poetry changed the syntax of dev dependencies section in version
> 1.2.0. Remove the scripts section that did nothing.
> Update Pylama linters:
> * pep8 is the same as pycodestyle
> * pylint is missing dependencies and thus not executed. It reports a >=C2=A0 =C2=A0number of warnings and may be introduced in a future patch= .
> * mypy doesn't work properly with Pylama. Pylama executes linting<= br> >=C2=A0 =C2=A0file-by-file and mypy works on all files at once.
>
> Mypy has thus been moved outside Pylama and is executed separately. > Added Mypy configuration that allows fine-grained specification of
> ignored issues.
>
> Signed-off-by: Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> > ---
>=C2=A0 devtools/dts-check-format.sh |=C2=A0 21 ++-
>=C2=A0 doc/guides/tools/dts.rst=C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A01 + >=C2=A0 dts/poetry.lock=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = | 304 +++++++++++++++++++++++++++--------
>=C2=A0 dts/pyproject.toml=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 26 ++-
>=C2=A0 4 files changed, 276 insertions(+), 76 deletions(-)
>
>
> diff --git a/dts/poetry.lock b/dts/poetry.lock
> index 0b2a007d4d..64d6c18f35 100644
> --- a/dts/poetry.lock
> +++ b/dts/poetry.lock
> @@ -1,24 +1,45 @@
> +# This file is automatically @generated by Poetry and should not be c= hanged by hand.
> +

Let's continue the discussion about the generated file we started
here: http://patches.dpdk.org/project/dpdk/patch/20230403114608.1423020-1-juraj.= linkes@pantheon.tech/

<snip>

>=C2=A0 [[package]]
>=C2=A0 name =3D "mypy"
> @@ -116,6 +165,31 @@ description =3D "Optional static typing for = Python"
>=C2=A0 category =3D "dev"
>=C2=A0 optional =3D false
>=C2=A0 python-versions =3D ">=3D3.6"
> +files =3D [
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp310-cp310-macosx_10_9_univ= ersal2.whl", hash =3D "sha256:697540876638ce349b01b6786bc6094ccda= ba88af446a9abb967293ce6eaa2b0"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp310-cp310-macosx_10_9_x86_= 64.whl", hash =3D "sha256:b117650592e1782819829605a193360a08aa99f= 1fc23d1d71e1a75a142dc7e15"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp310-cp310-macosx_11_0_arm6= 4.whl", hash =3D "sha256:bdd5ca340beffb8c44cb9dc26697628d1b88c6bd= df5c2f6eb308c46f269bb6f3"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp310-cp310-manylinux_2_5_x8= 6_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl"= , hash =3D "sha256:3e09f1f983a71d0672bbc97ae33ee3709d10c779beb613febc3= 6805a6e28bb4e"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp310-cp310-win_amd64.whl&qu= ot;, hash =3D "sha256:e999229b9f3198c0c880d5e269f9f8129c8862451ce53a01= 1326cad38b9ccd24"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp36-cp36m-macosx_10_9_x86_6= 4.whl", hash =3D "sha256:b24be97351084b11582fef18d79004b3e4db5722= 19deee0212078f7cf6352723"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp36-cp36m-manylinux_2_5_x86= _64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl",= hash =3D "sha256:f4a21d01fc0ba4e31d82f0fff195682e29f9401a8bdb71738910= 70eb260aeb3b"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp36-cp36m-win_amd64.whl&quo= t;, hash =3D "sha256:439c726a3b3da7ca84a0199a8ab444cd8896d95012c4a6c4a= 0d808e3147abf5d"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp37-cp37m-macosx_10_9_x86_6= 4.whl", hash =3D "sha256:5a0b53747f713f490affdceef835d8f0cb728518= 7a6a44c33821b6d1f46ed813"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp37-cp37m-manylinux_2_5_x86= _64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl",= hash =3D "sha256:0e9f70df36405c25cc530a86eeda1e0867863d9471fe76d1273c= 783df3d35c2e"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp37-cp37m-win_amd64.whl&quo= t;, hash =3D "sha256:b88f784e9e35dcaa075519096dc947a388319cb86811b6af6= 21e3523980f1c8a"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp38-cp38-macosx_10_9_univer= sal2.whl", hash =3D "sha256:d5aaf1edaa7692490f72bdb9fbd941fbf2e20= 1713523bdb3f4038be0af8846c6"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp38-cp38-macosx_10_9_x86_64= .whl", hash =3D "sha256:9f5f5a74085d9a81a1f9c78081d60a0040c3efb3f= 28e5c9912b900adf59a16e6"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp38-cp38-macosx_11_0_arm64.= whl", hash =3D "sha256:f4b794db44168a4fc886e3450201365c9526a522c4= 6ba089b55e1f11c163750d"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp38-cp38-manylinux_2_5_x86_= 64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", = hash =3D "sha256:64759a273d590040a592e0f4186539858c948302c653c2eac840c= 7a3cd29e51b"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp38-cp38-win_amd64.whl"= ;, hash =3D "sha256:63e85a03770ebf403291ec50097954cc5caf2a9205c888ce3a= 61bd3f82e17569"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp39-cp39-macosx_10_9_univer= sal2.whl", hash =3D "sha256:5f1332964963d4832a94bebc10f13d3279be3= ce8f6c64da563d6ee6e2eeda932"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp39-cp39-macosx_10_9_x86_64= .whl", hash =3D "sha256:006be38474216b833eca29ff6b73e143386f352e1= 0e9c2fbe76aa8549e5554f5"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp39-cp39-macosx_11_0_arm64.= whl", hash =3D "sha256:9940e6916ed9371809b35b2154baf1f684acba935c= d09928952310fbddaba648"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp39-cp39-manylinux_2_5_x86_= 64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", = hash =3D "sha256:a5ea0875a049de1b63b972456542f04643daf320d27dc592d7c3d= 9cd5d9bf950"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-cp39-cp39-win_amd64.whl"= ;, hash =3D "sha256:1ece702f29270ec6af25db8cf6185c04c02311c6bb21a69f42= 3d40e527b75c56"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961-py3-none-any.whl", hash= =3D "sha256:03c6cc893e7563e7b2949b969e63f02c000b32502a1b4d1314cabe391= aa87d66"},
> +=C2=A0 =C2=A0 {file =3D "mypy-0.961.tar.gz", hash =3D "= ;sha256:f730d56cb924d371c26b8eaddeea3cc07d78ff51c521c6d04899ac6904b75492&qu= ot;},
> +]

The contentious point was the non-linux files among the lists of files
in some packages.
I think leaving these in doesn't result in any extra work in terms of review or maintenance. There's no reason to review this file, as it'= ;s
effectively automatically managed by Poetry and the only maintenance
needed is to update it when updating/adding dependencies. In addition,
no one will (or should) ever look into this file, it's not meant to be<= br> consumed by users.
Also, DTS is designed to allow support for different OS's (if anyone wishes to implement it), so leaving it in makes sense in this way.
--00000000000002eace05fea78898--