From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADC0E459D7; Fri, 20 Sep 2024 17:56:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 510CE43431; Fri, 20 Sep 2024 17:56:08 +0200 (CEST) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id BF2DF43444 for ; Fri, 20 Sep 2024 17:56:07 +0200 (CEST) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-7db53a20d1fso1495723a12.0 for ; Fri, 20 Sep 2024 08:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1726847767; x=1727452567; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SSAqP/qpv7vfPk8QKN2bQnPWCw0zrvnidMAlp6c7oqA=; b=a0Vk4Cg2XrH2cxqVvpwRt/VaUeh13WruT7PDFcxrrwDISNQ2faAwIIg83cNXUn/s1J 4yq7XfnFA9h/6Bc0ENgmMBiKdRzdebtWg8R1d7/qeVsEwmiE58kBH6n4iwTLcq1KVxLh SJgNjFoI0IV2phE2Ug3mO26/WtFZkkAjOjiKs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726847767; x=1727452567; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SSAqP/qpv7vfPk8QKN2bQnPWCw0zrvnidMAlp6c7oqA=; b=toAbpBW0XmRe+ik2UbDIuDh4B9lYuYS6cbz4J77T+TOs2hJMLObyWHj1bVLPXUxwCi gXhjmxJUN1EycwWFdIHGgMWKinviEW3FOWO95wg91iXzYtEqcGjEdS+YLKQjWgG/jDAe GokoOeXlQHyIFLgPtTZVY9ykl0vbSo2LNQZ8eVWR2xDkp1orrK7QljGIjoDgp5P6blGL pGeZkB6ucF4HqRKy+drp9kRmGY/zMA3Dfjs8E9lxOfpqzsoWRs4PaQtN23Iv9TmaDsez DxJTqKTcOgiZemVTl9H9VHT/oE8teTVN+xQdyoPtSezFdzn3F5a4VXy0FxhoMEEmH1/K cViw== X-Forwarded-Encrypted: i=1; AJvYcCWLtbKj33p8VLGzS2jVtlBFQDWKbXDbWnajlv1ffroD70F5Z6IyluQc9ec99ksGWbn2T+o=@dpdk.org X-Gm-Message-State: AOJu0Yw4S6FEQZUowbKaigvzxYxHPqco1hwgbLWOSI74Z/HD9Xf+pbG1 c1QrIYkKoXKZdVvdVW9nUJ3WY/0fDM1zANxrS7DE1L8SNN2ogpBpxaGzAtTYsPT92sahil3EVt8 C4zLVE4NJxT48oVDCzi8J54/eFehBmKNYH62blw== X-Google-Smtp-Source: AGHT+IEIVKMtQ6yTtVOhNCMCZdIdSEp4ljBL88mLHDO++NJNynanKicMINa8IIe0sYK2PpedqZlCU/9g07KlwsWWyhI= X-Received: by 2002:a05:6a20:c888:b0:1cf:2843:f798 with SMTP id adf61e73a8af0-1d30cb64605mr3852696637.47.1726847766957; Fri, 20 Sep 2024 08:56:06 -0700 (PDT) MIME-Version: 1.0 References: <20240729203955.267942-1-jspewock@iol.unh.edu> <20240918170528.14545-1-jspewock@iol.unh.edu> <20240918170528.14545-2-jspewock@iol.unh.edu> In-Reply-To: From: Jeremy Spewock Date: Fri, 20 Sep 2024 11:55:56 -0400 Message-ID: Subject: Re: [PATCH v5 1/1] dts: add text parser for testpmd verbose output To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: alex.chapman@arm.com, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, Honnappa.Nagarahalli@arm.com, wathsala.vithanage@arm.com, probb@iol.unh.edu, npratte@iol.unh.edu, thomas@monjalon.net, yoan.picchi@foss.arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 19, 2024 at 8:35=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > > diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framew= ork/remote_session/testpmd_shell.py > > > @@ -577,6 +577,497 @@ class TestPmdPortStats(TextParser): > > tx_bps: int =3D field(metadata=3DTextParser.find_int(r"Tx-bps:\s+= (\d+)")) > > > > > > +class PacketOffloadFlag(Flag): > > + """Flag representing the Packet Offload Features Flags in DPDK. > > + > > + Values in this class are taken from the definitions in the RTE MBU= F core library in DPDK > > + located in lib/mbuf/rte_mbuf_core.h. It is expected that flag valu= es in this class will match > > Another minor improvement: we should put the file path into double > backticks. Looking at DPDK docs, that's what they use for file paths, so > ``lib/mbuf/rte_mbuf_core.h``. good idea, I didn't know there was already a format for doing this. > > There's also a References section that supported by google docstrings. I > don't know exactly what to put in it, but I'll try to use it in my > patch. I imagine a list of files (or functions) would be useful - we > could put the DPDK sources and testpmd functions that are relevant there. I'll have to read about this as well, I didn't know that was a thing either= :). >