From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96C1E455CE; Tue, 9 Jul 2024 23:22:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 639DE42D27; Tue, 9 Jul 2024 23:22:51 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 3889E4281D for ; Tue, 9 Jul 2024 23:22:50 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2bfdae7997aso3448094a91.2 for ; Tue, 09 Jul 2024 14:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1720560169; x=1721164969; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WguHrQLTXWa1XUsPUZ2PQ5/Jgz70SbMoPwGeWD8rQGU=; b=IoWubaDYdb1FMAT2BM6mu34NRG748Dp1IzKWMvnCcjJIr13Y+8jGzWig9JA980TK4t WSLU3CNWqXEUCFfXT4bxeEbHeGJR2OlpdYkES57n2s7XqK+6xgFUkiGEs/HMuWq4wNPD Iok6GThLVETidIpxIAoTB66tMQm/zYXLy2jBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720560169; x=1721164969; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WguHrQLTXWa1XUsPUZ2PQ5/Jgz70SbMoPwGeWD8rQGU=; b=vtOGofOGUGXsIA6CEPCNuWzujw+160KcHySV8piQJrDGFfLr5XN4Un8PBGTAFTCvaG 8AySx2G87Ivx2FoEbTe+Djv86GZ8ZgNpCpBvuggkiJMKrxP1Ws3Xs8apfYhI4wpVY22x BDxUPvgpRimbIEzINkLGaaW8m3uIvIbEjJbu91T7b7F6Qll12zFtJ0dxz8O6x0PMib7Q GXWHmK4QxaNQgDMyZaxNaquMJ7Yp2/jSmdbAV+6ihjQXBR8AIuPT9GU4glVTZYMVamZk QX3mlpvoATldmAz4d9ACFw8QLg0YHZm2vfj4NRjZCVAVeK+h7B5uLBRPJvNN+6M2SYYc GMOg== X-Forwarded-Encrypted: i=1; AJvYcCVkFptKzh1x9uvJ7kH7UbrnsnuyNa7mukhCess7OK4hJoqduRhgN1q4YBRmKvY6IaE9hxkhR78auzV/q9Y= X-Gm-Message-State: AOJu0YzIX0614HN4xLg4uPXsXRdwInBrkzJFAsdMIXWQGRkhTnOklXLb V2+BunLXxp9C/NyuQntGk7k/XYovYwYPkj93gHW0Km73J6w8AasUd4sOl5uL9VZzVYUmsdXLXNn 6NuaSUD5fFpJKhILrTOOZh6bcDU/m4RsxTbyzGw== X-Google-Smtp-Source: AGHT+IEQ43+ffnG+SJd+mxcSHJgolqxIRDU9zeBAj+2nhz5vnzuIqmyXdqo4FYwGddK41w23PVGszVTcvTHpXQszfGg= X-Received: by 2002:a17:90a:be09:b0:2c8:452d:e634 with SMTP id 98e67ed59e1d1-2ca35d62a22mr2753211a91.45.1720560169240; Tue, 09 Jul 2024 14:22:49 -0700 (PDT) MIME-Version: 1.0 References: <20240614150238.26374-1-dmarx@iol.unh.edu> <20240703165055.18939-1-dmarx@iol.unh.edu> <20240703165055.18939-2-dmarx@iol.unh.edu> In-Reply-To: <20240703165055.18939-2-dmarx@iol.unh.edu> From: Jeremy Spewock Date: Tue, 9 Jul 2024 17:22:38 -0400 Message-ID: Subject: Re: [PATCH v10 2/3] dts: VLAN test suite implementation To: Dean Marx Cc: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, bruce.richardson@intel.com, luca.vizzarro@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I just had one minor comment, otherwise: Reviewed-by: Jeremy Spewock On Wed, Jul 3, 2024 at 12:51=E2=80=AFPM Dean Marx wrote= : > + > + def vlan_setup(self, port_id: int, filtered_id: int) -> TestPmdShell= : > + """Setup method for all test cases. > + > + Args: > + shell: TestPmdShell object that is being used inside test ca= se. It seems this argument was removed from the method, it's probably better to remove it from this doc-string as well. > + port_id: Number of port to use for setup. > + filtered_id: ID to be added to the vlan filter list. > + """ > + testpmd =3D TestPmdShell(node=3Dself.sut_node) > + testpmd.set_forward_mode(SimpleForwardingModes.mac) > + testpmd.set_promisc(port_id, False) > + testpmd.vlan_filter_set(port=3Dport_id, on=3DTrue) > + testpmd.rx_vlan(vlan=3Dfiltered_id, port=3Dport_id, add=3DTrue) > + return testpmd > + > 2.44.0 >