From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 763AE4553B; Mon, 1 Jul 2024 21:48:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39362402CD; Mon, 1 Jul 2024 21:48:18 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 3ED35402A3 for ; Mon, 1 Jul 2024 21:48:16 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2bfdae7997aso2081141a91.2 for ; Mon, 01 Jul 2024 12:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1719863295; x=1720468095; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=w/zd1WaIsK53ld8pFxSVWrYJl6ffcqQDJOOXZYGuSDw=; b=aZ9Sv/PR9ZbyoOgEHjS+HczfUJS1Fq4p4G7yEIZwZFQFgcffybDO6/QtetjP5gV6b+ enTpJW5xlBJJfn5eTHa33TCkDGgy6isytp/jgFX4rmGdEDxlGZWAXVlfSOLQTgzMOVBI EkTCMdxb5uP0OpJj6NMgHY6JtVEi1nAed7BSM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719863295; x=1720468095; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w/zd1WaIsK53ld8pFxSVWrYJl6ffcqQDJOOXZYGuSDw=; b=JdnCljmgVcXf91QBGrOhgw8zDiTpza+LP0iAKmgZ6K96kf6051EHuU1N93oorG+px6 7Yp2TPQA/NXk1F6DFXBdDx1xnkDdlTA9zZR3o+cmaKEaiaHDU2Xh+IizyAWXICBPWras 6NGf1u9gnhRms5tkrOhOBQQJ6S7rqp9eEORv570xrOQLDKXZr9/bvfxSMfBkAfvM49ir eEoTrpAa3TVoJ4vgab9IlsycOYL/O8/uAkhEztUBXhqZMuy26D3qkYQZXpPq4xLUsLAJ 9aVqPk+aPju83pHS/wjztJUEV4iixtC71I2ntMaFtrhUsmpQ1/igiHnd8bX97rq1HEOA 6foA== X-Forwarded-Encrypted: i=1; AJvYcCWPSSfalZh9hCLM7GNmjT7QzDEAGA9A6YukxRtAvMeYzm9vIs09A9zGQIFw2m5rjUZIRgQnCwkbIsVMCT8= X-Gm-Message-State: AOJu0YwQVI6zmLPNmv7FThHa6vbv79y2/a44/fO5EuhXe39xFdDD4Ziy W3OcwY4h53ZOHN0dMoFu4yl6me6enPK85NKH7d/8omHObdKJO/nbl8oK5dFz+7WNtT8LxNCfLWC 7YAbvzb2Rz68vv4vwW8I4ypH36hgr91oIWi/5JQ== X-Google-Smtp-Source: AGHT+IE1GBh3nsi3NupR7F6yEr52cuT/BebdW6kP7HQuVSlp++d3FrVpG3SJwgJ5JAbsvKEyxftSr2q1JfGAris38I8= X-Received: by 2002:a17:90a:ec18:b0:2c8:452d:e634 with SMTP id 98e67ed59e1d1-2c93d786a43mr3259655a91.45.1719863295161; Mon, 01 Jul 2024 12:48:15 -0700 (PDT) MIME-Version: 1.0 References: <20240614150238.26374-1-dmarx@iol.unh.edu> <20240628140010.27425-1-dmarx@iol.unh.edu> In-Reply-To: <20240628140010.27425-1-dmarx@iol.unh.edu> From: Jeremy Spewock Date: Mon, 1 Jul 2024 15:48:03 -0400 Message-ID: Subject: Re: [PATCH v8 1/3] dts: add VLAN methods to testpmd shell To: Dean Marx Cc: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, bruce.richardson@intel.com, luca.vizzarro@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hey Dean, I think this series looks good, thanks for addressing my comments! The only other comment I have on this version is that it looks like the formatting script is throwing some warnings, so those fixes might have been left out of the diff when this series was submitted. I think once the formatting script errors are fixed however, it would look good by my standards. Thanks, Jeremy