From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FC7B4545B; Fri, 14 Jun 2024 15:56:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D38541149; Fri, 14 Jun 2024 15:56:19 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id D5E9341148 for ; Fri, 14 Jun 2024 15:56:17 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-705c739b878so2066539b3a.1 for ; Fri, 14 Jun 2024 06:56:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1718373377; x=1718978177; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=47L1oh+qRy4s2Z9pz+BxK9xYDI0Gh84p9YKW2N2auEI=; b=FejqZNKiGcOoZxZadeSpT47cbTUCOZzX9NSHKoLu/9H2kQzJXMzP0yBWi6an7IJdgg RHX59T8T5VIF6ELU55OJ7hj/g/ZnvM5y2tYYY/ZnaK09wKynv5GDjr4B6w1X8uYuCw4J b8MqyhTv69GHviQv/53m9o3hddKm+1vwFgDVU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718373377; x=1718978177; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=47L1oh+qRy4s2Z9pz+BxK9xYDI0Gh84p9YKW2N2auEI=; b=SERCat42M3tc2SEiic86o+sq7Vv/IUa5FjtnZwAPYcQi+tqJARHrs48o64nbVCAkQE YZOipRWxtwOSB+KjXGWotofynv1VDAty9kRzgvdUwf4HLDL6gRmzUSEc3ALZioJQiQw7 C12nJPqZl0iGRVWGO+wN2O1ELxnY8BEPb8UwIzwNDDK6gR5rENg15KAU1BUagBRkdI43 QEna0RsjsTQjsOLfOI3sjCep0Sni55FPXOn5GwpHDdj1bS4XG03D/RWAMcUeiY3Ye7PF W0idb3Ivj0cFgz+y9EYS8yUo0xLBICne+iPPaGAs7g5b46+JYXaAtqnpftJe7q9zfNvF x0lg== X-Forwarded-Encrypted: i=1; AJvYcCXFpxTYxRMG6tZdfkd1YIgF6sVCn+xJecxvrl+Rrjax+p0LvuR8/PEkiwG9RrfL+a7BdtU6n4FYea4NltE= X-Gm-Message-State: AOJu0YwEYHHR6COgV8XlirhjsPpH1eV+kF6YpFt6kK+IenE9irH7V43B G7tt/4SZC+aINNzhrENCLcNVFIHRRcu16NYW3ywHNPpAvV1AlDZbQ3HZoGhL7hPUvpxBynOolHn dhjbVGA4GB+86oeMfFYnD22m+s5eBl3dyj5f9VE+NWL5YrCHF X-Google-Smtp-Source: AGHT+IGCMJ2S3P2u6eXgdSUREYkYdZ3Cxwtxvog5wB5+3e3CjyA90dRr8l+z4BBuy1uy7llEBkKaDaoSwcQ1I8hcM9o= X-Received: by 2002:a17:90b:370f:b0:2c4:ca7f:c76d with SMTP id 98e67ed59e1d1-2c4da542699mr4669509a91.10.1718373377052; Fri, 14 Jun 2024 06:56:17 -0700 (PDT) MIME-Version: 1.0 References: <20240122182611.1904974-1-luca.vizzarro@arm.com> <20240531112042.18736-1-luca.vizzarro@arm.com> <20240531112042.18736-3-luca.vizzarro@arm.com> In-Reply-To: From: Jeremy Spewock Date: Fri, 14 Jun 2024 09:56:05 -0400 Message-ID: Subject: Re: [PATCH v6 2/3] dts: constrain DPDK source argument To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: Luca Vizzarro , dev@dpdk.org, Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 31, 2024 at 8:51=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > On Fri, May 31, 2024 at 1:22=E2=80=AFPM Luca Vizzarro wrote: > > > > DTS needs an input to gather the DPDK source code from. This is then > > built on the remote target. This commit makes sure that this input is > > more constrained, separating the Git revision ID =E2=80=93 used to crea= te a > > tarball using Git =E2=80=93 and providing tarballed source code directl= y, while > > retaining mutual exclusion. > > > > This makes the code more readable and easier to handle for input > > validation, of which this commit introduces a basic one based on the > > pre-existing code. > > > > Moreover it ensures that these flags are explicitly required to be set > > by the user, dropping a default value. > > > > Signed-off-by: Luca Vizzarro > > Reviewed-by: Paul Szczepanek > > Reviewed-by: Juraj Linke=C5=A1 Reviewed-by: Jeremy Spewock