From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF1204590E; Thu, 5 Sep 2024 17:27:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8A9442E61; Thu, 5 Sep 2024 17:27:50 +0200 (CEST) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id EF9F742E5F for ; Thu, 5 Sep 2024 17:27:48 +0200 (CEST) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2d87f34a650so675897a91.1 for ; Thu, 05 Sep 2024 08:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1725550068; x=1726154868; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1ZFnjaD6UVdKX/09+NsHVydtrWfL9gxMSzQSdzkVJrQ=; b=IzPP8bQ9p6hG4FVgyEyHY2PaXEVksAHWkNx/xbt11TUcUyvDWP8SrX4h6lylR9db+d ldXWLnouuAwXBUKEbd2obLY+DPvTuef/yU7XfFohciLVOMYVzEglV7WMlYeAUhNVk9rf B5lKcIKhoQGhz8yeAn5MxIIdB0NcNOl6PqCiU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725550068; x=1726154868; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1ZFnjaD6UVdKX/09+NsHVydtrWfL9gxMSzQSdzkVJrQ=; b=rsD9K8shTeIWPf50BjHtDb+wPqW3+5NtrrqrEU7yTFENhNeRFyTSwLoeBxF6SNeDBe 2xB53Kjb0dHbQ9zpHdDZw1RY9azL824naiw+0AjkZW0wv+CXPh/jNLDT/NcbH5UvbtN+ 58fQiphtA+bm8Rj1bk1XCaeWDvWbYRfEz2e7z+3cWLVvp+XZPH2Kq0uD2hEBARy0OnBV 77Tq/8i9YCpoviTGwggWpicdYUWAIRClAwO4tfqzOh3WMIbYh5yZOJRfZhWeX4qv34Zo MI3mAtWtUhwSE2Ti4fHYQXMnEXXfQf4s1b5bSaNUM4XnwHdObuyRCe+uQed3ySdWcuTv QhLg== X-Forwarded-Encrypted: i=1; AJvYcCUJhRLCDMiR784ek5qTKqWq8lVDz5P6YN+x5owGqJNPBKK4jrNFHiK9IZpsWP/9VaHjUfE=@dpdk.org X-Gm-Message-State: AOJu0YwWv0pRlKIJWboAzrs3yWKgp9hagPQly8KE2H0MeKCDzRoSBtvf 1vaCWpoUNQIUjB05iKo4DU7Z6Oo+LgeHlhKdRXdw9jXRvJpixCz+FdyA4+AbXEF64Jx1afdbNuI RvGnRJMYLT/eb2gHwbG/EwJy7RaLrC3ywcsknaQ== X-Google-Smtp-Source: AGHT+IE/U6KLnynMyr7a8Hmun3RI5m0ur3ydSdgk+H0gcaBSRIOI0CGqtFVJaZZlrd+6ZdSoYrKwcwRgSa2vsmnewjE= X-Received: by 2002:a17:90a:6fc5:b0:2da:8b9f:5b74 with SMTP id 98e67ed59e1d1-2da8eef3c08mr10511593a91.13.1725550067947; Thu, 05 Sep 2024 08:27:47 -0700 (PDT) MIME-Version: 1.0 References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240821145315.97974-1-juraj.linkes@pantheon.tech> <20240821145315.97974-7-juraj.linkes@pantheon.tech> <303c71e1-bac3-4af7-aa16-36b2c34ae000@pantheon.tech> In-Reply-To: <303c71e1-bac3-4af7-aa16-36b2c34ae000@pantheon.tech> From: Jeremy Spewock Date: Thu, 5 Sep 2024 11:27:36 -0400 Message-ID: Subject: Re: [PATCH v3 06/12] dst: add basic capability support To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, dmarx@iol.unh.edu, alex.chapman@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 5, 2024 at 5:50=E2=80=AFAM Juraj Linke=C5=A1 wrote: > >> @@ -63,6 +65,12 @@ class is to hold a subset of test cases (which coul= d be all test cases) because > >> > >> test_suite_class: type[TestSuite] > >> test_cases: list[type[TestCase]] > >> + required_capabilities: set[Capability] =3D field(default_factory= =3Dset, init=3DFalse) > > > > This should probably be added to the Attributes section of the > > doc-string for the class. > > Ah, I missed this, thanks. > > > When it's there, it might also be useful to > > explain that this is used by the runner to determine what capabilities > > need to be searched for to mark the suite for being skipped. > > And also test cases. > > > The only > > reason I think that would be useful is it helps differentiate this > > list of capabilities from the list of required capabilities that every > > test suite and test case has. > > > > I want to add this: > The combined required capabilities of both the test suite and the subset > of test cases. > > I think this makes it clear that it's different from the individual > required capabilities of test suites and cases. Let me know what you thin= k. > Yeah, I also think that makes the difference clear, sounds great to me, tha= nks! > >> + > >> + def __post_init__(self): > >> + """Gather the required capabilities of the test suite and all= test cases.""" > >> + for test_object in [self.test_suite_class] + self.test_cases: > >> + self.required_capabilities.update(test_object.required_ca= pabilities) > > > >> >